commit 0cb158969c87b49e9da53a82ab6d18ad3d6d0775
author Mike Klein <mtklein@chromium.org> Tue Oct 24 11:07:09 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Oct 24 18:55:33 2017 +0000
tree 42dced0652908393d6107b9806e23e9417820eaa
parent b2fd61a05850b61c3e3e3341487b2de0492ad7ad

add srcover_bgra_8888

Chrome generally uses BGRA buffers, so srcover_rgba_8888 isn't really
doing them any good.  Probably a good idea to cover both kN32 options
any time we specialize like this?

There's one small diff, so I've lazily guarded this by
SK_LEGACY_LOWP_STAGES, which I want to rebaseline today anyway.

Change-Id: Ice672aa01a3fc83be0798580d6730a54df075478
Reviewed-on: https://skia-review.googlesource.com/63301
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>

src/core/SkRasterPipelineBlitter.cpp

diff --git a/src/core/SkRasterPipelineBlitter.cpp b/src/core/SkRasterPipelineBlitter.cpp
index b0ee301..d2eb099 100644
--- a/src/core/SkRasterPipelineBlitter.cpp
+++ b/src/core/SkRasterPipelineBlitter.cpp
@@ -305,6 +305,7 @@
     if (!fBlitRect) {
         SkRasterPipeline p(fAlloc);
         p.extend(fColorPipeline);
+    #if defined(SK_LEGACY_LOWP_STAGES)
         if (fBlend == SkBlendMode::kSrcOver
                 && fDst.info().colorType() == kRGBA_8888_SkColorType
                 && !fDst.colorSpace()
@@ -312,6 +313,19 @@
                 && fDitherRate == 0.0f) {
             p.clamp_if_unclamped(kPremul_SkAlphaType);
             p.append(SkRasterPipeline::srcover_rgba_8888, &fDstPtr);
+    #else
+        if (fBlend == SkBlendMode::kSrcOver
+                && (fDst.info().colorType() == kRGBA_8888_SkColorType ||
+                    fDst.info().colorType() == kBGRA_8888_SkColorType)
+                && !fDst.colorSpace()
+                && fDst.info().alphaType() != kUnpremul_SkAlphaType
+                && fDitherRate == 0.0f) {
+            p.clamp_if_unclamped(kPremul_SkAlphaType);
+            auto stage = fDst.info().colorType() == kRGBA_8888_SkColorType
+                       ? SkRasterPipeline::srcover_rgba_8888
+                       : SkRasterPipeline::srcover_bgra_8888;
+            p.append(stage, &fDstPtr);
+    #endif
         } else {
             if (fBlend != SkBlendMode::kSrc) {
                 this->append_load_dst(&p);