commit 0e0f1a71da39f83a6c5814d28f416e06da282501
author Florin Malita <fmalita@chromium.org> Tue Sep 11 16:16:19 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Sep 11 20:43:22 2018 +0000
tree 021b0998beae3a974d96e3df5ed54ece1d37a406
parent 90c7d9b10ec39822701e453f007c3a39c1fd0c07

SkPath::shrinkToFit docs

Add header and .bmh docs for shrinkToFit().

Also remove SkPath::debugging_private_getFreeSpace() and refactor tests
to use (friended) helper classes.

Docs-Preview: https://skia.org/?cl=153668
Change-Id: I3f93f9561b25025ce04a81d5e2f0271295b3daad
Reviewed-on: https://skia-review.googlesource.com/153668
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

tests/PathTest.cpp

diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp
index acf0e25..349a309 100644
--- a/tests/PathTest.cpp
+++ b/tests/PathTest.cpp
@@ -4090,6 +4090,10 @@
 
 class PathRefTest_Private {
 public:
+    static size_t GetFreeSpace(const SkPathRef& ref) {
+        return ref.fFreeSpace;
+    }
+
     static void TestPathRef(skiatest::Reporter* reporter) {
         static const int kRepeatCnt = 10;
 
@@ -4259,6 +4263,10 @@
 
 class PathTest_Private {
 public:
+    static size_t GetFreeSpace(const SkPath& path) {
+        return PathRefTest_Private::GetFreeSpace(*path.fPathRef);
+    }
+
     static void TestPathTo(skiatest::Reporter* reporter) {
         SkPath p, q;
         p.lineTo(4, 4);
@@ -5129,7 +5137,7 @@
         REPORTER_ASSERT(reporter, shared_path == copy);
 
 #ifdef SK_DEBUG
-        size_t before = unique_path.debugging_private_getFreeSpace();
+        size_t before = PathTest_Private::GetFreeSpace(unique_path);
 #endif
         unique_path.shrinkToFit();
         shared_path.shrinkToFit();
@@ -5137,11 +5145,11 @@
         REPORTER_ASSERT(reporter, shared_path == copy);
 
 #ifdef SK_DEBUG
-        size_t after = unique_path.debugging_private_getFreeSpace();
+        size_t after = PathTest_Private::GetFreeSpace(unique_path);
         REPORTER_ASSERT(reporter, before >= after);
         max_free = std::max(max_free, before - after);
 
-        size_t after2 = unique_path.debugging_private_getFreeSpace();
+        size_t after2 = PathTest_Private::GetFreeSpace(unique_path);
         REPORTER_ASSERT(reporter, after == after2);
 #endif
     }