commit 10d0327c16bb748d6f73eb37dd2341c61e47ca8c
author reed <reed@google.com> Wed Oct 01 09:24:12 2014 -0700
committer Commit bot <commit-bot@chromium.org> Wed Oct 01 09:24:12 2014 -0700
tree ec15cd6630c1af4b7f4d6c3013b3945e64afa247
parent 68cd2aa797f707a9847f8eba0758787cafd43e43

add SkRect::joinNonEmptyArg for faster unioning

BUG=skia:

Review URL: https://codereview.chromium.org/619853005

include/core/SkRect.h

diff --git a/include/core/SkRect.h b/include/core/SkRect.h
index c8fc7c6..d249aee 100644
--- a/include/core/SkRect.h
+++ b/include/core/SkRect.h
@@ -702,8 +702,19 @@
     void join(const SkRect& r) {
         this->join(r.fLeft, r.fTop, r.fRight, r.fBottom);
     }
-    // alias for join()
-    void growToInclude(const SkRect& r) { this->join(r); }
+
+    void joinNonEmptyArg(const SkRect& r) {
+        SkASSERT(!r.isEmpty());
+        // if we are empty, just assign
+        if (fLeft >= fRight || fTop >= fBottom) {
+            *this = r;
+        } else {
+            fLeft   = SkMinScalar(fLeft, r.left());
+            fTop    = SkMinScalar(fTop, r.top());
+            fRight  = SkMaxScalar(fRight, r.right());
+            fBottom = SkMaxScalar(fBottom, r.bottom());
+        }
+    }
 
     /**
      *  Grow the rect to include the specified (x,y). After this call, the

src/gpu/GrBitmapTextContext.cpp

diff --git a/src/gpu/GrBitmapTextContext.cpp b/src/gpu/GrBitmapTextContext.cpp
index 422a7e0..c9cdf2c 100755
--- a/src/gpu/GrBitmapTextContext.cpp
+++ b/src/gpu/GrBitmapTextContext.cpp
@@ -575,7 +575,7 @@
     r.fRight = SkFixedToFloat(vx + width);
     r.fBottom = SkFixedToFloat(vy + height);
 
-    fVertexBounds.growToInclude(r);
+    fVertexBounds.joinNonEmptyArg(r);
 
     size_t vertSize = useColorVerts ? (2 * sizeof(SkPoint) + sizeof(GrColor)) :
                                       (2 * sizeof(SkPoint));

src/gpu/GrDistanceFieldTextContext.cpp

diff --git a/src/gpu/GrDistanceFieldTextContext.cpp b/src/gpu/GrDistanceFieldTextContext.cpp
index 07e9a2e..b565dd6 100755
--- a/src/gpu/GrDistanceFieldTextContext.cpp
+++ b/src/gpu/GrDistanceFieldTextContext.cpp
@@ -411,7 +411,7 @@
     r.fRight = sx + width;
     r.fBottom = sy + height;
 
-    fVertexBounds.growToInclude(r);
+    fVertexBounds.joinNonEmptyArg(r);
 
     size_t vertSize = fUseLCDText ? (2 * sizeof(SkPoint))
                                   : (2 * sizeof(SkPoint) + sizeof(GrColor));