commit 134ad3e5b0979c2fd60dc01717022cac57fd76ec
author herb <herb@google.com> Wed Feb 17 11:57:24 2016 -0800
committer Commit bot <commit-bot@chromium.org> Wed Feb 17 11:57:24 2016 -0800
tree af84285eb7407732f4f8c14e5b01c62fcdb8e68e
parent cecbbe2fa91d116d5c724ed9a1be9b6d82593e13

Fix name creation scope.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1701413003

Review URL: https://codereview.chromium.org/1701413003

bench/SkLinearBitmapPipelineBench.cpp

diff --git a/bench/SkLinearBitmapPipelineBench.cpp b/bench/SkLinearBitmapPipelineBench.cpp
index 9d2e48c..ea00638 100644
--- a/bench/SkLinearBitmapPipelineBench.cpp
+++ b/bench/SkLinearBitmapPipelineBench.cpp
@@ -47,31 +47,31 @@
     }
 
     const char* onGetName() override {
-        SkString name {"SkBitmapFP"};
+        fName.set("SkBitmapFP");
         if (fM.getType() & SkMatrix::kPerspective_Mask) {
-            name.append("Perspective");
+            fName.append("Perspective");
         } else if (fM.getType() & SkMatrix::kAffine_Mask) {
-            name.append("Affine");
+            fName.append("Affine");
         } else if (fM.getType() & SkMatrix::kScale_Mask) {
-            name.append("Scale");
+            fName.append("Scale");
         } else if (fM.getType() & SkMatrix::kTranslate_Mask) {
-            name.append("Translate");
+            fName.append("Translate");
         } else {
-            name.append("Identity");
+            fName.append("Identity");
         }
 
-        name.append(tileName("X", fXTile));
-        name.append(tileName("Y", fYTile));
+        fName.append(tileName("X", fXTile));
+        fName.append(tileName("Y", fYTile));
 
         if (fUseBilerp) {
-            name.append("Filter");
+            fName.append("Filter");
         } else {
-            name.append("Nearest");
+            fName.append("Nearest");
         }
 
-        name.appendf("%s", BaseName().c_str());
+        fName.appendf("%s", BaseName().c_str());
 
-        return name.c_str();
+        return fName.c_str();
     }
 
     void onPreDraw(SkCanvas*) override {
@@ -96,6 +96,7 @@
 
     virtual SkString BaseName() = 0;
 
+    SkString fName;
     SkISize fSrcSize;
     SkColorProfileType fColorProfile;
     SkMatrix fM;
@@ -116,6 +117,7 @@
         SkShader::TileMode xTile,
         SkShader::TileMode yTile)
             : CommonBitmapFPBenchmark(srcSize, colorProfile, m, useBilerp, xTile, yTile) { }
+
     SkString BaseName() override {
         SkString name;
         if (fInfo.isSRGB()) {
@@ -154,6 +156,7 @@
         SkShader::TileMode xTile,
         SkShader::TileMode yTile)
             : CommonBitmapFPBenchmark(srcSize, colorProfile, m, useBilerp, xTile, yTile) { }
+
     SkString BaseName() override {
         SkString name{"Orig"};
         return name;
@@ -172,7 +175,6 @@
             fPaint.setFilterQuality(SkFilterQuality::kNone_SkFilterQuality);
         }
         fPaint.setShader(shader)->unref();
-
     }
 
     void onPostDraw(SkCanvas*) override {