commit 3d8c33cd835054affab43ac8c96f349147d2e776
author halcanary <halcanary@google.com> Thu Oct 01 11:06:22 2015 -0700
committer Commit bot <commit-bot@chromium.org> Thu Oct 01 11:06:22 2015 -0700
tree 4f8df5c8653ebf5c226543cf5d859cdf842de95c
parent f174e928732d69a0884d07168862265a97da10d8

SkPDF: ASAN fix: don't double ref new SkPDFBitmap objects

TBR=robertphillips@google.com,tomhudson@google.com,

Review URL: https://codereview.chromium.org/1381073005

src/pdf/SkPDFDevice.cpp

diff --git a/src/pdf/SkPDFDevice.cpp b/src/pdf/SkPDFDevice.cpp
index 8d53b99..b6500c1 100644
--- a/src/pdf/SkPDFDevice.cpp
+++ b/src/pdf/SkPDFDevice.cpp
@@ -2282,7 +2282,7 @@
         // TODO(halcanary): de-dupe this by caching filtered images.
         // (maybe in the resource cache?)
     }
-    SkAutoTUnref<SkPDFObject> pdfimage(fCanon->findPDFBitmap(image));
+    SkAutoTUnref<SkPDFObject> pdfimage(SkSafeRef(fCanon->findPDFBitmap(image)));
     if (!pdfimage) {
         pdfimage.reset(SkPDFCreateBitmapObject(image));
         if (!pdfimage) {
@@ -2290,6 +2290,6 @@
         }
         fCanon->addPDFBitmap(image->uniqueID(), pdfimage);
     }
-    SkPDFUtils::DrawFormXObject(this->addXObjectResource(SkRef(pdfimage.get())),
+    SkPDFUtils::DrawFormXObject(this->addXObjectResource(pdfimage.get()),
                                 &content.entry()->fContent);
 }