commit | 4d9ff62fa21326003cf5394cd1d16f4b4633102a | [log] [tgz] |
---|---|---|
author | mtklein <mtklein@chromium.org> | Fri Apr 29 14:45:36 2016 -0700 |
committer | Commit bot <commit-bot@chromium.org> | Fri Apr 29 14:45:36 2016 -0700 |
tree | 4747bd2d2b17d96ed17bf27066d0c7b024ffe1a7 | |
parent | 221196dac99dcbb402fd79c651e2a96fd5016dba [diff] [blame] |
Remove SkWriter32::contiguousArray(). This method requires SkWriter32 have a contiguous array. It does, and I plan to keep it that way (last time we checked it's faster), but this turns that feature back into an implementation detail. This feature is only used by another unused feature, deep copies of ops arrays in SkPictureData. Kill that, kill this. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1932223003 Depends on https://codereview.chromium.org/1936563002/ Only deleting API TBR=reed@google.com Review-Url: https://codereview.chromium.org/1932223003
diff --git a/src/core/SkPictureRecord.h b/src/core/SkPictureRecord.h index 59bd92d..8504c00 100644 --- a/src/core/SkPictureRecord.h +++ b/src/core/SkPictureRecord.h
@@ -47,17 +47,12 @@ return fImageRefs; } - sk_sp<SkData> opData(bool deepCopy) const { + sk_sp<SkData> opData() const { this->validate(fWriter.bytesWritten(), 0); if (fWriter.bytesWritten() == 0) { return SkData::MakeEmpty(); } - - if (deepCopy) { - return SkData::MakeWithCopy(fWriter.contiguousArray(), fWriter.bytesWritten()); - } - return fWriter.snapshotAsData(); }