fuzzer fixes
Fix path bugs exposed by the path fuzzer.
Changes to existing gm and samplecode files defer their calls to construct
SkPath objects until the first draw instead of at test initialization.
Add an experimental call to SkPath to validate the internal SkPathRef.
Fix SkPath::addPoly to set the last moveto after adding a close verb.
Fix stroke to handle failures when computing the unit normal.
Add a unit test for the unit normal failure.
R=reed@google.com
Review URL: https://codereview.chromium.org/953383002
diff --git a/tests/StrokeTest.cpp b/tests/StrokeTest.cpp
index 15220c4..80ca317 100644
--- a/tests/StrokeTest.cpp
+++ b/tests/StrokeTest.cpp
@@ -18,6 +18,35 @@
SkScalarNearlyEqual(a.bottom(), b.bottom());
}
+static void test_strokecubic(skiatest::Reporter* reporter) {
+ uint32_t hexCubicVals[] = {
+ 0x424c1086, 0x44bcf0cb, // fX=51.0161362 fY=1511.52478
+ 0x424c107c, 0x44bcf0cb, // fX=51.0160980 fY=1511.52478
+ 0x424c10c2, 0x44bcf0cb, // fX=51.0163651 fY=1511.52478
+ 0x424c1119, 0x44bcf0ca, // fX=51.0166969 fY=1511.52466
+ };
+ SkPoint cubicVals[] = {
+ {51.0161362f, 1511.52478f },
+ {51.0160980f, 1511.52478f },
+ {51.0163651f, 1511.52478f },
+ {51.0166969f, 1511.52466f },
+ };
+ SkPaint paint;
+
+ paint.setStyle(SkPaint::kStroke_Style);
+ paint.setStrokeWidth(0.394537568f);
+ SkPath path, fillPath;
+ path.moveTo(cubicVals[0]);
+ path.cubicTo(cubicVals[1], cubicVals[2], cubicVals[3]);
+ paint.getFillPath(path, &fillPath);
+ path.reset();
+ path.moveTo(SkBits2Float(hexCubicVals[0]), SkBits2Float(hexCubicVals[1]));
+ path.cubicTo(SkBits2Float(hexCubicVals[2]), SkBits2Float(hexCubicVals[3]),
+ SkBits2Float(hexCubicVals[4]), SkBits2Float(hexCubicVals[5]),
+ SkBits2Float(hexCubicVals[6]), SkBits2Float(hexCubicVals[7]));
+ paint.getFillPath(path, &fillPath);
+}
+
static void test_strokerect(skiatest::Reporter* reporter) {
const SkScalar width = SkIntToScalar(10);
SkPaint paint;
@@ -56,5 +85,6 @@
}
DEF_TEST(Stroke, reporter) {
+ test_strokecubic(reporter);
test_strokerect(reporter);
}