commit 9f772a44fe90e19841fd86ab29f259f8791413f4
author Brian Osman <brianosman@google.com> Mon Jul 10 13:03:50 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Jul 10 17:27:29 2017 +0000
tree ec2c50cf0921694d764726e7e4a352c26b2f3043
parent bca23b8634e54b779591e72a313f24bc806851d9

Skip GLPrograms test on D3D9 ANGLE to avoid NaN literals bug

Bug: skia:6842
Change-Id: I0bf58f2a00de66cae161561fc87e7adaac651e4f
Reviewed-on: https://skia-review.googlesource.com/22064
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

tests/GLProgramsTest.cpp

diff --git a/tests/GLProgramsTest.cpp b/tests/GLProgramsTest.cpp
index a5c5f66..1786764 100644
--- a/tests/GLProgramsTest.cpp
+++ b/tests/GLProgramsTest.cpp
@@ -283,7 +283,7 @@
     // dummy scissor state
     GrScissorState scissor;
 
-    SkRandom random(1);
+    SkRandom random;
     static const int NUM_TESTS = 1024;
     for (int t = 0; t < NUM_TESTS; t++) {
         // setup random render target(can fail)
@@ -389,6 +389,13 @@
     if (maxLevels == 0) {
         return;
     }
+
+    // Disable this test on ANGLE D3D9 configurations. We keep hitting a D3D compiler bug.
+    // See skbug.com/6842 and anglebug.com/2098
+    if (sk_gpu_test::GrContextFactory::kANGLE_D3D9_ES2_ContextType == ctxInfo.type()) {
+        return;
+    }
+
     REPORTER_ASSERT(reporter, GrDrawingManager::ProgramUnitTest(ctxInfo.grContext(), maxStages,
                                                                 maxLevels));
 }