commit a427cc4d6b025b38b5bacd97f98325f9770e1769
author fmalita <fmalita@chromium.org> Mon Jul 18 10:56:43 2016 -0700
committer Commit bot <commit-bot@chromium.org> Mon Jul 18 10:56:43 2016 -0700
tree 77e488022315350380d766324d4624d4bc0e4acc
parent 54f30c13fc0a5d89797fc9be5f0fb1050d96b6f4

Remove SkDOM::build(const char doc[], size_t len)

This flavor is unused, and we have the more general SkStream API.

R=stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154733003

Review-Url: https://codereview.chromium.org/2154733003

include/xml/SkDOM.h

diff --git a/include/xml/SkDOM.h b/include/xml/SkDOM.h
index 2a6ccc4..10ca3e7 100644
--- a/include/xml/SkDOM.h
+++ b/include/xml/SkDOM.h
@@ -32,7 +32,6 @@
 
     /** Returns null on failure
     */
-    const Node* build(const char doc[], size_t len);
     const Node* build(SkStream&);
     const Node* copy(const SkDOM& dom, const Node* node);
 

src/xml/SkDOM.cpp

diff --git a/src/xml/SkDOM.cpp b/src/xml/SkDOM.cpp
index 78cf6f0..38ba669 100644
--- a/src/xml/SkDOM.cpp
+++ b/src/xml/SkDOM.cpp
@@ -323,11 +323,6 @@
     return fRoot;
 }
 
-const SkDOM::Node* SkDOM::build(const char doc[], size_t len) {
-    SkMemoryStream docStream(doc, len);
-    return this->build(docStream);
-}
-
 ///////////////////////////////////////////////////////////////////////////
 
 static void walk_dom(const SkDOM& dom, const SkDOM::Node* node, SkXMLParser* parser)

tests/SkDOMTest.cpp

diff --git a/tests/SkDOMTest.cpp b/tests/SkDOMTest.cpp
index 34bd8dd..a7fbda7 100644
--- a/tests/SkDOMTest.cpp
+++ b/tests/SkDOMTest.cpp
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkStream.h"
 #include "Test.h"
 
 #if defined(SK_XML)
@@ -24,10 +25,12 @@
         "</root>"
         ;
 
+    SkMemoryStream docStream(gDoc, sizeof(gDoc) - 1);
+
     SkDOM   dom;
     REPORTER_ASSERT(r, !dom.getRootNode());
 
-    const SkDOM::Node* root = dom.build(gDoc, sizeof(gDoc) - 1);
+    const SkDOM::Node* root = dom.build(docStream);
     REPORTER_ASSERT(r, root && dom.getRootNode() == root);
 
     const char* v = dom.findAttr(root, "a");