skipRect should only work for lines (not quads or cubics)
The added unit test shows that we'll trigger SkASSERT failure if we
forgot to check that the edges are lines (instead of quads or cubics).
Similar to skia:7015, this bug is not triggered in our production
because we don't use DAA for convex paths by default. The skipRect is
an optimization just for convex paths.
Bug: skia:7051
Change-Id: Id87ce2d452ede0db9a48425541f473af19ee0572
Reviewed-on: https://skia-review.googlesource.com/48045
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp
index 8c629d9..4fb559b 100644
--- a/tests/PathTest.cpp
+++ b/tests/PathTest.cpp
@@ -4482,6 +4482,16 @@
test_draw_AA_path(500, 500, path);
}
+static void test_skbug_7051() {
+ SkPath path;
+ path.moveTo(10, 10);
+ path.cubicTo(10, 20, 10, 30, 30, 30);
+ path.lineTo(50, 20);
+ path.lineTo(50, 10);
+ path.close();
+ test_draw_AA_path(100, 100, path);
+}
+
#endif
static void test_interp(skiatest::Reporter* reporter) {
@@ -4559,6 +4569,7 @@
#if !defined(SK_SUPPORT_LEGACY_DELTA_AA)
test_skbug_6947();
test_skbug_7015();
+ test_skbug_7051();
#endif
SkSize::Make(3, 4);