flags and hacks to get MSAN bot going
This disables a few tests in DM:
- one BlurLargeImage GM maybe is really broken
- FontMgrAndroidParser uses libexpat, which I've not (yet?) built from source,
so MSAN can't see into it.
This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to SkCodec, and skips .wbmps, .pngs, and .bmps. We're only seeing issues in colortables for .png and .bmp.
I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1673663002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
TBR=msarett@google.com
Review URL: https://codereview.chromium.org/1673663002
diff --git a/tools/dm_flags.json b/tools/dm_flags.json
index 4e1c612..834c177 100644
--- a/tools/dm_flags.json
+++ b/tools/dm_flags.json
@@ -1739,6 +1739,328 @@
"_",
"image-cacherator-from-ctable"
],
+ "Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN": [
+ "--pre_log",
+ "--matrix",
+ "0",
+ "1",
+ "1",
+ "0",
+ "--config",
+ "565",
+ "8888",
+ "gpu",
+ "upright-matrix-8888",
+ "upright-matrix-gpu",
+ "sp-8888",
+ "twice-8888",
+ "2ndpic-8888",
+ "remote-8888",
+ "remote_cache-8888",
+ "msaa16",
+ "pdf",
+ "pdf_poppler",
+ "serialize-8888",
+ "tiles_rt-8888",
+ "pic-8888",
+ "--src",
+ "tests",
+ "gm",
+ "image",
+ "--blacklist",
+ "_",
+ "image",
+ "_",
+ "interlaced1.png",
+ "_",
+ "image",
+ "_",
+ "interlaced2.png",
+ "_",
+ "image",
+ "_",
+ "interlaced3.png",
+ "serialize-8888",
+ "gm",
+ "_",
+ "not_native32_bitmap_config",
+ "serialize-8888",
+ "gm",
+ "_",
+ "bleed_image",
+ "serialize-8888",
+ "gm",
+ "_",
+ "bleed_alpha_image",
+ "serialize-8888",
+ "gm",
+ "_",
+ "bleed_alpha_image_shader",
+ "serialize-8888",
+ "gm",
+ "_",
+ "blend",
+ "serialize-8888",
+ "gm",
+ "_",
+ "c_gms",
+ "serialize-8888",
+ "gm",
+ "_",
+ "colortype",
+ "serialize-8888",
+ "gm",
+ "_",
+ "colortype_xfermodes",
+ "serialize-8888",
+ "gm",
+ "_",
+ "colorwheelnative",
+ "serialize-8888",
+ "gm",
+ "_",
+ "drawfilter",
+ "serialize-8888",
+ "gm",
+ "_",
+ "fontmgr_bounds_0.75_0",
+ "serialize-8888",
+ "gm",
+ "_",
+ "fontmgr_bounds_1_-0.25",
+ "serialize-8888",
+ "gm",
+ "_",
+ "fontmgr_bounds",
+ "serialize-8888",
+ "gm",
+ "_",
+ "fontmgr_match",
+ "serialize-8888",
+ "gm",
+ "_",
+ "fontmgr_iter",
+ "serialize-8888",
+ "gm",
+ "_",
+ "lightingshader",
+ "serialize-8888",
+ "gm",
+ "_",
+ "localmatriximagefilter",
+ "serialize-8888",
+ "gm",
+ "_",
+ "path_stroke_with_zero_length",
+ "serialize-8888",
+ "gm",
+ "_",
+ "textblobgeometrychange",
+ "serialize-8888",
+ "gm",
+ "_",
+ "verylargebitmap",
+ "serialize-8888",
+ "gm",
+ "_",
+ "verylarge_picture_image",
+ "sp-8888",
+ "gm",
+ "_",
+ "blend",
+ "pic-8888",
+ "gm",
+ "_",
+ "blend",
+ "2ndpic-8888",
+ "gm",
+ "_",
+ "blend",
+ "sp-8888",
+ "gm",
+ "_",
+ "drawfilter",
+ "pic-8888",
+ "gm",
+ "_",
+ "drawfilter",
+ "2ndpic-8888",
+ "gm",
+ "_",
+ "drawfilter",
+ "sp-8888",
+ "gm",
+ "_",
+ "path_stroke_with_zero_length",
+ "pic-8888",
+ "gm",
+ "_",
+ "path_stroke_with_zero_length",
+ "2ndpic-8888",
+ "gm",
+ "_",
+ "path_stroke_with_zero_length",
+ "sp-8888",
+ "gm",
+ "_",
+ "textblobgeometrychange",
+ "pic-8888",
+ "gm",
+ "_",
+ "textblobgeometrychange",
+ "2ndpic-8888",
+ "gm",
+ "_",
+ "textblobgeometrychange",
+ "sp-8888",
+ "gm",
+ "_",
+ "patch_primitive",
+ "sp-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-picture",
+ "pic-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-picture",
+ "2ndpic-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-picture",
+ "serialize-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-picture",
+ "sp-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-raster",
+ "pic-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-raster",
+ "2ndpic-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-raster",
+ "serialize-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-raster",
+ "sp-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-ctable",
+ "pic-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-ctable",
+ "2ndpic-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-ctable",
+ "serialize-8888",
+ "gm",
+ "_",
+ "image-cacherator-from-ctable",
+ "_",
+ "image",
+ "_",
+ ".arw",
+ "_",
+ "image",
+ "_",
+ ".cr2",
+ "_",
+ "image",
+ "_",
+ ".dng",
+ "_",
+ "image",
+ "_",
+ ".nef",
+ "_",
+ "image",
+ "_",
+ ".nrw",
+ "_",
+ "image",
+ "_",
+ ".orf",
+ "_",
+ "image",
+ "_",
+ ".raf",
+ "_",
+ "image",
+ "_",
+ ".rw2",
+ "_",
+ "image",
+ "_",
+ ".pef",
+ "_",
+ "image",
+ "_",
+ ".srw",
+ "_",
+ "image",
+ "_",
+ ".ARW",
+ "_",
+ "image",
+ "_",
+ ".CR2",
+ "_",
+ "image",
+ "_",
+ ".DNG",
+ "_",
+ "image",
+ "_",
+ ".NEF",
+ "_",
+ "image",
+ "_",
+ ".NRW",
+ "_",
+ "image",
+ "_",
+ ".ORF",
+ "_",
+ "image",
+ "_",
+ ".RAF",
+ "_",
+ "image",
+ "_",
+ ".RW2",
+ "_",
+ "image",
+ "_",
+ ".PEF",
+ "_",
+ "image",
+ "_",
+ ".SRW",
+ "_",
+ "image",
+ "_",
+ ".wbmp",
+ "_",
+ "image",
+ "_",
+ ".png",
+ "_",
+ "image",
+ "_",
+ ".bmp",
+ "--match",
+ "~Codec",
+ "~BlurLargeImage",
+ "~FontMgrAndroidParser"
+ ],
"Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN": [
"--pre_log",
"--matrix",
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index beb3085..ab8a37e 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -166,10 +166,6 @@
for raw_ext in r:
blacklist.extend(('_ image _ .%s' % raw_ext).split(' '))
- if blacklist:
- args.append('--blacklist')
- args.extend(blacklist)
-
match = []
if 'Valgrind' in bot: # skia:3021
match.append('~Threaded')
@@ -193,6 +189,26 @@
if 'ANGLE' in bot and 'Debug' in bot:
match.append('~GLPrograms') # skia:4717
+ # Hacking around trying to get the MSAN bot green.
+ if 'MSAN' in bot:
+ # S32A_Opaque_BlitRow32_SSE4's sk_msan_assert_initialized failing on .SRW.
+ r = ["arw", "cr2", "dng", "nef", "nrw", "orf", "raf", "rw2", "pef", "srw",
+ "ARW", "CR2", "DNG", "NEF", "NRW", "ORF", "RAF", "RW2", "PEF", "SRW"]
+ for raw_ext in r:
+ blacklist.extend(('_ image _ .%s' % raw_ext).split(' '))
+
+ blacklist.extend(('_ image _ .wbmp').split(' ')) # skia:4900
+ blacklist.extend(('_ image _ .png').split(' ')) # I8 .png color tables
+ blacklist.extend(('_ image _ .bmp').split(' ')) # I8 .bmp color tables
+
+ match.append('~Codec') # Uninitialzied memory used in PIEX.
+ match.append('~BlurLargeImage') # Bug in the GM?
+ match.append('~FontMgrAndroidParser') # expat currently uninstrumented.
+
+ if blacklist:
+ args.append('--blacklist')
+ args.extend(blacklist)
+
if match:
args.append('--match')
args.extend(match)
@@ -213,6 +229,7 @@
'Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release',
'Test-Android-GCC-NexusPlayer-CPU-SSSE3-x86-Release',
'Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind',
+ 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN',
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN',
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind',
'Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE',