commit e8e1075a9e2f2397716c28500bc2e09903c53736
author Michael Ludwig <michaelludwig@google.com> Mon Oct 01 12:42:53 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Oct 01 18:30:06 2018 +0000
tree 0cce7ced159d4015f2f6d348eeb2d109a31075d5
parent 105ca96803e477a9d5616db1628cbb3979cd1d7d

Add input/output image logging to processor tests

Moves SkBitmap to base64 uri code into test utils

Bug: skia:
Change-Id: I4f92761fd2e643c38ed00a200b1cb62778a85948
Reviewed-on: https://skia-review.googlesource.com/158340
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>

tests/ProcessorTest.cpp

diff --git a/tests/ProcessorTest.cpp b/tests/ProcessorTest.cpp
index 6e241a2..fee40ab 100644
--- a/tests/ProcessorTest.cpp
+++ b/tests/ProcessorTest.cpp
@@ -21,6 +21,7 @@
 #include "glsl/GrGLSLFragmentShaderBuilder.h"
 #include "ops/GrMeshDrawOp.h"
 #include "ops/GrRectOpFactory.h"
+#include "TestUtils.h"
 
 #include <random>
 
@@ -310,6 +311,21 @@
                                              SkBudgeted::kYes, SkBackingFit::kExact);
 }
 
+bool log_surface_context(sk_sp<GrSurfaceContext> src, SkString* dst) {
+    SkImageInfo ii = SkImageInfo::Make(src->width(), src->height(), kRGBA_8888_SkColorType,
+                                       kPremul_SkAlphaType);
+    SkBitmap bm;
+    SkAssertResult(bm.tryAllocPixels(ii));
+    SkAssertResult(src->readPixels(ii, bm.getPixels(), bm.rowBytes(), 0, 0));
+
+    return bitmap_to_base64_data_uri(bm, dst);
+}
+
+bool log_surface_proxy(GrContext* context, sk_sp<GrSurfaceProxy> src, SkString* dst) {
+    sk_sp<GrSurfaceContext> sContext(context->contextPriv().makeWrappedSurfaceContext(src));
+    return log_surface_context(sContext, dst);
+}
+
 DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(ProcessorOptimizationValidationTest, reporter, ctxInfo) {
     GrContext* context = ctxInfo.grContext();
     GrProxyProvider* proxyProvider = context->contextPriv().proxyProvider();
@@ -340,6 +356,9 @@
     auto inputTexture = make_input_texture(proxyProvider, kRenderSize, kRenderSize);
 
     std::unique_ptr<GrColor[]> readData(new GrColor[kRenderSize * kRenderSize]);
+    // Encoded images are very verbose and this tests many potential images, so only export the
+    // first failure (subsequent failures have a reasonable chance of being related).
+    bool loggedFirstFailure = false;
     // Because processor factories configure themselves in random ways, this is not exhaustive.
     for (int i = 0; i < FPFactory::Count(); ++i) {
         int timesToInvokeFactory = 5;
@@ -439,8 +458,23 @@
                         passing = false;
                     }
                     if (!passing) {
-                        ERRORF(reporter, "Seed: 0x%08x, Processor details: %s", seed,
-                               clone->dumpInfo().c_str());
+                        if (loggedFirstFailure) {
+                            // Do not export images
+                            ERRORF(reporter, "Seed: 0x%08x, Processor details: %s", seed,
+                                   clone->dumpInfo().c_str());
+                        } else {
+                            SkString input;
+                            log_surface_proxy(context, inputTexture, &input);
+                            SkString output;
+                            log_surface_context(rtc, &output);
+                            ERRORF(reporter, "Seed: 0x%08x, Processor details: %s\n\n"
+                                   "===========================================================\n\n"
+                                   "Input image: %s\n\n"
+                                   "===========================================================\n\n"
+                                   "Output image: %s\n", seed, clone->dumpInfo().c_str(),
+                                   input.c_str(), output.c_str());
+                            loggedFirstFailure = true;
+                        }
                     }
                 }
             }