commit fdf31035a9639c2d377bdf2ddb404d269f8ca42a
author Mike Klein <mtklein@chromium.org> Tue May 09 14:57:58 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue May 09 20:04:44 2017 +0000
tree 1243f154d371f25971833443e24c2136728c3340
parent b8fbab2a1c79764e490e65ebc80288cdc0494237

void SkColorFilter::onAppendStages(...)

SkColorFilter::onAppendStages() can't actually fail today.
Let's enforce that.  This means the fallback is now used
only for color filters that have not implemented onAppendStages().

Change-Id: Ica3939685694f6186727766b54914b9ba05ca68c
Reviewed-on: https://skia-review.googlesource.com/16231
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

src/effects/SkTableColorFilter.cpp

diff --git a/src/effects/SkTableColorFilter.cpp b/src/effects/SkTableColorFilter.cpp
index d9ce98a..b5156ae 100644
--- a/src/effects/SkTableColorFilter.cpp
+++ b/src/effects/SkTableColorFilter.cpp
@@ -103,7 +103,7 @@
         kB_Flag = 1 << 3,
     };
 
-    bool onAppendStages(SkRasterPipeline* p, SkColorSpace*, SkArenaAlloc* alloc,
+    void onAppendStages(SkRasterPipeline* p, SkColorSpace*, SkArenaAlloc* alloc,
                         bool shaderIsOpaque) const override {
         const uint8_t *r = gIdentityTable,
                       *g = gIdentityTable,
@@ -126,7 +126,6 @@
         if (!definitelyOpaque) {
             p->append(SkRasterPipeline::premul);
         }
-        return true;
     }
 
 protected: