halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2015 Google Inc. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
| 7 | |
| 8 | #include "Resources.h" |
| 9 | #include "SkBitmap.h" |
| 10 | #include "SkCodec.h" |
| 11 | #include "SkMD5.h" |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 12 | #include "SkRandom.h" |
msarett | b32758a | 2015-08-18 13:22:46 -0700 | [diff] [blame] | 13 | #include "SkScaledCodec.h" |
scroggo | eb602a5 | 2015-07-09 08:16:03 -0700 | [diff] [blame] | 14 | #include "SkScanlineDecoder.h" |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 15 | #include "Test.h" |
| 16 | |
| 17 | static SkStreamAsset* resource(const char path[]) { |
| 18 | SkString fullPath = GetResourcePath(path); |
| 19 | return SkStream::NewFromFile(fullPath.c_str()); |
| 20 | } |
| 21 | |
| 22 | static void md5(const SkBitmap& bm, SkMD5::Digest* digest) { |
| 23 | SkAutoLockPixels autoLockPixels(bm); |
| 24 | SkASSERT(bm.getPixels()); |
| 25 | SkMD5 md5; |
| 26 | size_t rowLen = bm.info().bytesPerPixel() * bm.width(); |
| 27 | for (int y = 0; y < bm.height(); ++y) { |
| 28 | md5.update(static_cast<uint8_t*>(bm.getAddr(0, y)), rowLen); |
| 29 | } |
| 30 | md5.finish(*digest); |
| 31 | } |
| 32 | |
scroggo | 9b2cdbf | 2015-07-10 12:07:02 -0700 | [diff] [blame] | 33 | /** |
| 34 | * Compute the digest for bm and compare it to a known good digest. |
| 35 | * @param r Reporter to assert that bm's digest matches goodDigest. |
| 36 | * @param goodDigest The known good digest to compare to. |
| 37 | * @param bm The bitmap to test. |
| 38 | */ |
| 39 | static void compare_to_good_digest(skiatest::Reporter* r, const SkMD5::Digest& goodDigest, |
| 40 | const SkBitmap& bm) { |
| 41 | SkMD5::Digest digest; |
| 42 | md5(bm, &digest); |
| 43 | REPORTER_ASSERT(r, digest == goodDigest); |
| 44 | } |
| 45 | |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 46 | /** |
| 47 | * Test decoding an SkCodec to a particular SkImageInfo. |
| 48 | * |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 49 | * Calling getPixels(info) should return expectedResult, and if goodDigest is non nullptr, |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 50 | * the resulting decode should match. |
| 51 | */ |
| 52 | static void test_info(skiatest::Reporter* r, SkCodec* codec, const SkImageInfo& info, |
| 53 | SkCodec::Result expectedResult, const SkMD5::Digest* goodDigest) { |
| 54 | SkBitmap bm; |
| 55 | bm.allocPixels(info); |
| 56 | SkAutoLockPixels autoLockPixels(bm); |
| 57 | |
| 58 | SkCodec::Result result = codec->getPixels(info, bm.getPixels(), bm.rowBytes()); |
| 59 | REPORTER_ASSERT(r, result == expectedResult); |
| 60 | |
| 61 | if (goodDigest) { |
| 62 | compare_to_good_digest(r, *goodDigest, bm); |
| 63 | } |
| 64 | } |
| 65 | |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 66 | SkIRect generate_random_subset(SkRandom* rand, int w, int h) { |
| 67 | SkIRect rect; |
| 68 | do { |
| 69 | rect.fLeft = rand->nextRangeU(0, w); |
| 70 | rect.fTop = rand->nextRangeU(0, h); |
| 71 | rect.fRight = rand->nextRangeU(0, w); |
| 72 | rect.fBottom = rand->nextRangeU(0, h); |
| 73 | rect.sort(); |
| 74 | } while (rect.isEmpty()); |
| 75 | return rect; |
| 76 | } |
| 77 | |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 78 | static void check(skiatest::Reporter* r, |
| 79 | const char path[], |
| 80 | SkISize size, |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 81 | bool supportsScanlineDecoding, |
scroggo | cc2feb1 | 2015-08-14 08:32:46 -0700 | [diff] [blame] | 82 | bool supportsSubsetDecoding, |
| 83 | bool supports565 = true) { |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 84 | SkAutoTDelete<SkStream> stream(resource(path)); |
| 85 | if (!stream) { |
| 86 | SkDebugf("Missing resource '%s'\n", path); |
| 87 | return; |
| 88 | } |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 89 | SkAutoTDelete<SkCodec> codec(SkCodec::NewFromStream(stream.detach())); |
| 90 | if (!codec) { |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 91 | ERRORF(r, "Unable to decode '%s'", path); |
| 92 | return; |
| 93 | } |
msarett | 438b2ad | 2015-04-09 12:43:10 -0700 | [diff] [blame] | 94 | |
| 95 | // This test is used primarily to verify rewinding works properly. Using kN32 allows |
| 96 | // us to test this without the added overhead of creating different bitmaps depending |
| 97 | // on the color type (ex: building a color table for kIndex8). DM is where we test |
| 98 | // decodes to all possible destination color types. |
| 99 | SkImageInfo info = codec->getInfo().makeColorType(kN32_SkColorType); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 100 | REPORTER_ASSERT(r, info.dimensions() == size); |
scroggo | cc2feb1 | 2015-08-14 08:32:46 -0700 | [diff] [blame] | 101 | |
| 102 | { |
| 103 | // Test decoding to 565 |
| 104 | SkImageInfo info565 = info.makeColorType(kRGB_565_SkColorType); |
| 105 | SkCodec::Result expected = (supports565 && info.alphaType() == kOpaque_SkAlphaType) ? |
| 106 | SkCodec::kSuccess : SkCodec::kInvalidConversion; |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 107 | test_info(r, codec, info565, expected, nullptr); |
scroggo | cc2feb1 | 2015-08-14 08:32:46 -0700 | [diff] [blame] | 108 | } |
| 109 | |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 110 | SkBitmap bm; |
| 111 | bm.allocPixels(info); |
| 112 | SkAutoLockPixels autoLockPixels(bm); |
scroggo | eb602a5 | 2015-07-09 08:16:03 -0700 | [diff] [blame] | 113 | SkCodec::Result result = |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 114 | codec->getPixels(info, bm.getPixels(), bm.rowBytes(), nullptr, nullptr, nullptr); |
scroggo | eb602a5 | 2015-07-09 08:16:03 -0700 | [diff] [blame] | 115 | REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 116 | |
scroggo | 9b2cdbf | 2015-07-10 12:07:02 -0700 | [diff] [blame] | 117 | SkMD5::Digest digest; |
| 118 | md5(bm, &digest); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 119 | |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 120 | // verify that re-decoding gives the same result. |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 121 | test_info(r, codec, info, SkCodec::kSuccess, &digest); |
| 122 | |
| 123 | { |
| 124 | // Check alpha type conversions |
| 125 | if (info.alphaType() == kOpaque_SkAlphaType) { |
| 126 | test_info(r, codec, info.makeAlphaType(kUnpremul_SkAlphaType), |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 127 | SkCodec::kInvalidConversion, nullptr); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 128 | test_info(r, codec, info.makeAlphaType(kPremul_SkAlphaType), |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 129 | SkCodec::kInvalidConversion, nullptr); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 130 | } else { |
| 131 | // Decoding to opaque should fail |
| 132 | test_info(r, codec, info.makeAlphaType(kOpaque_SkAlphaType), |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 133 | SkCodec::kInvalidConversion, nullptr); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 134 | SkAlphaType otherAt = info.alphaType(); |
| 135 | if (kPremul_SkAlphaType == otherAt) { |
| 136 | otherAt = kUnpremul_SkAlphaType; |
| 137 | } else { |
| 138 | otherAt = kPremul_SkAlphaType; |
| 139 | } |
| 140 | // The other non-opaque alpha type should always succeed, but not match. |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 141 | test_info(r, codec, info.makeAlphaType(otherAt), SkCodec::kSuccess, nullptr); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 142 | } |
| 143 | } |
| 144 | |
| 145 | // Scanline decoding follows. |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 146 | |
scroggo | 1c005e4 | 2015-08-04 09:24:45 -0700 | [diff] [blame] | 147 | stream.reset(resource(path)); |
| 148 | SkAutoTDelete<SkScanlineDecoder> scanlineDecoder( |
| 149 | SkScanlineDecoder::NewFromStream(stream.detach())); |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 150 | if (supportsScanlineDecoding) { |
| 151 | bm.eraseColor(SK_ColorYELLOW); |
| 152 | REPORTER_ASSERT(r, scanlineDecoder); |
msarett | c0e80c1 | 2015-07-01 06:50:35 -0700 | [diff] [blame] | 153 | |
scroggo | 1c005e4 | 2015-08-04 09:24:45 -0700 | [diff] [blame] | 154 | REPORTER_ASSERT(r, scanlineDecoder->start(info) == SkCodec::kSuccess); |
scroggo | 9b2cdbf | 2015-07-10 12:07:02 -0700 | [diff] [blame] | 155 | |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 156 | for (int y = 0; y < info.height(); y++) { |
| 157 | result = scanlineDecoder->getScanlines(bm.getAddr(0, y), 1, 0); |
scroggo | eb602a5 | 2015-07-09 08:16:03 -0700 | [diff] [blame] | 158 | REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 159 | } |
| 160 | // verify that scanline decoding gives the same result. |
scroggo | 9b2cdbf | 2015-07-10 12:07:02 -0700 | [diff] [blame] | 161 | compare_to_good_digest(r, digest, bm); |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 162 | } else { |
| 163 | REPORTER_ASSERT(r, !scanlineDecoder); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 164 | } |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 165 | |
| 166 | // The rest of this function tests decoding subsets, and will decode an arbitrary number of |
| 167 | // random subsets. |
| 168 | // Do not attempt to decode subsets of an image of only once pixel, since there is no |
| 169 | // meaningful subset. |
| 170 | if (size.width() * size.height() == 1) { |
| 171 | return; |
| 172 | } |
| 173 | |
| 174 | SkRandom rand; |
| 175 | SkIRect subset; |
| 176 | SkCodec::Options opts; |
| 177 | opts.fSubset = ⊂ |
| 178 | for (int i = 0; i < 5; i++) { |
| 179 | subset = generate_random_subset(&rand, size.width(), size.height()); |
| 180 | SkASSERT(!subset.isEmpty()); |
| 181 | const bool supported = codec->getValidSubset(&subset); |
| 182 | REPORTER_ASSERT(r, supported == supportsSubsetDecoding); |
| 183 | |
| 184 | SkImageInfo subsetInfo = info.makeWH(subset.width(), subset.height()); |
| 185 | SkBitmap bm; |
| 186 | bm.allocPixels(subsetInfo); |
| 187 | const SkCodec::Result result = codec->getPixels(bm.info(), bm.getPixels(), bm.rowBytes(), |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 188 | &opts, nullptr, nullptr); |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 189 | |
| 190 | if (supportsSubsetDecoding) { |
| 191 | REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
| 192 | // Webp is the only codec that supports subsets, and it will have modified the subset |
| 193 | // to have even left/top. |
| 194 | REPORTER_ASSERT(r, SkIsAlign2(subset.fLeft) && SkIsAlign2(subset.fTop)); |
| 195 | } else { |
| 196 | // No subsets will work. |
| 197 | REPORTER_ASSERT(r, result == SkCodec::kUnimplemented); |
| 198 | } |
| 199 | } |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 200 | } |
| 201 | |
| 202 | DEF_TEST(Codec, r) { |
| 203 | // WBMP |
msarett | 99f567e | 2015-08-05 12:58:26 -0700 | [diff] [blame] | 204 | check(r, "mandrill.wbmp", SkISize::Make(512, 512), true, false); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 205 | |
scroggo | 6f5e619 | 2015-06-18 12:53:43 -0700 | [diff] [blame] | 206 | // WEBP |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 207 | check(r, "baby_tux.webp", SkISize::Make(386, 395), false, true); |
| 208 | check(r, "color_wheel.webp", SkISize::Make(128, 128), false, true); |
| 209 | check(r, "yellow_rose.webp", SkISize::Make(400, 301), false, true); |
scroggo | 6f5e619 | 2015-06-18 12:53:43 -0700 | [diff] [blame] | 210 | |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 211 | // BMP |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 212 | check(r, "randPixels.bmp", SkISize::Make(8, 8), false, false); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 213 | |
| 214 | // ICO |
msarett | 68b204e | 2015-04-01 12:09:21 -0700 | [diff] [blame] | 215 | // These two tests examine interestingly different behavior: |
| 216 | // Decodes an embedded BMP image |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 217 | check(r, "color_wheel.ico", SkISize::Make(128, 128), false, false); |
msarett | 68b204e | 2015-04-01 12:09:21 -0700 | [diff] [blame] | 218 | // Decodes an embedded PNG image |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 219 | check(r, "google_chrome.ico", SkISize::Make(256, 256), false, false); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 220 | |
msarett | 438b2ad | 2015-04-09 12:43:10 -0700 | [diff] [blame] | 221 | // GIF |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 222 | check(r, "box.gif", SkISize::Make(200, 55), false, false); |
| 223 | check(r, "color_wheel.gif", SkISize::Make(128, 128), false, false); |
| 224 | check(r, "randPixels.gif", SkISize::Make(8, 8), false, false); |
msarett | 438b2ad | 2015-04-09 12:43:10 -0700 | [diff] [blame] | 225 | |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 226 | // JPG |
scroggo | cc2feb1 | 2015-08-14 08:32:46 -0700 | [diff] [blame] | 227 | check(r, "CMYK.jpg", SkISize::Make(642, 516), true, false, false); |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 228 | check(r, "color_wheel.jpg", SkISize::Make(128, 128), true, false); |
| 229 | check(r, "grayscale.jpg", SkISize::Make(128, 128), true, false); |
| 230 | check(r, "mandrill_512_q075.jpg", SkISize::Make(512, 512), true, false); |
| 231 | check(r, "randPixels.jpg", SkISize::Make(8, 8), true, false); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 232 | |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 233 | // PNG |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 234 | check(r, "arrow.png", SkISize::Make(187, 312), true, false); |
| 235 | check(r, "baby_tux.png", SkISize::Make(240, 246), true, false); |
| 236 | check(r, "color_wheel.png", SkISize::Make(128, 128), true, false); |
| 237 | check(r, "half-transparent-white-pixel.png", SkISize::Make(1, 1), true, false); |
| 238 | check(r, "mandrill_128.png", SkISize::Make(128, 128), true, false); |
| 239 | check(r, "mandrill_16.png", SkISize::Make(16, 16), true, false); |
| 240 | check(r, "mandrill_256.png", SkISize::Make(256, 256), true, false); |
| 241 | check(r, "mandrill_32.png", SkISize::Make(32, 32), true, false); |
| 242 | check(r, "mandrill_512.png", SkISize::Make(512, 512), true, false); |
| 243 | check(r, "mandrill_64.png", SkISize::Make(64, 64), true, false); |
| 244 | check(r, "plane.png", SkISize::Make(250, 126), true, false); |
| 245 | check(r, "randPixels.png", SkISize::Make(8, 8), true, false); |
| 246 | check(r, "yellow_rose.png", SkISize::Make(400, 301), true, false); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 247 | } |
scroggo | 0a7e69c | 2015-04-03 07:22:22 -0700 | [diff] [blame] | 248 | |
| 249 | static void test_invalid_stream(skiatest::Reporter* r, const void* stream, size_t len) { |
| 250 | SkCodec* codec = SkCodec::NewFromStream(new SkMemoryStream(stream, len, false)); |
| 251 | // We should not have gotten a codec. Bots should catch us if we leaked anything. |
| 252 | REPORTER_ASSERT(r, !codec); |
| 253 | } |
| 254 | |
| 255 | // Ensure that SkCodec::NewFromStream handles freeing the passed in SkStream, |
| 256 | // even on failure. Test some bad streams. |
| 257 | DEF_TEST(Codec_leaks, r) { |
| 258 | // No codec should claim this as their format, so this tests SkCodec::NewFromStream. |
| 259 | const char nonSupportedStream[] = "hello world"; |
| 260 | // The other strings should look like the beginning of a file type, so we'll call some |
| 261 | // internal version of NewFromStream, which must also delete the stream on failure. |
| 262 | const unsigned char emptyPng[] = { 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a }; |
| 263 | const unsigned char emptyJpeg[] = { 0xFF, 0xD8, 0xFF }; |
| 264 | const char emptyWebp[] = "RIFF1234WEBPVP"; |
| 265 | const char emptyBmp[] = { 'B', 'M' }; |
| 266 | const char emptyIco[] = { '\x00', '\x00', '\x01', '\x00' }; |
| 267 | const char emptyGif[] = "GIFVER"; |
| 268 | |
| 269 | test_invalid_stream(r, nonSupportedStream, sizeof(nonSupportedStream)); |
| 270 | test_invalid_stream(r, emptyPng, sizeof(emptyPng)); |
| 271 | test_invalid_stream(r, emptyJpeg, sizeof(emptyJpeg)); |
| 272 | test_invalid_stream(r, emptyWebp, sizeof(emptyWebp)); |
| 273 | test_invalid_stream(r, emptyBmp, sizeof(emptyBmp)); |
| 274 | test_invalid_stream(r, emptyIco, sizeof(emptyIco)); |
| 275 | test_invalid_stream(r, emptyGif, sizeof(emptyGif)); |
| 276 | } |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 277 | |
| 278 | static void test_dimensions(skiatest::Reporter* r, const char path[]) { |
| 279 | // Create the codec from the resource file |
| 280 | SkAutoTDelete<SkStream> stream(resource(path)); |
| 281 | if (!stream) { |
| 282 | SkDebugf("Missing resource '%s'\n", path); |
| 283 | return; |
| 284 | } |
msarett | b32758a | 2015-08-18 13:22:46 -0700 | [diff] [blame] | 285 | SkAutoTDelete<SkCodec> codec(SkScaledCodec::NewFromStream(stream.detach())); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 286 | if (!codec) { |
| 287 | ERRORF(r, "Unable to create codec '%s'", path); |
| 288 | return; |
| 289 | } |
| 290 | |
| 291 | // Check that the decode is successful for a variety of scales |
msarett | b32758a | 2015-08-18 13:22:46 -0700 | [diff] [blame] | 292 | for (float scale = 0.05f; scale < 2.0f; scale += 0.05f) { |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 293 | // Scale the output dimensions |
| 294 | SkISize scaledDims = codec->getScaledDimensions(scale); |
msarett | b32758a | 2015-08-18 13:22:46 -0700 | [diff] [blame] | 295 | SkImageInfo scaledInfo = codec->getInfo() |
| 296 | .makeWH(scaledDims.width(), scaledDims.height()) |
| 297 | .makeColorType(kN32_SkColorType); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 298 | |
| 299 | // Set up for the decode |
| 300 | size_t rowBytes = scaledDims.width() * sizeof(SkPMColor); |
| 301 | size_t totalBytes = scaledInfo.getSafeSize(rowBytes); |
| 302 | SkAutoTMalloc<SkPMColor> pixels(totalBytes); |
| 303 | |
scroggo | eb602a5 | 2015-07-09 08:16:03 -0700 | [diff] [blame] | 304 | SkCodec::Result result = |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 305 | codec->getPixels(scaledInfo, pixels.get(), rowBytes, nullptr, nullptr, nullptr); |
scroggo | eb602a5 | 2015-07-09 08:16:03 -0700 | [diff] [blame] | 306 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 307 | } |
| 308 | } |
| 309 | |
| 310 | // Ensure that onGetScaledDimensions returns valid image dimensions to use for decodes |
| 311 | DEF_TEST(Codec_Dimensions, r) { |
| 312 | // JPG |
| 313 | test_dimensions(r, "CMYK.jpg"); |
| 314 | test_dimensions(r, "color_wheel.jpg"); |
| 315 | test_dimensions(r, "grayscale.jpg"); |
| 316 | test_dimensions(r, "mandrill_512_q075.jpg"); |
| 317 | test_dimensions(r, "randPixels.jpg"); |
msarett | b32758a | 2015-08-18 13:22:46 -0700 | [diff] [blame] | 318 | |
| 319 | // Decoding small images with very large scaling factors is a potential |
| 320 | // source of bugs and crashes. We disable these tests in Gold because |
| 321 | // tiny images are not very useful to look at. |
| 322 | // Here we make sure that we do not crash or access illegal memory when |
| 323 | // performing scaled decodes on small images. |
| 324 | test_dimensions(r, "1x1.png"); |
| 325 | test_dimensions(r, "2x2.png"); |
| 326 | test_dimensions(r, "3x3.png"); |
| 327 | test_dimensions(r, "3x1.png"); |
| 328 | test_dimensions(r, "1x1.png"); |
| 329 | test_dimensions(r, "16x1.png"); |
| 330 | test_dimensions(r, "1x16.png"); |
| 331 | test_dimensions(r, "mandrill_16.png"); |
| 332 | |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 333 | } |
| 334 | |
msarett | d0375bc | 2015-08-12 08:08:56 -0700 | [diff] [blame] | 335 | static void test_invalid(skiatest::Reporter* r, const char path[]) { |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 336 | SkAutoTDelete<SkStream> stream(resource(path)); |
| 337 | if (!stream) { |
| 338 | SkDebugf("Missing resource '%s'\n", path); |
| 339 | return; |
| 340 | } |
| 341 | SkAutoTDelete<SkCodec> codec(SkCodec::NewFromStream(stream.detach())); |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 342 | REPORTER_ASSERT(r, nullptr == codec); |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 343 | } |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 344 | |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 345 | DEF_TEST(Codec_Empty, r) { |
| 346 | // Test images that should not be able to create a codec |
msarett | d0375bc | 2015-08-12 08:08:56 -0700 | [diff] [blame] | 347 | test_invalid(r, "empty_images/zero-dims.gif"); |
| 348 | test_invalid(r, "empty_images/zero-embedded.ico"); |
| 349 | test_invalid(r, "empty_images/zero-width.bmp"); |
| 350 | test_invalid(r, "empty_images/zero-height.bmp"); |
| 351 | test_invalid(r, "empty_images/zero-width.jpg"); |
| 352 | test_invalid(r, "empty_images/zero-height.jpg"); |
| 353 | test_invalid(r, "empty_images/zero-width.png"); |
| 354 | test_invalid(r, "empty_images/zero-height.png"); |
| 355 | test_invalid(r, "empty_images/zero-width.wbmp"); |
| 356 | test_invalid(r, "empty_images/zero-height.wbmp"); |
| 357 | // This image is an ico with an embedded mask-bmp. This is illegal. |
| 358 | test_invalid(r, "invalid_images/mask-bmp-ico.ico"); |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 359 | } |
msarett | 99f567e | 2015-08-05 12:58:26 -0700 | [diff] [blame] | 360 | |
| 361 | static void test_invalid_parameters(skiatest::Reporter* r, const char path[]) { |
| 362 | SkAutoTDelete<SkStream> stream(resource(path)); |
| 363 | if (!stream) { |
| 364 | SkDebugf("Missing resource '%s'\n", path); |
| 365 | return; |
| 366 | } |
| 367 | SkAutoTDelete<SkScanlineDecoder> decoder(SkScanlineDecoder::NewFromStream( |
| 368 | stream.detach())); |
| 369 | |
| 370 | // This should return kSuccess because kIndex8 is supported. |
| 371 | SkPMColor colorStorage[256]; |
| 372 | int colorCount; |
| 373 | SkCodec::Result result = decoder->start( |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 374 | decoder->getInfo().makeColorType(kIndex_8_SkColorType), nullptr, colorStorage, &colorCount); |
msarett | 99f567e | 2015-08-05 12:58:26 -0700 | [diff] [blame] | 375 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
| 376 | // The rest of the test is uninteresting if kIndex8 is not supported |
| 377 | if (SkCodec::kSuccess != result) { |
| 378 | return; |
| 379 | } |
| 380 | |
| 381 | // This should return kInvalidParameters because, in kIndex_8 mode, we must pass in a valid |
| 382 | // colorPtr and a valid colorCountPtr. |
| 383 | result = decoder->start( |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame^] | 384 | decoder->getInfo().makeColorType(kIndex_8_SkColorType), nullptr, nullptr, nullptr); |
msarett | 99f567e | 2015-08-05 12:58:26 -0700 | [diff] [blame] | 385 | REPORTER_ASSERT(r, SkCodec::kInvalidParameters == result); |
| 386 | result = decoder->start( |
| 387 | decoder->getInfo().makeColorType(kIndex_8_SkColorType)); |
| 388 | REPORTER_ASSERT(r, SkCodec::kInvalidParameters == result); |
| 389 | } |
| 390 | |
| 391 | DEF_TEST(Codec_Params, r) { |
| 392 | test_invalid_parameters(r, "index8.png"); |
| 393 | test_invalid_parameters(r, "mandrill.wbmp"); |
| 394 | } |