Removes const qualification for two methods in TargetDataLowering.
Removes const qualifier for TargetDataLowering::lowerGlobals() and TargetDataLowering::lowerConstants()
BUG= None
R=stichnot@chromium.org
Review URL: https://codereview.chromium.org/1177873003.
diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h
index 069b49e..66e663b 100644
--- a/src/IceTargetLowering.h
+++ b/src/IceTargetLowering.h
@@ -380,9 +380,8 @@
static std::unique_ptr<TargetDataLowering> createLowering(GlobalContext *Ctx);
virtual ~TargetDataLowering();
- virtual void
- lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) const = 0;
- virtual void lowerConstants() const = 0;
+ virtual void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) = 0;
+ virtual void lowerConstants() = 0;
protected:
explicit TargetDataLowering(GlobalContext *Ctx) : Ctx(Ctx) {}
diff --git a/src/IceTargetLoweringARM32.cpp b/src/IceTargetLoweringARM32.cpp
index 5b7bccc..a2091b2 100644
--- a/src/IceTargetLoweringARM32.cpp
+++ b/src/IceTargetLoweringARM32.cpp
@@ -2200,7 +2200,7 @@
}
void TargetDataARM32::lowerGlobals(
- std::unique_ptr<VariableDeclarationList> Vars) const {
+ std::unique_ptr<VariableDeclarationList> Vars) {
switch (Ctx->getFlags().getOutFileType()) {
case FT_Elf: {
ELFObjectWriter *Writer = Ctx->getObjectWriter();
@@ -2219,7 +2219,7 @@
}
}
-void TargetDataARM32::lowerConstants() const {
+void TargetDataARM32::lowerConstants() {
if (Ctx->getFlags().getDisableTranslation())
return;
UnimplementedError(Ctx->getFlags());
diff --git a/src/IceTargetLoweringARM32.h b/src/IceTargetLoweringARM32.h
index bd7d528..2477aaa 100644
--- a/src/IceTargetLoweringARM32.h
+++ b/src/IceTargetLoweringARM32.h
@@ -302,7 +302,7 @@
~TargetARM32() override {}
};
-class TargetDataARM32 : public TargetDataLowering {
+class TargetDataARM32 final : public TargetDataLowering {
TargetDataARM32() = delete;
TargetDataARM32(const TargetDataARM32 &) = delete;
TargetDataARM32 &operator=(const TargetDataARM32 &) = delete;
@@ -312,8 +312,8 @@
return std::unique_ptr<TargetDataLowering>(new TargetDataARM32(Ctx));
}
- void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) const final;
- void lowerConstants() const final;
+ void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override;
+ void lowerConstants() override;
protected:
explicit TargetDataARM32(GlobalContext *Ctx);
@@ -334,7 +334,7 @@
return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderARM32(Ctx));
}
- void lower();
+ void lower() override;
protected:
explicit TargetHeaderARM32(GlobalContext *Ctx);
diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp
index 494f233..748881e 100644
--- a/src/IceTargetLoweringMIPS32.cpp
+++ b/src/IceTargetLoweringMIPS32.cpp
@@ -677,7 +677,7 @@
}
void TargetDataMIPS32::lowerGlobals(
- std::unique_ptr<VariableDeclarationList> Vars) const {
+ std::unique_ptr<VariableDeclarationList> Vars) {
switch (Ctx->getFlags().getOutFileType()) {
case FT_Elf: {
ELFObjectWriter *Writer = Ctx->getObjectWriter();
@@ -696,7 +696,7 @@
}
}
-void TargetDataMIPS32::lowerConstants() const {
+void TargetDataMIPS32::lowerConstants() {
if (Ctx->getFlags().getDisableTranslation())
return;
llvm::report_fatal_error("Not yet implemented");
diff --git a/src/IceTargetLoweringMIPS32.h b/src/IceTargetLoweringMIPS32.h
index b6c325a..3aad63f 100644
--- a/src/IceTargetLoweringMIPS32.h
+++ b/src/IceTargetLoweringMIPS32.h
@@ -127,7 +127,7 @@
~TargetMIPS32() override {}
};
-class TargetDataMIPS32 : public TargetDataLowering {
+class TargetDataMIPS32 final : public TargetDataLowering {
TargetDataMIPS32() = delete;
TargetDataMIPS32(const TargetDataMIPS32 &) = delete;
TargetDataMIPS32 &operator=(const TargetDataMIPS32 &) = delete;
@@ -137,8 +137,8 @@
return std::unique_ptr<TargetDataLowering>(new TargetDataMIPS32(Ctx));
}
- void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) const final;
- void lowerConstants() const final;
+ void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override;
+ void lowerConstants() override;
protected:
explicit TargetDataMIPS32(GlobalContext *Ctx);
diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp
index f6cd26f..dcfdc96 100644
--- a/src/IceTargetLoweringX8632.cpp
+++ b/src/IceTargetLoweringX8632.cpp
@@ -5017,7 +5017,7 @@
TargetDataX8632::TargetDataX8632(GlobalContext *Ctx)
: TargetDataLowering(Ctx) {}
-void TargetDataX8632::lowerGlobal(const VariableDeclaration &Var) const {
+void TargetDataX8632::lowerGlobal(const VariableDeclaration &Var) {
// If external and not initialized, this must be a cross test.
// Don't generate a declaration for such cases.
bool IsExternal = Var.isExternal() || Ctx->getFlags().getDisableInternal();
@@ -5094,7 +5094,7 @@
}
void TargetDataX8632::lowerGlobals(
- std::unique_ptr<VariableDeclarationList> Vars) const {
+ std::unique_ptr<VariableDeclarationList> Vars) {
switch (Ctx->getFlags().getOutFileType()) {
case FT_Elf: {
ELFObjectWriter *Writer = Ctx->getObjectWriter();
@@ -5170,7 +5170,7 @@
}
}
-void TargetDataX8632::lowerConstants() const {
+void TargetDataX8632::lowerConstants() {
if (Ctx->getFlags().getDisableTranslation())
return;
// No need to emit constants from the int pool since (for x86) they
diff --git a/src/IceTargetLoweringX8632.h b/src/IceTargetLoweringX8632.h
index 8d108bd..fe3612c 100644
--- a/src/IceTargetLoweringX8632.h
+++ b/src/IceTargetLoweringX8632.h
@@ -577,7 +577,7 @@
BoolFolding FoldingInfo;
};
-class TargetDataX8632 : public TargetDataLowering {
+class TargetDataX8632 final : public TargetDataLowering {
TargetDataX8632() = delete;
TargetDataX8632(const TargetDataX8632 &) = delete;
TargetDataX8632 &operator=(const TargetDataX8632 &) = delete;
@@ -587,14 +587,14 @@
return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx));
}
- void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) const final;
- void lowerConstants() const final;
+ void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override;
+ void lowerConstants() override;
protected:
explicit TargetDataX8632(GlobalContext *Ctx);
private:
- void lowerGlobal(const VariableDeclaration &Var) const;
+ void lowerGlobal(const VariableDeclaration &Var);
~TargetDataX8632() override {}
template <typename T> static void emitConstantPool(GlobalContext *Ctx);
};