commit 1b6f8c7ddd089c1aa540904b5f8f93902de7d794
author Ben Clayton <bclayton@google.com> Tue Apr 09 13:47:43 2019 -0400
committer Ben Clayton <bclayton@google.com> Wed Apr 10 21:22:33 2019 +0000
tree cd31d5cca185782673deef1312f76d3f87949d20
parent a2c8b7783255dc162b1c155336a7e516b59d9679

SpirvShader: Implement GLSLstd450Cos

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.cos.*
Change-Id: I4b5fe36487f0832ad21f3e78df9ba133284cffbd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28669
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

src/Pipeline/SpirvShader.cpp

diff --git a/src/Pipeline/SpirvShader.cpp b/src/Pipeline/SpirvShader.cpp
index 7975872..ad3d08f 100644
--- a/src/Pipeline/SpirvShader.cpp
+++ b/src/Pipeline/SpirvShader.cpp
@@ -3293,6 +3293,15 @@
 			}
 			break;
 		}
+		case GLSLstd450Cos:
+		{
+			auto radians = GenericValue(this, routine, insn.word(5));
+			for (auto i = 0u; i < type.sizeInComponents; i++)
+			{
+				dst.move(i, Cos(radians.Float(i)));
+			}
+			break;
+		}
 		default:
 			UNIMPLEMENTED("Unhandled ExtInst %d", extInstIndex);
 		}

src/Reactor/LLVMReactor.cpp

diff --git a/src/Reactor/LLVMReactor.cpp b/src/Reactor/LLVMReactor.cpp
index abe35df..578dfa1 100644
--- a/src/Reactor/LLVMReactor.cpp
+++ b/src/Reactor/LLVMReactor.cpp
@@ -555,6 +555,7 @@
 			func_.emplace("puts", reinterpret_cast<void*>(puts));
 			func_.emplace("fmodf", reinterpret_cast<void*>(fmodf));
 			func_.emplace("sinf", reinterpret_cast<void*>(sinf));
+			func_.emplace("cosf", reinterpret_cast<void*>(cosf));
 		}
 
 		void *findSymbol(const std::string &name) const
@@ -3070,6 +3071,12 @@
 		return RValue<Float4>(V(::builder->CreateCall(func, V(v.value))));
 	}
 
+	RValue<Float4> Cos(RValue<Float4> v)
+	{
+		auto func = llvm::Intrinsic::getDeclaration(::module, llvm::Intrinsic::cos, { V(v.value)->getType() } );
+		return RValue<Float4>(V(::builder->CreateCall(func, V(v.value))));
+	}
+
 	Type *Float4::getType()
 	{
 		return T(llvm::VectorType::get(T(Float::getType()), 4));

src/Reactor/Reactor.hpp

diff --git a/src/Reactor/Reactor.hpp b/src/Reactor/Reactor.hpp
index 41e15c8..2419dbe 100644
--- a/src/Reactor/Reactor.hpp
+++ b/src/Reactor/Reactor.hpp
@@ -2209,6 +2209,7 @@
 	// Trigonometric functions
 	// TODO: Currentlhy unimplemented for Subzero.
 	RValue<Float4> Sin(RValue<Float4> x);
+	RValue<Float4> Cos(RValue<Float4> x);
 
 	template<class T>
 	class Pointer : public LValue<Pointer<T>>