Subzero: Reduce the amount of #ifdef'd code.
Try to make most #ifdef'd code be compiled under all configurations,
to catch code rot earlier. When #ifdef code is required, try to use
it only to guard trivial code like "return;".
BUG= none
R=jpp@chromium.org
Review URL: https://codereview.chromium.org/1197863003
diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp
index 7c93463..64b00db 100644
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -411,7 +411,7 @@
}
void TargetLowering::emitWithoutPrefix(const ConstantRelocatable *C) const {
- if (!ALLOW_DUMP)
+ if (!BuildDefs::dump())
return;
Ostream &Str = Ctx->getStrEmit();
if (C->getSuppressMangling())
@@ -427,7 +427,7 @@
}
void TargetLowering::emit(const ConstantRelocatable *C) const {
- if (!ALLOW_DUMP)
+ if (!BuildDefs::dump())
return;
Ostream &Str = Ctx->getStrEmit();
Str << getConstantPrefix();
@@ -472,7 +472,7 @@
void TargetDataLowering::emitGlobal(const VariableDeclaration &Var,
const IceString &SectionSuffix) {
- if (!ALLOW_DUMP)
+ if (!BuildDefs::dump())
return;
// If external and not initialized, this must be a cross test.
@@ -518,8 +518,9 @@
Var.getInitializers()) {
switch (Init->getKind()) {
case VariableDeclaration::Initializer::DataInitializerKind: {
- const auto &Data = llvm::cast<VariableDeclaration::DataInitializer>(
- Init.get())->getContents();
+ const auto &Data =
+ llvm::cast<VariableDeclaration::DataInitializer>(Init.get())
+ ->getContents();
for (SizeT i = 0; i < Init->getNumBytes(); ++i) {
Str << "\t.byte\t" << (((unsigned)Data[i]) & 0xff) << "\n";
}