Regres: Fix priority boost for +2 code review.
Confusingly the "Code-Review" label uses 'Value' for -1 / +1, and 'Approved' for +2s.
Changes that were ready to land were not being prioritized over no-code review.
Change-Id: Ia31adcbbba70b2f52b9abc7299f4bafdcdb8fe48
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27170
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
diff --git a/tests/regres/main.go b/tests/regres/main.go
index 7db4876..b4e246d 100644
--- a/tests/regres/main.go
+++ b/tests/regres/main.go
@@ -533,6 +533,7 @@
kokoroPresubmit := change.Labels["Kokoro-Presubmit"].Approved.AccountID != 0
codeReviewScore := change.Labels["Code-Review"].Value
+ codeReviewApproved := change.Labels["Code-Review"].Approved.AccountID != 0
presubmitReady := change.Labels["Presubmit-Ready"].Approved.AccountID != 0
c.priority = 0
@@ -540,6 +541,9 @@
c.priority += 10
}
c.priority += codeReviewScore
+ if codeReviewApproved {
+ c.priority += 2
+ }
if kokoroPresubmit {
c.priority++
}