commit 9441b0724c13635e28f67755e1090279dcc3b411
author Alexis Hetu <sugoi@google.com> Wed Aug 02 08:40:37 2017 -0400
committer Alexis Hétu <sugoi@google.com> Wed Aug 02 14:16:10 2017 +0000
tree 2ef53582d3d94a61876665e151abd455c36efa47
parent 5790c95e78a6e98d82e6c9ed0b8dc60c4bdeb5fa

SwiftShader always builds its release version in Chromium

SwiftShader's debug version was too slow for Chromium's debug
trybots. To solve this issue, SwiftShader now always builds
its release version in Chromium.

'git cl format' was ran in Chromium to ensure proper formatting
of the gn files.

Change-Id: I346045b68b566813ab6ab739aaa6eeb243d51853
Reviewed-on: https://swiftshader-review.googlesource.com/11188
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 4ea872f..bec953d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -31,47 +31,28 @@
       "NOMINMAX",
       "_WINDLL",
       "NO_SANITIZE_FUNCTION=",
+      "ANGLE_DISABLE_TRACE",
     ]
-
-    if (is_debug) {
-      cflags += [ "/RTC1" ]  # Run-Time Error Checks
-    } else {
-      defines += [ "ANGLE_DISABLE_TRACE" ]
-    }
   } else {
     cflags = [
       "-std=c++11",
       "-Wall",
       "-fno-exceptions",
       "-fno-operator-names",
+      "-ffunction-sections",
+      "-fdata-sections",
+      "-fomit-frame-pointer",
+      "-Os",
     ]
 
     defines += [
       "__STDC_CONSTANT_MACROS",
       "__STDC_LIMIT_MACROS",
       "NO_SANITIZE_FUNCTION=__attribute__((no_sanitize(\"function\")))",
+      "ANGLE_DISABLE_TRACE",
+      "NDEBUG",
     ]
 
-    if (is_debug) {
-      cflags += [
-        "-g",
-        "-g3",
-      ]
-    } else {  # Release
-      # All Release builds use function/data sections to make the shared libraries smaller
-      cflags += [
-        "-ffunction-sections",
-        "-fdata-sections",
-        "-fomit-frame-pointer",
-        "-Os",
-      ]
-
-      defines += [
-        "ANGLE_DISABLE_TRACE",
-        "NDEBUG",
-      ]
-    }
-
     if (target_cpu == "x64") {  # 64 bit version
       cflags += [
         "-m64",
@@ -91,11 +72,10 @@
         "-Wl,--hash-style=both",
         "-Wl,--gc-sections",
       ]
+
       # A bug in the gold linker prevents using ICF on 32-bit (crbug.com/729532)
       if (use_gold && target_cpu == "x86") {
-        ldflags += [
-          "-Wl,--icf=none",
-        ]
+        ldflags += [ "-Wl,--icf=none" ]
       }
     }
   }