Implement a proper function list in module, which auto-maintain the parent
pointer, and ensure that functions are deleted when the module is destroyed.
This exposed the fact that MLFunction had no dtor, and that the dtor in
CFGFunction was broken with cyclic references. Fix both of these problems.
PiperOrigin-RevId: 206051666
diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp
index 96f7f73..9e52556 100644
--- a/lib/IR/Verifier.cpp
+++ b/lib/IR/Verifier.cpp
@@ -330,8 +330,8 @@
bool Module::verify(std::string *errorResult) const {
/// Check that each function is correct.
- for (auto fn : functionList) {
- if (fn->verify(errorResult))
+ for (auto &fn : *this) {
+ if (fn.verify(errorResult))
return true;
}