commit f8cce87f62e700f78a8b4a4087782ca8640cbc8c
author Chris Lattner <clattner@google.com> Fri Jul 20 09:28:54 2018 -0700
committer jpienaar <jpienaar@google.com> Fri Mar 29 12:37:00 2019 -0700
tree 8cf8ffefdaa1a9d4ee29eb6631762e2b4045315b
parent c1faf6658e1b74700b159645f64f95befeaa0195

Teach the asmprinter to print out operands for OperationInst's.  This
is still limited in several ways, which i'll build out in subsequent patches.

Rename the accessor for inst operands/results to make the Operand/Result
versions of these more obscure, allowing getOperand/getResult to traffic
in values (which is what - by far - most clients actually care about).

PiperOrigin-RevId: 205408439

lib/Parser/Parser.cpp

diff --git a/lib/Parser/Parser.cpp b/lib/Parser/Parser.cpp
index 7b7ee89..b8bae40 100644
--- a/lib/Parser/Parser.cpp
+++ b/lib/Parser/Parser.cpp
@@ -1364,8 +1364,7 @@
   if (operandTypes.size() != operandInfos.size()) {
     auto plural = "s"[operandInfos.size() == 1];
     return emitError(typeLoc, "expected " + llvm::utostr(operandInfos.size()) +
-                                  " type" + plural +
-                                  " in operand list but had " +
+                                  " operand type" + plural + " but had " +
                                   llvm::utostr(operandTypes.size()));
   }
 
@@ -1395,11 +1394,10 @@
     // FIXME: Add result infra to handle Stmt results as well to make this
     // generic.
     if (auto *inst = dyn_cast<OperationInst>(op)) {
-      if (inst->getResults().empty())
+      if (inst->getNumResults() == 0)
         return emitError(loc, "cannot name an operation with no results");
 
-      // TODO: This should be getResult(0)
-      addDefinition({resultID, loc}, &inst->getResults()[0]);
+      addDefinition({resultID, loc}, inst->getResult(0));
     }
   }