Teach the asmprinter to print out operands for OperationInst's. This
is still limited in several ways, which i'll build out in subsequent patches.
Rename the accessor for inst operands/results to make the Operand/Result
versions of these more obscure, allowing getOperand/getResult to traffic
in values (which is what - by far - most clients actually care about).
PiperOrigin-RevId: 205408439
diff --git a/test/IR/parser-errors.mlir b/test/IR/parser-errors.mlir
index 49fd2da..b2c7432 100644
--- a/test/IR/parser-errors.mlir
+++ b/test/IR/parser-errors.mlir
@@ -168,7 +168,7 @@
cfgfunc @test() {
bb40:
- %1 = "foo"() : (i32)->i64 // expected-error {{expected 0 types in operand list but had 1}}
+ %1 = "foo"() : (i32)->i64 // expected-error {{expected 0 operand types but had 1}}
return
}
diff --git a/test/IR/parser.mlir b/test/IR/parser.mlir
index 9b384b4..222fa12 100644
--- a/test/IR/parser.mlir
+++ b/test/IR/parser.mlir
@@ -70,10 +70,10 @@
cfgfunc @simpleCFG(i32, f32) {
// CHECK: bb0:
bb42: // (%0: i32, %f: f32): TODO(clattner): implement bbargs.
- // CHECK: "foo"() : () -> i64
+ // CHECK: %0 = "foo"() : () -> i64
%1 = "foo"() : ()->i64
- // CHECK: "bar"() : (i64) -> (i1, i1, i1)
- "bar"(%1) : (i64) -> (i1,i1,i1)
+ // CHECK: "bar"(%0) : (i64) -> (i1, i1, i1)
+ %2 = "bar"(%1) : (i64) -> (i1,i1,i1)
// CHECK: return
return
// CHECK: }
@@ -104,6 +104,7 @@
// CHECK-LABEL: cfgfunc @cfgfunc_with_ops() {
cfgfunc @cfgfunc_with_ops() {
bb0:
+ // CHECK: %0 = "getTensor"() : () -> tensor<4x4x?xf32>
%t = "getTensor"() : () -> tensor<4x4x?xf32>
// CHECK: dim xxx, 2 : sometype
@@ -166,6 +167,7 @@
// CHECK-LABEL: cfgfunc @standard_instrs() {
cfgfunc @standard_instrs() {
bb42: // CHECK: bb0:
+ // CHECK: %0 = "getTensor"() : () -> tensor<4x4x?xf32>
%42 = "getTensor"() : () -> tensor<4x4x?xf32>
// CHECK: dim xxx, 2 : sometype