commit 001b25ef86c1b3843a6c05d41968eb77b2abf905
author Taylor Holberton <taylorcholberton@gmail.com> Mon Apr 10 12:42:06 2017 -0700
committer Taylor Holberton <taylorcholberton@gmail.com> Mon Apr 10 12:42:06 2017 -0700
tree 88c0ee29057643867e824d0dfc92a2991eec5930
parent 04b47b083101a6855557cde6d638e1e3f26095bb

adding bounds check only when needed

src/pcm.c

diff --git a/src/pcm.c b/src/pcm.c
index 24f4f2b..ef38c9c 100644
--- a/src/pcm.c
+++ b/src/pcm.c
@@ -677,8 +677,11 @@
 
     if (pcm->flags & PCM_IN)
         return -EINVAL;
-    else if ((frame_count > TINYALSA_FRAMES_MAX)
-          || (frame_count > INT_MAX))
+#if UINT_MAX > TINYALSA_FRAMES_MAX
+    if (frame_count > TINYALSA_FRAMES_MAX)
+        return -EINVAL;
+#endif
+    if (frame_count > INT_MAX)
         return -EINVAL;
 
     x.buf = (void*)data;
@@ -730,8 +733,11 @@
 
     if (!(pcm->flags & PCM_IN))
         return -EINVAL;
-    else if ((frame_count > TINYALSA_FRAMES_MAX)
-          || (frame_count > INT_MAX))
+#if UINT_MAX > TINYALSA_FRAMES_MAX
+    if (frame_count > TINYALSA_FRAMES_MAX)
+        return -EINVAL;
+#endif
+    if (frame_count > INT_MAX)
         return -EINVAL;
 
     x.buf = data;