commit ab37df8d67c3813c7c0bbe4806669f9fba4a0fdc
author Dmitry-Me <wipedout@yandex.ru> Fri Nov 28 12:08:36 2014 +0300
committer Dmitry-Me <wipedout@yandex.ru> Fri Nov 28 12:08:36 2014 +0300
tree de69581cb86f46aaecabd48eb4cce829d2e93462
parent 2114e47453da5b06ee15ee342a627859bc630736

Error checking never actually checked anything

tinyxml2.cpp

diff --git a/tinyxml2.cpp b/tinyxml2.cpp
index cd77a96..06cd441 100755
--- a/tinyxml2.cpp
+++ b/tinyxml2.cpp
@@ -1654,6 +1654,9 @@
 {

     DeleteChildren();

 

+#ifdef DEBUG

+    const bool hadError = Error();

+#endif

     _errorID = XML_NO_ERROR;

     _errorStr1 = 0;

     _errorStr2 = 0;

@@ -1669,7 +1672,7 @@
 #endif

     

 #ifdef DEBUG

-    if ( Error() == false ) {

+    if ( !hadError ) {

         TIXMLASSERT( _elementPool.CurrentAllocs()   == _elementPool.Untracked() );

         TIXMLASSERT( _attributePool.CurrentAllocs() == _attributePool.Untracked() );

         TIXMLASSERT( _textPool.CurrentAllocs()      == _textPool.Untracked() );