Various minor crosperf cleanups.
- Add results summary information for peacekeeper.html to json file.
- Don't add section for 'perf table' to html report if there is no perf report.
- Remove the color box for the gmean speedup (there's no good way to label it
and it's confusing unless you know what it is).
BUG=None
TEST=Ran Crosperf with these changes. It all seems to work correctly.
Change-Id: I2bf5bdfc2667ae665767374d10672d2d19696267
Reviewed-on: https://chrome-internal-review.googlesource.com/160896
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
diff --git a/crosperf/default-telemetry-results.json b/crosperf/default-telemetry-results.json
index 54d34af..f866631 100644
--- a/crosperf/default-telemetry-results.json
+++ b/crosperf/default-telemetry-results.json
@@ -1 +1 @@
-{"page_cycler.intl_hi_ru": ["cold_times__page_load_time", "warm_times__page_load_time"], "page_cycler.intl_es_fr_pt-BR": ["cold_times__page_load_time", "warm_times__page_load_time"], "dromaeo.jslibeventjquery": ["jslib_event_jquery__jslib_event_jquery"], "browsermark": ["Score__Score"], "smoothness.top_25": ["frame_times__frame_times", "mean_frame_time__mean_frame_time"], "page_cycler.morejs": ["warm_times__page_load_time", "cold_times__page_load_time"], "page_cycler.dhtml": ["warm_times__page_load_time", "cold_times__page_load_time"], "page_cycler.bloat": ["warm_times__page_load_time", "cold_times__page_load_time"], "dromaeo.jslibstyleprototype": ["jslib_style_prototype__jslib_style_prototype"], "dromaeo.jslibstylejquery": ["jslib_style_jquery__jslib_style_jquery"], "dromaeo.jslibeventprototype": ["jslib_event_prototype__jslib_event_prototype"], "page_cycler.moz": ["warm_times__page_load_time", "cold_times__page_load_time"], "octane": ["Total__Score"], "jsgamebench": ["Score__Score"], "page_cycler.indexed_db.basic_insert": ["warm_times__page_load_time", "cold_times__page_load_time"], "spaceport": ["Score__Score"], "dromaeo.jslibtraverseprototype": ["jslib_traverse_prototype__jslib_traverse_prototype"], "page_cycler.netsim.top_10": ["cold_times__page_load_time", "warm_times__page_load_time"], "robohornet_pro": ["Total__Total"], "dromaeo.domcoreattr": ["dom_attr__dom_attr"], "dromaeo.jslibattrprototype": ["jslib_attr_prototype__jslib_attr_prototype"], "sunspider": ["Total__Total"], "dromaeo.jslibattrjquery": ["jslib_attr_jquery__jslib_attr_jquery"], "page_cycler.typical_25": ["warm_times__page_load_time", "cold_times__page_load_time"], "dromaeo.domcoretraverse": ["dom_traverse__dom_traverse"], "dromaeo.domcoremodify": ["dom_modify__dom_modify"], "page_cycler.intl_ar_fa_he": ["warm_times__page_load_time", "cold_times__page_load_time"], "page_cycler.intl_ja_zh": ["warm_times__page_load_time", "cold_times__page_load_time"], "page_cycler.intl_ko_th_vi": ["warm_times__page_load_time", "cold_times__page_load_time"], "canvasmark": ["Score__Score"], "dromaeo.domcorequery": ["dom_query__dom_query"], "dromaeo.jslibtraversejquery": ["jslib_traverse_jquery__jslib_traverse_jquery"], "dromaeo.jslibmodifyprototype": ["jslib_modify_prototype__jslib_modify_prototype"], "page_cycler.tough_layout_cases": ["warm_times__page_load_time", "cold_times__page_load_time"], "kraken": ["Total__Total"], "dromaeo.jslibmodifyjquery": ["jslib_modify_jquery__jslib_modify_jquery"]}
\ No newline at end of file
+{"peacekeeper.html": ["Total__Score", "workerContrast01__Score", "workerContrast02__Score"], "page_cycler.intl_hi_ru": ["cold_times__page_load_time", "warm_times__page_load_time"], "page_cycler.intl_es_fr_pt-BR": ["cold_times__page_load_time", "warm_times__page_load_time"], "dromaeo.jslibeventjquery": ["jslib_event_jquery__jslib_event_jquery"], "browsermark": ["Score__Score"], "smoothness.top_25": ["frame_times__frame_times", "mean_frame_time__mean_frame_time"], "page_cycler.morejs": ["warm_times__page_load_time", "cold_times__page_load_time"], "page_cycler.dhtml": ["warm_times__page_load_time", "cold_times__page_load_time"], "page_cycler.bloat": ["warm_times__page_load_time", "cold_times__page_load_time"], "dromaeo.jslibstyleprototype": ["jslib_style_prototype__jslib_style_prototype"], "dromaeo.jslibstylejquery": ["jslib_style_jquery__jslib_style_jquery"], "dromaeo.jslibeventprototype": ["jslib_event_prototype__jslib_event_prototype"], "page_cycler.moz": ["warm_times__page_load_time", "cold_times__page_load_time"], "octane": ["Total__Score"], "jsgamebench": ["Score__Score"], "page_cycler.indexed_db.basic_insert": ["warm_times__page_load_time", "cold_times__page_load_time"], "spaceport": ["Score__Score"], "dromaeo.jslibtraverseprototype": ["jslib_traverse_prototype__jslib_traverse_prototype"], "page_cycler.netsim.top_10": ["cold_times__page_load_time", "warm_times__page_load_time"], "dromaeo.jslibmodifyjquery": ["jslib_modify_jquery__jslib_modify_jquery"], "dromaeo.domcoreattr": ["dom_attr__dom_attr"], "dromaeo.jslibattrprototype": ["jslib_attr_prototype__jslib_attr_prototype"], "sunspider": ["Total__Total"], "dromaeo.jslibattrjquery": ["jslib_attr_jquery__jslib_attr_jquery"], "page_cycler.typical_25": ["warm_times__page_load_time", "cold_times__page_load_time"], "dromaeo.domcoretraverse": ["dom_traverse__dom_traverse"], "dromaeo.domcoremodify": ["dom_modify__dom_modify"], "page_cycler.intl_ar_fa_he": ["warm_times__page_load_time", "cold_times__page_load_time"], "page_cycler.intl_ja_zh": ["warm_times__page_load_time", "cold_times__page_load_time"], "dromaeo.domcorequery": ["dom_query__dom_query"], "canvasmark": ["Score__Score"], "page_cycler.intl_ko_th_vi": ["warm_times__page_load_time", "cold_times__page_load_time"], "dromaeo.jslibtraversejquery": ["jslib_traverse_jquery__jslib_traverse_jquery"], "dromaeo.jslibmodifyprototype": ["jslib_modify_prototype__jslib_modify_prototype"], "page_cycler.tough_layout_cases": ["warm_times__page_load_time", "cold_times__page_load_time"], "kraken": ["Total__Total"], "robohornet_pro": ["Total__Total"]}
\ No newline at end of file
diff --git a/crosperf/perf_table.py b/crosperf/perf_table.py
index 3c8b88b..7e21c83 100644
--- a/crosperf/perf_table.py
+++ b/crosperf/perf_table.py
@@ -43,7 +43,8 @@
perf_file = os.path.join(self._experiment.results_directory,
dir_name,
"perf.data.report.0")
- self.ReadPerfReport(perf_file, label, benchmark.name, i - 1)
+ if os.path.exists(perf_file):
+ self.ReadPerfReport(perf_file, label, benchmark.name, i - 1)
def ReadPerfReport(self, perf_file, label, benchmark_name, iteration):
"""Add the data from one run to the dict."""
diff --git a/crosperf/results_report.py b/crosperf/results_report.py
index 840f7b3..2f352fe 100644
--- a/crosperf/results_report.py
+++ b/crosperf/results_report.py
@@ -62,8 +62,6 @@
CoeffVarFormat(), "StdDev/Mean"),
Column(GmeanRatioResult(),
RatioFormat(), "GmeanSpeedup"),
- Column(GmeanRatioResult(),
- ColorBoxFormat(), " "),
Column(PValueResult(),
PValueFormat(), "p-value")
]