commit 62b53ed9e64e40d2534f1239c4b314d84e79f15f
author Patrick Ohly <patrick.ohly@intel.com> Tue Feb 09 16:43:35 2016 +0100
committer Rob Landley <rob@landley.net> Wed Feb 10 22:32:37 2016 -0600
tree 7f2fa04b2e905432b7693cf41e075b7638cfcd38
parent e2d042c8e868a129396f03ec759e2ccdb8304833

main.c: fix non-root usage when installed suid root

When toybox is installed suid root and invoked by a non-root user for
commands which do not require root privileges, it drops the root
privileges during initialization.

However, since commit afba5b8efd the result check of setuid() was
inverted such that it aborted on success, making toybox unusuable for
non-root users.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>

main.c

diff --git a/main.c b/main.c
index 6dd4cea..cf82872 100644
--- a/main.c
+++ b/main.c
@@ -107,7 +107,7 @@
 
     if (!(which->flags & TOYFLAG_STAYROOT)) {
       if (uid != euid) {
-        if (!setuid(uid)) perror_exit("setuid %d->%d", euid, uid); // drop root
+        if (setuid(uid)) perror_exit("setuid %d->%d", euid, uid); // drop root
         euid = uid;
         toys.wasroot++;
       }