commit 7bf0b08bcd19b3f9955e0222462f44c8289c5ffb
author Andreas Fuchs <andreas.fuchs@sit.fraunhofer.de> Thu Mar 29 17:01:18 2018 +0200
committer Tadeusz Struk <tadeusz.struk@intel.com> Thu Mar 29 15:53:42 2018 -0700
tree eb2a4e76443cee6430763cbefe33929aaad0ba26
parent 1c4a8118b8affed6d0ef9ec5e307e2c5877ed3bf

Tests: Fixed bug in qualifiers and add warning

This patch fixes a bug where the pointer was qualified
as const instead of the character array pointed to.
This also allows us to stop suppressing
Wignore-qualifiers errors.

Signed-off-by: Andreas Fuchs <andreas.fuchs@sit.fraunhofer.de>

configure.ac

diff --git a/configure.ac b/configure.ac
index 4974c19..81bafda 100644
--- a/configure.ac
+++ b/configure.ac
@@ -117,7 +117,6 @@
 AX_ADD_COMPILER_FLAG([-Wextra])
 AX_ADD_COMPILER_FLAG([-Wformat-security])
 AX_ADD_COMPILER_FLAG([-Werror])
-AX_ADD_COMPILER_FLAG([-Wno-ignored-qualifiers])
 AX_ADD_COMPILER_FLAG([-fstack-protector-all])
 AX_ADD_COMPILER_FLAG([-fpic])
 AX_ADD_COMPILER_FLAG([-fPIC])

test/integration/test-options.c

diff --git a/test/integration/test-options.c b/test/integration/test-options.c
index 308c3c8..cf4df34 100644
--- a/test/integration/test-options.c
+++ b/test/integration/test-options.c
@@ -49,7 +49,7 @@
  * Convert from an element in the TCTI_TYPE enumeration to a string
  * representation.
  */
-char *const
+const char *
 tcti_name_from_type(TCTI_TYPE tcti_type)
 {
     int i;

test/integration/test-options.h

diff --git a/test/integration/test-options.h b/test/integration/test-options.h
index e6151cd..ecfd2b4 100644
--- a/test/integration/test-options.h
+++ b/test/integration/test-options.h
@@ -35,7 +35,7 @@
 } test_opts_t;
 
 /* functions to get test options from the user and to print helpful stuff */
-char *const tcti_name_from_type(TCTI_TYPE tcti_type);
+const char *tcti_name_from_type(TCTI_TYPE tcti_type);
 TCTI_TYPE tcti_type_from_name(char const *tcti_str);
 int get_test_opts_from_env(test_opts_t * opts);
 int sanity_check_test_opts(test_opts_t * opts);