Tss2_Sys_Finalize: Change return type from void to TSS2_RC.
This is an update to better align this implementation with the TSS spec
from the TCG. Section 8.7.1.3 in the 1.0 version of the TSS spec defines
the return type as a TSS2_RC. The spec defines no RCs for this function
call so it does nothing but return TSS2_RC_SUCCESS.
Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d02be2d..d0dc0cc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@
### Changed
- Move unit tests from test/ to test/unit/.
### Fixed
+- Wrong return type for Tss2_Sys_Finalize (API break).
- NULL dereference bug in device TCTI init function.
- Two race conditions in the resourcemgr.
diff --git a/include/sapi/tss2_sys.h b/include/sapi/tss2_sys.h
index 5e07fee..cbd87cd 100644
--- a/include/sapi/tss2_sys.h
+++ b/include/sapi/tss2_sys.h
@@ -1,5 +1,5 @@
//**********************************************************************;
-// Copyright (c) 2015, Intel Corporation
+// Copyright (c) 2015, 2016 Intel Corporation
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
@@ -92,7 +92,7 @@
TSS2_ABI_VERSION *abiVersion
);
-void Tss2_Sys_Finalize(
+TSS2_RC Tss2_Sys_Finalize(
TSS2_SYS_CONTEXT *sysContext
);
diff --git a/sysapi/sysapi/Tss2_Sys_Finalize.c b/sysapi/sysapi/Tss2_Sys_Finalize.c
index 63b1b00..da188c9 100644
--- a/sysapi/sysapi/Tss2_Sys_Finalize.c
+++ b/sysapi/sysapi/Tss2_Sys_Finalize.c
@@ -1,5 +1,5 @@
//**********************************************************************;
-// Copyright (c) 2015, Intel Corporation
+// Copyright (c) 2015, 2016, Intel Corporation
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
@@ -28,10 +28,10 @@
#include <sapi/tpm20.h>
#include "sysapi_util.h"
-void Tss2_Sys_Finalize(
+TSS2_RC Tss2_Sys_Finalize(
TSS2_SYS_CONTEXT *sysContext
)
{
- // Nothing to do here.
+ return TSS2_RC_SUCCESS;
}