tree 99948371c8612ef0b5e423e17c46b5aaf5b8fa5d
parent 27a32287312f4b1effa4b3d77d7d465eda30589a
author cushon <cushon@google.com> 1478281566 -0700
committer Liam Miller-Cushon <cushon@google.com> 1478287549 -0400

Never mark enums as abstract

Using enum constant members as a heuristic for abstract enums was
broken, because of cases like:

public enum E {
  ONE {
    public void f() {}
  }
}

javac drops the inaccessible member f() and doesn't generate an instance
class for ONE, so E doesn't need to be abstract.

Assuming all enums are final is safe, because nothing outside the
compilation unit can extend abstract enums anyways, and refactoring an
existing enum to implement methods in the container class instead of the
constants is not a breaking change.

MOE_MIGRATED_REVID=138207374