tree 79c6c46e1f9c237fbb9a0db5100e4338fe0b11be
parent 00a66b1deab322e1b088d7f7616c73ea180e356c
author sewardj <sewardj@a5019735-40e9-0310-863c-91ae7b9d1cf9> 1034443636 +0000
committer sewardj <sewardj@a5019735-40e9-0310-863c-91ae7b9d1cf9> 1034443636 +0000


Fixes for the DWARF2 reader, from Josef Weidendorfer:

Attached patch is for the Dwarf2 source line info reader;
For reading, a state machine is used reconstructing source line
info while running and reading (see DWARF2 specification, ch. 6.2).
The state machine was correct, but the calls to addLineInfo()
were wrong: It reported most of the times too small ranges
for source code statements, because it used only the diff of the last
state machine command instead of the diff to the last statement
boundary. Effect: Around 1/3 of all addresses with source line info got
unknown location.
The patch adds a "last_address" to the state machine to remember the last
statement boundary. On reset, it#s initialised to the "invalid" address 0. I
hope this is OK (or should we use "(Addr)-1" instead?).
The patch now uses the "is_stmt" boolean correctly to only call addLineInfo()
if there's a statement boundary (on x86, is_stmt most probably is
always true...).

MERGE TO STABLE


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@1209 a5019735-40e9-0310-863c-91ae7b9d1cf9