Randall Spangler | 95c4031 | 2011-03-09 15:54:16 -0800 | [diff] [blame] | 1 | /* Copyright (c) 2011 The Chromium OS Authors. All rights reserved. |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 2 | * Use of this source code is governed by a BSD-style license that can be |
| 3 | * found in the LICENSE file. |
| 4 | * |
| 5 | * Functions for loading a kernel from disk. |
| 6 | * (Firmware portion) |
| 7 | */ |
| 8 | |
| 9 | #include "vboot_kernel.h" |
| 10 | |
| 11 | #include "boot_device.h" |
| 12 | #include "cgptlib.h" |
Bill Richardson | 5deb67f | 2010-07-23 17:22:25 -0700 | [diff] [blame] | 13 | #include "cgptlib_internal.h" |
Randall Spangler | 95c4031 | 2011-03-09 15:54:16 -0800 | [diff] [blame] | 14 | #include "gbb_header.h" |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 15 | #include "load_kernel_fw.h" |
| 16 | #include "rollback_index.h" |
| 17 | #include "utility.h" |
Randall Spangler | 83c88cf | 2010-06-11 16:14:18 -0700 | [diff] [blame] | 18 | #include "vboot_common.h" |
| 19 | |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 20 | #define KBUF_SIZE 65536 /* Bytes to read at start of kernel partition */ |
Stefan Reinauer | 55db6a6 | 2011-03-15 16:23:41 -0700 | [diff] [blame] | 21 | #define LOWEST_TPM_VERSION 0xffffffff |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 22 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 23 | typedef enum BootMode { |
| 24 | kBootNormal, /* Normal firmware */ |
| 25 | kBootDev, /* Dev firmware AND dev switch is on */ |
| 26 | kBootRecovery /* Recovery firmware, regardless of dev switch position */ |
| 27 | } BootMode; |
| 28 | |
Randall Spangler | 83c88cf | 2010-06-11 16:14:18 -0700 | [diff] [blame] | 29 | |
| 30 | /* Allocates and reads GPT data from the drive. The sector_bytes and |
| 31 | * drive_sectors fields should be filled on input. The primary and |
| 32 | * secondary header and entries are filled on output. |
| 33 | * |
| 34 | * Returns 0 if successful, 1 if error. */ |
| 35 | int AllocAndReadGptData(GptData* gptdata) { |
| 36 | |
| 37 | uint64_t entries_sectors = TOTAL_ENTRIES_SIZE / gptdata->sector_bytes; |
| 38 | |
| 39 | /* No data to be written yet */ |
| 40 | gptdata->modified = 0; |
| 41 | |
| 42 | /* Allocate all buffers */ |
| 43 | gptdata->primary_header = (uint8_t*)Malloc(gptdata->sector_bytes); |
| 44 | gptdata->secondary_header = (uint8_t*)Malloc(gptdata->sector_bytes); |
| 45 | gptdata->primary_entries = (uint8_t*)Malloc(TOTAL_ENTRIES_SIZE); |
| 46 | gptdata->secondary_entries = (uint8_t*)Malloc(TOTAL_ENTRIES_SIZE); |
| 47 | |
| 48 | if (gptdata->primary_header == NULL || gptdata->secondary_header == NULL || |
| 49 | gptdata->primary_entries == NULL || gptdata->secondary_entries == NULL) |
| 50 | return 1; |
| 51 | |
| 52 | /* Read data from the drive, skipping the protective MBR */ |
| 53 | if (0 != BootDeviceReadLBA(1, 1, gptdata->primary_header)) |
| 54 | return 1; |
| 55 | if (0 != BootDeviceReadLBA(2, entries_sectors, gptdata->primary_entries)) |
| 56 | return 1; |
| 57 | if (0 != BootDeviceReadLBA(gptdata->drive_sectors - entries_sectors - 1, |
| 58 | entries_sectors, gptdata->secondary_entries)) |
| 59 | return 1; |
| 60 | if (0 != BootDeviceReadLBA(gptdata->drive_sectors - 1, |
| 61 | 1, gptdata->secondary_header)) |
| 62 | return 1; |
| 63 | |
| 64 | return 0; |
| 65 | } |
| 66 | |
| 67 | |
| 68 | /* Writes any changes for the GPT data back to the drive, then frees |
| 69 | * the buffers. |
| 70 | * |
| 71 | * Returns 0 if successful, 1 if error. */ |
| 72 | int WriteAndFreeGptData(GptData* gptdata) { |
| 73 | |
| 74 | uint64_t entries_sectors = TOTAL_ENTRIES_SIZE / gptdata->sector_bytes; |
| 75 | |
| 76 | if (gptdata->primary_header) { |
| 77 | if (gptdata->modified & GPT_MODIFIED_HEADER1) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 78 | VBDEBUG(("Updating GPT header 1\n")); |
Randall Spangler | 83c88cf | 2010-06-11 16:14:18 -0700 | [diff] [blame] | 79 | if (0 != BootDeviceWriteLBA(1, 1, gptdata->primary_header)) |
| 80 | return 1; |
| 81 | } |
| 82 | Free(gptdata->primary_header); |
| 83 | } |
| 84 | |
| 85 | if (gptdata->primary_entries) { |
| 86 | if (gptdata->modified & GPT_MODIFIED_ENTRIES1) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 87 | VBDEBUG(("Updating GPT entries 1\n")); |
Randall Spangler | 83c88cf | 2010-06-11 16:14:18 -0700 | [diff] [blame] | 88 | if (0 != BootDeviceWriteLBA(2, entries_sectors, |
| 89 | gptdata->primary_entries)) |
| 90 | return 1; |
| 91 | } |
| 92 | Free(gptdata->primary_entries); |
| 93 | } |
| 94 | |
| 95 | if (gptdata->secondary_entries) { |
| 96 | if (gptdata->modified & GPT_MODIFIED_ENTRIES2) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 97 | VBDEBUG(("Updating GPT header 2\n")); |
Randall Spangler | 83c88cf | 2010-06-11 16:14:18 -0700 | [diff] [blame] | 98 | if (0 != BootDeviceWriteLBA(gptdata->drive_sectors - entries_sectors - 1, |
| 99 | entries_sectors, gptdata->secondary_entries)) |
| 100 | return 1; |
| 101 | } |
| 102 | Free(gptdata->secondary_entries); |
| 103 | } |
| 104 | |
| 105 | if (gptdata->secondary_header) { |
| 106 | if (gptdata->modified & GPT_MODIFIED_HEADER2) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 107 | VBDEBUG(("Updating GPT entries 2\n")); |
Randall Spangler | 83c88cf | 2010-06-11 16:14:18 -0700 | [diff] [blame] | 108 | if (0 != BootDeviceWriteLBA(gptdata->drive_sectors - 1, 1, |
| 109 | gptdata->secondary_header)) |
| 110 | return 1; |
| 111 | } |
| 112 | Free(gptdata->secondary_header); |
| 113 | } |
| 114 | |
| 115 | /* Success */ |
| 116 | return 0; |
| 117 | } |
| 118 | |
vbendeb | 3ecaf77 | 2010-06-24 16:19:53 -0700 | [diff] [blame] | 119 | /* disable MSVC warning on const logical expression (as in } while(0);) */ |
| 120 | __pragma(warning(disable: 4127)) |
Randall Spangler | 83c88cf | 2010-06-11 16:14:18 -0700 | [diff] [blame] | 121 | |
Randall Spangler | bd529f0 | 2010-06-16 12:51:26 -0700 | [diff] [blame] | 122 | int LoadKernel(LoadKernelParams* params) { |
Randall Spangler | 95c4031 | 2011-03-09 15:54:16 -0800 | [diff] [blame] | 123 | VbSharedDataHeader* shared = (VbSharedDataHeader*)params->shared_data_blob; |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 124 | VbNvContext* vnc = params->nv_context; |
Randall Spangler | 95c4031 | 2011-03-09 15:54:16 -0800 | [diff] [blame] | 125 | GoogleBinaryBlockHeader* gbb = (GoogleBinaryBlockHeader*)params->gbb_data; |
Bill Richardson | e272940 | 2010-07-22 12:23:47 -0700 | [diff] [blame] | 126 | VbPublicKey* kernel_subkey; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 127 | GptData gpt; |
| 128 | uint64_t part_start, part_size; |
Bill Richardson | e272940 | 2010-07-22 12:23:47 -0700 | [diff] [blame] | 129 | uint64_t blba; |
| 130 | uint64_t kbuf_sectors; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 131 | uint8_t* kbuf = NULL; |
| 132 | int found_partitions = 0; |
| 133 | int good_partition = -1; |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 134 | int good_partition_key_block_valid = 0; |
Randall Spangler | 6668028 | 2010-08-16 12:33:44 -0700 | [diff] [blame] | 135 | uint32_t tpm_version = 0; |
Stefan Reinauer | 55db6a6 | 2011-03-15 16:23:41 -0700 | [diff] [blame] | 136 | uint64_t lowest_version = LOWEST_TPM_VERSION; |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 137 | int rec_switch, dev_switch; |
| 138 | BootMode boot_mode; |
Randall Spangler | 99ca346 | 2011-03-15 15:28:31 -0700 | [diff] [blame] | 139 | uint32_t test_err = 0; |
Randall Spangler | 7a786b7 | 2010-07-08 13:29:42 -0700 | [diff] [blame] | 140 | uint32_t status; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 141 | |
Randall Spangler | 0222355 | 2011-03-15 19:20:25 -0700 | [diff] [blame^] | 142 | int retval = LOAD_KERNEL_RECOVERY; |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 143 | int recovery = VBNV_RECOVERY_RO_UNSPECIFIED; |
| 144 | |
| 145 | /* Setup NV storage */ |
| 146 | VbNvSetup(vnc); |
| 147 | |
Bill Richardson | e272940 | 2010-07-22 12:23:47 -0700 | [diff] [blame] | 148 | /* Sanity Checks */ |
| 149 | if (!params || |
Bill Richardson | e272940 | 2010-07-22 12:23:47 -0700 | [diff] [blame] | 150 | !params->bytes_per_lba || |
| 151 | !params->ending_lba || |
| 152 | !params->kernel_buffer || |
| 153 | !params->kernel_buffer_size) { |
| 154 | VBDEBUG(("LoadKernel() called with invalid params\n")); |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 155 | goto LoadKernelExit; |
Bill Richardson | e272940 | 2010-07-22 12:23:47 -0700 | [diff] [blame] | 156 | } |
| 157 | |
Randall Spangler | 99ca346 | 2011-03-15 15:28:31 -0700 | [diff] [blame] | 158 | /* Handle test errors */ |
| 159 | VbNvGet(vnc, VBNV_TEST_ERROR_FUNC, &test_err); |
| 160 | if (VBNV_TEST_ERROR_LOAD_KERNEL == test_err) { |
| 161 | /* Get error code */ |
| 162 | VbNvGet(vnc, VBNV_TEST_ERROR_NUM, &test_err); |
| 163 | /* Clear test params so we don't repeat the error */ |
| 164 | VbNvSet(vnc, VBNV_TEST_ERROR_FUNC, 0); |
| 165 | VbNvSet(vnc, VBNV_TEST_ERROR_NUM, 0); |
| 166 | /* Handle error codes */ |
| 167 | switch (test_err) { |
| 168 | case LOAD_KERNEL_RECOVERY: |
| 169 | recovery = VBNV_RECOVERY_RW_TEST_LK; |
| 170 | goto LoadKernelExit; |
| 171 | case LOAD_KERNEL_NOT_FOUND: |
| 172 | case LOAD_KERNEL_INVALID: |
| 173 | case LOAD_KERNEL_REBOOT: |
| 174 | retval = test_err; |
| 175 | goto LoadKernelExit; |
| 176 | default: |
| 177 | break; |
| 178 | } |
| 179 | } |
| 180 | |
Bill Richardson | e272940 | 2010-07-22 12:23:47 -0700 | [diff] [blame] | 181 | /* Initialization */ |
Bill Richardson | e272940 | 2010-07-22 12:23:47 -0700 | [diff] [blame] | 182 | blba = params->bytes_per_lba; |
| 183 | kbuf_sectors = KBUF_SIZE / blba; |
Randall Spangler | 4bb5e4b | 2010-08-19 09:05:22 -0700 | [diff] [blame] | 184 | if (0 == kbuf_sectors) { |
| 185 | VBDEBUG(("LoadKernel() called with sector size > KBUF_SIZE\n")); |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 186 | goto LoadKernelExit; |
Randall Spangler | 4bb5e4b | 2010-08-19 09:05:22 -0700 | [diff] [blame] | 187 | } |
| 188 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 189 | rec_switch = (BOOT_FLAG_RECOVERY & params->boot_flags ? 1 : 0); |
| 190 | dev_switch = (BOOT_FLAG_DEVELOPER & params->boot_flags ? 1 : 0); |
| 191 | |
| 192 | if (rec_switch) |
| 193 | boot_mode = kBootRecovery; |
Randall Spangler | 8478ece | 2011-03-03 11:00:17 -0800 | [diff] [blame] | 194 | else if (BOOT_FLAG_DEV_FIRMWARE & params->boot_flags) { |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 195 | if (!dev_switch) { |
| 196 | /* Dev firmware should be signed such that it never boots with the dev |
| 197 | * switch is off; so something is terribly wrong. */ |
| 198 | VBDEBUG(("LoadKernel() called with dev firmware but dev switch off\n")); |
| 199 | recovery = VBNV_RECOVERY_RW_DEV_MISMATCH; |
| 200 | goto LoadKernelExit; |
| 201 | } |
| 202 | boot_mode = kBootDev; |
Randall Spangler | 8478ece | 2011-03-03 11:00:17 -0800 | [diff] [blame] | 203 | } else { |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 204 | /* Normal firmware */ |
| 205 | boot_mode = kBootNormal; |
| 206 | dev_switch = 0; /* Always do a fully verified boot */ |
Randall Spangler | a8e0f94 | 2011-02-14 11:12:09 -0800 | [diff] [blame] | 207 | } |
Bill Richardson | e272940 | 2010-07-22 12:23:47 -0700 | [diff] [blame] | 208 | |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 209 | /* Clear output params in case we fail */ |
| 210 | params->partition_number = 0; |
| 211 | params->bootloader_address = 0; |
| 212 | params->bootloader_size = 0; |
| 213 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 214 | if (kBootRecovery == boot_mode) { |
Randall Spangler | 95c4031 | 2011-03-09 15:54:16 -0800 | [diff] [blame] | 215 | /* Initialize the shared data structure, since LoadFirmware() didn't do it |
| 216 | * for us. */ |
| 217 | if (0 != VbSharedDataInit(shared, params->shared_data_size)) { |
| 218 | /* Error initializing the shared data, but we can keep going. We just |
| 219 | * can't use the shared data. */ |
| 220 | VBDEBUG(("Shared data init error\n")); |
| 221 | params->shared_data_size = 0; |
| 222 | shared = NULL; |
| 223 | } |
| 224 | |
| 225 | /* Use the recovery key to verify the kernel */ |
| 226 | kernel_subkey = (VbPublicKey*)((uint8_t*)gbb + gbb->recovery_key_offset); |
| 227 | |
| 228 | /* Let the TPM know if we're in recovery mode */ |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 229 | if (0 != RollbackKernelRecovery(dev_switch)) { |
Randall Spangler | 63dffcb | 2010-08-05 15:13:14 -0700 | [diff] [blame] | 230 | VBDEBUG(("Error setting up TPM for recovery kernel\n")); |
| 231 | /* Ignore return code, since we need to boot recovery mode to |
| 232 | * fix the TPM. */ |
Randall Spangler | 1078838 | 2010-06-23 15:35:31 -0700 | [diff] [blame] | 233 | } |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 234 | } else { |
Randall Spangler | 95c4031 | 2011-03-09 15:54:16 -0800 | [diff] [blame] | 235 | /* Use the kernel subkey passed from LoadFirmware(). */ |
| 236 | kernel_subkey = &shared->kernel_subkey; |
| 237 | |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 238 | /* Read current kernel key index from TPM. Assumes TPM is already |
| 239 | * initialized. */ |
Randall Spangler | 6668028 | 2010-08-16 12:33:44 -0700 | [diff] [blame] | 240 | status = RollbackKernelRead(&tpm_version); |
Randall Spangler | 7a786b7 | 2010-07-08 13:29:42 -0700 | [diff] [blame] | 241 | if (0 != status) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 242 | VBDEBUG(("Unable to get kernel versions from TPM\n")); |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 243 | if (status == TPM_E_MUST_REBOOT) |
| 244 | retval = LOAD_KERNEL_REBOOT; |
| 245 | else |
| 246 | recovery = VBNV_RECOVERY_RW_TPM_ERROR; |
| 247 | goto LoadKernelExit; |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 248 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 249 | } |
| 250 | |
| 251 | do { |
| 252 | /* Read GPT data */ |
Randall Spangler | beb5bae | 2010-06-21 16:33:26 -0700 | [diff] [blame] | 253 | gpt.sector_bytes = (uint32_t)blba; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 254 | gpt.drive_sectors = params->ending_lba + 1; |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 255 | if (0 != AllocAndReadGptData(&gpt)) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 256 | VBDEBUG(("Unable to read GPT data\n")); |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 257 | break; |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 258 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 259 | |
| 260 | /* Initialize GPT library */ |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 261 | if (GPT_SUCCESS != GptInit(&gpt)) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 262 | VBDEBUG(("Error parsing GPT\n")); |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 263 | break; |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 264 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 265 | |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 266 | /* Allocate kernel header buffers */ |
| 267 | kbuf = (uint8_t*)Malloc(KBUF_SIZE); |
| 268 | if (!kbuf) |
| 269 | break; |
| 270 | |
| 271 | /* Loop over candidate kernel partitions */ |
| 272 | while (GPT_SUCCESS == GptNextKernelEntry(&gpt, &part_start, &part_size)) { |
| 273 | VbKeyBlockHeader* key_block; |
| 274 | VbKernelPreambleHeader* preamble; |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 275 | RSAPublicKey* data_key = NULL; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 276 | uint64_t key_version; |
Randall Spangler | 6668028 | 2010-08-16 12:33:44 -0700 | [diff] [blame] | 277 | uint64_t combined_version; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 278 | uint64_t body_offset; |
Randall Spangler | 4bb5e4b | 2010-08-19 09:05:22 -0700 | [diff] [blame] | 279 | uint64_t body_offset_sectors; |
| 280 | uint64_t body_sectors; |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 281 | int key_block_valid = 1; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 282 | |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 283 | VBDEBUG(("Found kernel entry at %" PRIu64 " size %" PRIu64 "\n", |
| 284 | part_start, part_size)); |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 285 | |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 286 | /* Found at least one kernel partition. */ |
| 287 | found_partitions++; |
| 288 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 289 | /* Read the first part of the kernel partition. */ |
Randall Spangler | 77ae389 | 2010-09-09 17:37:51 -0700 | [diff] [blame] | 290 | if (part_size < kbuf_sectors) { |
| 291 | VBDEBUG(("Partition too small to hold kernel.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 292 | goto bad_kernel; |
Randall Spangler | 77ae389 | 2010-09-09 17:37:51 -0700 | [diff] [blame] | 293 | } |
| 294 | |
| 295 | if (0 != BootDeviceReadLBA(part_start, kbuf_sectors, kbuf)) { |
| 296 | VBDEBUG(("Unable to read start of partition.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 297 | goto bad_kernel; |
Randall Spangler | 77ae389 | 2010-09-09 17:37:51 -0700 | [diff] [blame] | 298 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 299 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 300 | /* Verify the key block. */ |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 301 | key_block = (VbKeyBlockHeader*)kbuf; |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 302 | if (0 != KeyBlockVerify(key_block, KBUF_SIZE, kernel_subkey, 0)) { |
| 303 | VBDEBUG(("Verifying key block signature failed.\n")); |
| 304 | key_block_valid = 0; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 305 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 306 | /* If we're not in developer mode, this kernel is bad. */ |
| 307 | if (kBootDev != boot_mode) |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 308 | goto bad_kernel; |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 309 | |
| 310 | /* In developer mode, we can continue if the SHA-512 hash of the key |
| 311 | * block is valid. */ |
| 312 | if (0 != KeyBlockVerify(key_block, KBUF_SIZE, kernel_subkey, 1)) { |
| 313 | VBDEBUG(("Verifying key block hash failed.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 314 | goto bad_kernel; |
Randall Spangler | ae029d9 | 2010-07-19 18:26:35 -0700 | [diff] [blame] | 315 | } |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 316 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 317 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 318 | /* Check the key block flags against the current boot mode. */ |
| 319 | if (!(key_block->key_block_flags & |
| 320 | (dev_switch ? KEY_BLOCK_FLAG_DEVELOPER_1 : |
| 321 | KEY_BLOCK_FLAG_DEVELOPER_0))) { |
| 322 | VBDEBUG(("Key block developer flag mismatch.\n")); |
| 323 | key_block_valid = 0; |
| 324 | } |
| 325 | if (!(key_block->key_block_flags & |
| 326 | (rec_switch ? KEY_BLOCK_FLAG_RECOVERY_1 : |
| 327 | KEY_BLOCK_FLAG_RECOVERY_0))) { |
| 328 | VBDEBUG(("Key block recovery flag mismatch.\n")); |
| 329 | key_block_valid = 0; |
| 330 | } |
| 331 | |
| 332 | /* Check for rollback of key version except in recovery mode. */ |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 333 | key_version = key_block->data_key.key_version; |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 334 | if (kBootRecovery != boot_mode) { |
| 335 | if (key_version < (tpm_version >> 16)) { |
| 336 | VBDEBUG(("Key version too old.\n")); |
| 337 | key_block_valid = 0; |
| 338 | } |
| 339 | } |
| 340 | |
| 341 | /* If we're not in developer mode, require the key block to be valid. */ |
| 342 | if (kBootDev != boot_mode && !key_block_valid) { |
| 343 | VBDEBUG(("Key block is invalid.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 344 | goto bad_kernel; |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 345 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 346 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 347 | /* Get the key for preamble/data verification from the key block. */ |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 348 | data_key = PublicKeyToRSA(&key_block->data_key); |
Randall Spangler | 77ae389 | 2010-09-09 17:37:51 -0700 | [diff] [blame] | 349 | if (!data_key) { |
| 350 | VBDEBUG(("Data key bad.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 351 | goto bad_kernel; |
Randall Spangler | 77ae389 | 2010-09-09 17:37:51 -0700 | [diff] [blame] | 352 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 353 | |
| 354 | /* Verify the preamble, which follows the key block */ |
| 355 | preamble = (VbKernelPreambleHeader*)(kbuf + key_block->key_block_size); |
Randall Spangler | 87c13d8 | 2010-07-19 10:35:40 -0700 | [diff] [blame] | 356 | if ((0 != VerifyKernelPreamble(preamble, |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 357 | KBUF_SIZE - key_block->key_block_size, |
| 358 | data_key))) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 359 | VBDEBUG(("Preamble verification failed.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 360 | goto bad_kernel; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 361 | } |
| 362 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 363 | /* If the key block is valid and we're not in recovery mode, check for |
| 364 | * rollback of the kernel version. */ |
Randall Spangler | 6668028 | 2010-08-16 12:33:44 -0700 | [diff] [blame] | 365 | combined_version = ((key_version << 16) | |
| 366 | (preamble->kernel_version & 0xFFFF)); |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 367 | if (key_block_valid && kBootRecovery != boot_mode) { |
| 368 | if (combined_version < tpm_version) { |
| 369 | VBDEBUG(("Kernel version too low.\n")); |
| 370 | /* If we're not in developer mode, kernel version must be valid. */ |
| 371 | if (kBootDev != boot_mode) |
| 372 | goto bad_kernel; |
| 373 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 374 | } |
| 375 | |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 376 | VBDEBUG(("Kernel preamble is good.\n")); |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 377 | |
Randall Spangler | 6668028 | 2010-08-16 12:33:44 -0700 | [diff] [blame] | 378 | /* Check for lowest version from a valid header. */ |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 379 | if (key_block_valid && lowest_version > combined_version) |
Randall Spangler | 6668028 | 2010-08-16 12:33:44 -0700 | [diff] [blame] | 380 | lowest_version = combined_version; |
Stefan Reinauer | 55db6a6 | 2011-03-15 16:23:41 -0700 | [diff] [blame] | 381 | else { |
| 382 | VBDEBUG(("Key block valid: %d\n", key_block_valid)); |
| 383 | VBDEBUG(("Combined version: %" PRIu64 "\n", combined_version)); |
| 384 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 385 | |
| 386 | /* If we already have a good kernel, no need to read another |
| 387 | * one; we only needed to look at the versions to check for |
Randall Spangler | 77ae389 | 2010-09-09 17:37:51 -0700 | [diff] [blame] | 388 | * rollback. So skip to the next kernel preamble. */ |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 389 | if (-1 != good_partition) |
Randall Spangler | 77ae389 | 2010-09-09 17:37:51 -0700 | [diff] [blame] | 390 | continue; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 391 | |
| 392 | /* Verify body load address matches what we expect */ |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 393 | if ((preamble->body_load_address != (size_t)params->kernel_buffer) && |
| 394 | !(params->boot_flags & BOOT_FLAG_SKIP_ADDR_CHECK)) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 395 | VBDEBUG(("Wrong body load address.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 396 | goto bad_kernel; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 397 | } |
| 398 | |
| 399 | /* Verify kernel body starts at a multiple of the sector size. */ |
| 400 | body_offset = key_block->key_block_size + preamble->preamble_size; |
| 401 | if (0 != body_offset % blba) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 402 | VBDEBUG(("Kernel body not at multiple of sector size.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 403 | goto bad_kernel; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 404 | } |
Randall Spangler | 4bb5e4b | 2010-08-19 09:05:22 -0700 | [diff] [blame] | 405 | body_offset_sectors = body_offset / blba; |
| 406 | |
| 407 | /* Verify kernel body fits in the buffer */ |
| 408 | body_sectors = (preamble->body_signature.data_size + blba - 1) / blba; |
| 409 | if (body_sectors * blba > params->kernel_buffer_size) { |
| 410 | VBDEBUG(("Kernel body doesn't fit in memory.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 411 | goto bad_kernel; |
Randall Spangler | 4bb5e4b | 2010-08-19 09:05:22 -0700 | [diff] [blame] | 412 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 413 | |
| 414 | /* Verify kernel body fits in the partition */ |
Randall Spangler | 4bb5e4b | 2010-08-19 09:05:22 -0700 | [diff] [blame] | 415 | if (body_offset_sectors + body_sectors > part_size) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 416 | VBDEBUG(("Kernel body doesn't fit in partition.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 417 | goto bad_kernel; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 418 | } |
| 419 | |
| 420 | /* Read the kernel data */ |
Randall Spangler | 6078ca3 | 2010-10-18 15:49:28 -0700 | [diff] [blame] | 421 | VBPERFSTART("VB_RKD"); |
Randall Spangler | 4bb5e4b | 2010-08-19 09:05:22 -0700 | [diff] [blame] | 422 | if (0 != BootDeviceReadLBA(part_start + body_offset_sectors, |
| 423 | body_sectors, |
| 424 | params->kernel_buffer)) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 425 | VBDEBUG(("Unable to read kernel data.\n")); |
Randall Spangler | 6078ca3 | 2010-10-18 15:49:28 -0700 | [diff] [blame] | 426 | VBPERFEND("VB_RKD"); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 427 | goto bad_kernel; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 428 | } |
Randall Spangler | 6078ca3 | 2010-10-18 15:49:28 -0700 | [diff] [blame] | 429 | VBPERFEND("VB_RKD"); |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 430 | |
| 431 | /* Verify kernel data */ |
| 432 | if (0 != VerifyData((const uint8_t*)params->kernel_buffer, |
Randall Spangler | 87c13d8 | 2010-07-19 10:35:40 -0700 | [diff] [blame] | 433 | params->kernel_buffer_size, |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 434 | &preamble->body_signature, data_key)) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 435 | VBDEBUG(("Kernel data verification failed.\n")); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 436 | goto bad_kernel; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 437 | } |
| 438 | |
| 439 | /* Done with the kernel signing key, so can free it now */ |
| 440 | RSAPublicKeyFree(data_key); |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 441 | data_key = NULL; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 442 | |
| 443 | /* If we're still here, the kernel is valid. */ |
| 444 | /* Save the first good partition we find; that's the one we'll boot */ |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 445 | VBDEBUG(("Partition is good.\n")); |
| 446 | good_partition_key_block_valid = key_block_valid; |
Randall Spangler | beb5bae | 2010-06-21 16:33:26 -0700 | [diff] [blame] | 447 | /* TODO: GPT partitions start at 1, but cgptlib starts them at 0. |
| 448 | * Adjust here, until cgptlib is fixed. */ |
| 449 | good_partition = gpt.current_kernel + 1; |
Randall Spangler | b9d60a5 | 2010-06-23 12:43:01 -0700 | [diff] [blame] | 450 | params->partition_number = gpt.current_kernel + 1; |
Bill Richardson | 5deb67f | 2010-07-23 17:22:25 -0700 | [diff] [blame] | 451 | GetCurrentKernelUniqueGuid(&gpt, ¶ms->partition_guid); |
Randall Spangler | 63dffcb | 2010-08-05 15:13:14 -0700 | [diff] [blame] | 452 | /* TODO: GetCurrentKernelUniqueGuid() should take a destination size, or |
| 453 | * the dest should be a struct, so we know it's big enough. */ |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 454 | params->bootloader_address = preamble->bootloader_address; |
| 455 | params->bootloader_size = preamble->bootloader_size; |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 456 | |
| 457 | /* Update GPT to note this is the kernel we're trying */ |
| 458 | GptUpdateKernelEntry(&gpt, GPT_UPDATE_ENTRY_TRY); |
| 459 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 460 | /* If we're in recovery mode or we're about to boot a dev-signed kernel, |
| 461 | * there's no rollback protection, so we can stop at the first valid |
| 462 | * kernel. */ |
| 463 | if (kBootRecovery == boot_mode || !key_block_valid) { |
| 464 | VBDEBUG(("In recovery mode or dev-signed kernel\n")); |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 465 | break; |
Randall Spangler | beb5bae | 2010-06-21 16:33:26 -0700 | [diff] [blame] | 466 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 467 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 468 | /* Otherwise, we do care about the key index in the TPM. If the good |
| 469 | * partition's key version is the same as the tpm, then the TPM doesn't |
| 470 | * need updating; we can stop now. Otherwise, we'll check all the other |
| 471 | * headers to see if they contain a newer key. */ |
Randall Spangler | 6668028 | 2010-08-16 12:33:44 -0700 | [diff] [blame] | 472 | if (combined_version == tpm_version) { |
| 473 | VBDEBUG(("Same kernel version\n")); |
Randall Spangler | 695cd16 | 2010-06-15 23:38:23 -0700 | [diff] [blame] | 474 | break; |
Randall Spangler | beb5bae | 2010-06-21 16:33:26 -0700 | [diff] [blame] | 475 | } |
Randall Spangler | 741d2b2 | 2010-08-20 16:37:12 -0700 | [diff] [blame] | 476 | |
| 477 | /* Continue, so that we skip the error handling code below */ |
| 478 | continue; |
| 479 | |
| 480 | bad_kernel: |
| 481 | /* Handle errors parsing this kernel */ |
| 482 | if (NULL != data_key) |
| 483 | RSAPublicKeyFree(data_key); |
| 484 | |
| 485 | VBDEBUG(("Marking kernel as invalid.\n")); |
| 486 | GptUpdateKernelEntry(&gpt, GPT_UPDATE_ENTRY_BAD); |
| 487 | |
| 488 | |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 489 | } /* while(GptNextKernelEntry) */ |
| 490 | } while(0); |
| 491 | |
| 492 | /* Free kernel buffer */ |
| 493 | if (kbuf) |
| 494 | Free(kbuf); |
| 495 | |
| 496 | /* Write and free GPT data */ |
| 497 | WriteAndFreeGptData(&gpt); |
| 498 | |
| 499 | /* Handle finding a good partition */ |
| 500 | if (good_partition >= 0) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 501 | VBDEBUG(("Good_partition >= 0\n")); |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 502 | |
| 503 | /* See if we need to update the TPM */ |
Randall Spangler | c324fbf | 2011-03-04 12:19:25 -0800 | [diff] [blame] | 504 | if (kBootRecovery != boot_mode && good_partition_key_block_valid) { |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 505 | /* We only update the TPM in normal and developer boot modes. In |
| 506 | * developer mode, we only advanced lowest_version for kernels with valid |
| 507 | * key blocks, and didn't count self-signed key blocks. In recovery |
| 508 | * mode, the TPM stays PP-unlocked, so anything we write gets blown away |
| 509 | * by the firmware when we go back to normal mode. */ |
| 510 | VBDEBUG(("Boot_flags = not recovery\n")); |
Stefan Reinauer | 55db6a6 | 2011-03-15 16:23:41 -0700 | [diff] [blame] | 511 | |
| 512 | if ((lowest_version > tpm_version) && |
| 513 | (lowest_version != LOWEST_TPM_VERSION)) { |
Randall Spangler | 6668028 | 2010-08-16 12:33:44 -0700 | [diff] [blame] | 514 | status = RollbackKernelWrite((uint32_t)lowest_version); |
Randall Spangler | 7a786b7 | 2010-07-08 13:29:42 -0700 | [diff] [blame] | 515 | if (0 != status) { |
Randall Spangler | e2ec984 | 2010-06-23 21:17:07 -0700 | [diff] [blame] | 516 | VBDEBUG(("Error writing kernel versions to TPM.\n")); |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 517 | if (status == TPM_E_MUST_REBOOT) |
| 518 | retval = LOAD_KERNEL_REBOOT; |
| 519 | else |
| 520 | recovery = VBNV_RECOVERY_RW_TPM_ERROR; |
| 521 | goto LoadKernelExit; |
Randall Spangler | 1078838 | 2010-06-23 15:35:31 -0700 | [diff] [blame] | 522 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 523 | } |
| 524 | } |
| 525 | |
Randall Spangler | 63dffcb | 2010-08-05 15:13:14 -0700 | [diff] [blame] | 526 | /* Lock the kernel versions */ |
| 527 | status = RollbackKernelLock(); |
| 528 | if (0 != status) { |
| 529 | VBDEBUG(("Error locking kernel versions.\n")); |
| 530 | /* Don't reboot to recovery mode if we're already there */ |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 531 | if (kBootRecovery != boot_mode) { |
| 532 | if (status == TPM_E_MUST_REBOOT) |
| 533 | retval = LOAD_KERNEL_REBOOT; |
| 534 | else |
| 535 | recovery = VBNV_RECOVERY_RW_TPM_ERROR; |
| 536 | goto LoadKernelExit; |
| 537 | } |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 538 | } |
| 539 | |
| 540 | /* Success! */ |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 541 | retval = LOAD_KERNEL_SUCCESS; |
Randall Spangler | 0222355 | 2011-03-15 19:20:25 -0700 | [diff] [blame^] | 542 | } else { |
| 543 | /* TODO: differentiate between finding an invalid kernel |
| 544 | * (found_partitions>0) and not finding one at all. Right now we |
| 545 | * treat them the same, and return LOAD_KERNEL_INVALID for both. */ |
| 546 | retval = LOAD_KERNEL_INVALID; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 547 | } |
| 548 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 549 | LoadKernelExit: |
| 550 | |
| 551 | /* Save whether the good partition's key block was fully verified */ |
| 552 | VbNvSet(vnc, VBNV_FW_VERIFIED_KERNEL_KEY, good_partition_key_block_valid); |
| 553 | |
| 554 | /* Store recovery request, if any, then tear down non-volatile storage */ |
| 555 | VbNvSet(vnc, VBNV_RECOVERY_REQUEST, LOAD_KERNEL_RECOVERY == retval ? |
| 556 | recovery : VBNV_RECOVERY_NOT_REQUESTED); |
| 557 | VbNvTeardown(vnc); |
| 558 | |
Randall Spangler | 95c4031 | 2011-03-09 15:54:16 -0800 | [diff] [blame] | 559 | /* Store how much shared data we used, if any */ |
| 560 | if (shared) |
| 561 | params->shared_data_size = shared->data_used; |
| 562 | |
Randall Spangler | 640fb51 | 2011-03-03 10:11:17 -0800 | [diff] [blame] | 563 | return retval; |
Randall Spangler | d183644 | 2010-06-10 09:59:04 -0700 | [diff] [blame] | 564 | } |