commit 13b65504d1604b0e8336beddc38b527727219384
author Dave Houlton <daveh@lunarg.com> Wed May 23 13:35:24 2018 -0600
committer Dave Houlton <daveh@lunarg.com> Tue May 29 10:18:56 2018 -0600
tree 70d4c6d40136ffeaabc2cb14b03a9dc0a3ebce49
parent 413a67888d9a072f6196081149f85405c6a45ec3

layers: parameter validation const refs

Change-Id: Ia1adab9fc2d38182cf4a798a68eb5a5c2fb48438

layers/parameter_validation_utils.cpp

diff --git a/layers/parameter_validation_utils.cpp b/layers/parameter_validation_utils.cpp
index 4aba85c..295f1db 100644
--- a/layers/parameter_validation_utils.cpp
+++ b/layers/parameter_validation_utils.cpp
@@ -150,7 +150,7 @@
 }
 
 static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
-                                      const char *parameter_name, std::string error_code, bool optional = false) {
+                                      const char *parameter_name, const std::string &error_code, bool optional = false) {
     bool skip = false;
 
     if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
@@ -171,8 +171,8 @@
 }
 
 static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
-                                  const char *cmd_name, const char *array_parameter_name, std::string unique_error_code,
-                                  std::string valid_error_code, bool optional = false) {
+                                  const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
+                                  const std::string &valid_error_code, bool optional = false) {
     bool skip = false;
     if (queue_families) {
         std::unordered_set<uint32_t> set;
@@ -216,8 +216,8 @@
 }
 
 template <typename ExtensionState>
-static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions, std::string vuid,
-                                    const char *extension_type, const char *extension_name) {
+static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
+                                    const std::string &vuid, const char *extension_type, const char *extension_name) {
     bool skip = false;
     if (!extension_name) {
         return skip;  // Robust to invalid char *