commit 2141f657153761aa8a5e4e0049e7f2d403b1384a
author Mark Lobodzinski <mark@lunarg.com> Mon Sep 07 13:59:43 2015 -0600
committer Mark Lobodzinski <mark@lunarg.com> Thu Sep 10 11:20:57 2015 -0600
tree ae8a05591db726a41f586a4282a569d12bb8c0d9
parent bafcdf3e8f8714b8e237cb7b43a9c4055c5cd58a

vulkan.h: Change return types of some functions to void

Functions that should be thought of as "impossible to fail in the face
of valid parameters" have had their return types changed to void.
This includes all of the vkDestroy functions, vkFreeMemory, and vkUnmapMemory.
vkUpdateDescriptorSets is also included, because of the frequency the function
is expected to be called.

tests/vktestbinding.cpp

diff --git a/tests/vktestbinding.cpp b/tests/vktestbinding.cpp
index f5ee736..867ae18 100644
--- a/tests/vktestbinding.cpp
+++ b/tests/vktestbinding.cpp
@@ -35,11 +35,11 @@
             NonDispHandle::init(dev.handle(), handle);                              \
     } while (0)
 
-#define NON_DISPATCHABLE_HANDLE_DTOR(cls, destroy_func)                        \
+#define NON_DISPATCHABLE_HANDLE_DTOR(cls, destroy_func)                             \
     cls::~cls()                                                                     \
     {                                                                               \
         if (initialized())                                                          \
-            EXPECT(destroy_func(device(), handle()) == VK_SUCCESS);    \
+            destroy_func(device(), handle());                                       \
     }
 
 #define STRINGIFY(x) #x
@@ -263,7 +263,7 @@
         queues_[i].clear();
     }
 
-    EXPECT(vkDestroyDevice(handle()) == VK_SUCCESS);
+    vkDestroyDevice(handle());
 }
 
 void Device::init(std::vector<const char *> &layers, std::vector<const char *> &extensions)
@@ -391,9 +391,9 @@
     return err;
 }
 
-VkResult Device::update_descriptor_sets(const std::vector<VkWriteDescriptorSet> &writes, const std::vector<VkCopyDescriptorSet> &copies)
+void Device::update_descriptor_sets(const std::vector<VkWriteDescriptorSet> &writes, const std::vector<VkCopyDescriptorSet> &copies)
 {
-    return vkUpdateDescriptorSets(handle(), writes.size(), writes.data(), copies.size(), copies.data());
+    vkUpdateDescriptorSets(handle(), writes.size(), writes.data(), copies.size(), copies.data());
 }
 
 void Queue::submit(const std::vector<const CmdBuffer *> &cmds, Fence &fence)
@@ -431,7 +431,7 @@
 DeviceMemory::~DeviceMemory()
 {
     if (initialized())
-        EXPECT(vkFreeMemory(device(), handle()) == VK_SUCCESS);
+        vkFreeMemory(device(), handle());
 }
 
 void DeviceMemory::init(const Device &dev, const VkMemoryAllocInfo &info)
@@ -459,7 +459,7 @@
 
 void DeviceMemory::unmap() const
 {
-    EXPECT(vkUnmapMemory(device(), handle()) == VK_SUCCESS);
+    vkUnmapMemory(device(), handle());
 }
 
 NON_DISPATCHABLE_HANDLE_DTOR(Fence, vkDestroyFence)
@@ -830,7 +830,7 @@
 CmdBuffer::~CmdBuffer()
 {
     if (initialized())
-        EXPECT(vkDestroyCommandBuffer(dev_handle_, handle()) == VK_SUCCESS);
+        vkDestroyCommandBuffer(dev_handle_, handle());
 }
 
 void CmdBuffer::init(const Device &dev, const VkCmdBufferCreateInfo &info)