commit 23168fbad5126d4440b2be76ee28238a0e817779
author Mark Lobodzinski <mark@lunarg.com> Tue May 09 08:21:15 2017 -0600
committer Mark Lobodzinski <mark@lunarg.com> Tue May 09 15:29:31 2017 -0600
tree 93bc290b6d71ccd98c7cdc7e8b2340a3bd4a84b9
parent 9f34085a3c766b96dc3122b9f8a36ae874d00f1a

layers: LX673, CreateWin32Surface Null HWND check

Added NULL check to parameter validation, and assigned VU2505.
All we can do is check for Null. Apparently, hInstance CAN be NULL.

Change-Id: Ica5ead0514b7435ea9428dbd0018f53ff25462fd

layers/parameter_validation.cpp

diff --git a/layers/parameter_validation.cpp b/layers/parameter_validation.cpp
index 1991216..1cdfad1 100644
--- a/layers/parameter_validation.cpp
+++ b/layers/parameter_validation.cpp
@@ -5306,6 +5306,12 @@
 
     skip |= require_instance_extension(instance, &InstanceExtensions::khr_win32_surface, "vkCreateWin32SurfaceKHR",
                                        VK_KHR_WIN32_SURFACE_EXTENSION_NAME);
+    if (pCreateInfo->hwnd == nullptr) {
+        skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__,
+                        VALIDATION_ERROR_02505, LayerName,
+                        "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL. %s",
+                        validation_error_map[VALIDATION_ERROR_02505]);
+    }
 
     skip |= parameter_validation_vkCreateWin32SurfaceKHR(my_data->report_data, pCreateInfo, pAllocator, pSurface);