scripts:Exceptions for duplicate unique ids
Added a number of exceptions for duplicate uses of unique error enums
that are valid. Also added some comments to a few cases that need new
unique ids.
diff --git a/layers/descriptor_sets.cpp b/layers/descriptor_sets.cpp
index ccfad82..902a71c 100644
--- a/layers/descriptor_sets.cpp
+++ b/layers/descriptor_sets.cpp
@@ -596,7 +596,7 @@
std::string *error_msg) {
// Verify idle ds
if (in_use.load()) {
- // TODO : Re-using Allocate Idle error code, need copy update idle error code
+ // TODO : Re-using Free Idle error code, need copy update idle error code
*error_code = VALIDATION_ERROR_00919;
std::stringstream error_str;
error_str << "Cannot call vkUpdateDescriptorSets() to perform copy update on descriptor set " << set_
@@ -763,6 +763,8 @@
format = image_node->createInfo.format;
usage = image_node->createInfo.usage;
// Validate that memory is bound to image
+ // TODO: This should have its own valid usage id apart from 2524 which is from CreateImageView case. The only
+ // the error here occurs is if memory bound to a created imageView has been freed.
if (ValidateMemoryIsBoundToImage(dev_data, image_node, "vkUpdateDescriptorSets()", VALIDATION_ERROR_02524)) {
*error_code = VALIDATION_ERROR_02524;
*error_msg = "No memory bound to image.";
@@ -1169,7 +1171,7 @@
UNIQUE_VALIDATION_ERROR_CODE *error_code, std::string *error_msg) {
// Verify idle ds
if (in_use.load()) {
- // TODO : Re-using Allocate Idle error code, need write update idle error code
+ // TODO : Re-using Free Idle error code, need write update idle error code
*error_code = VALIDATION_ERROR_00919;
std::stringstream error_str;
error_str << "Cannot call vkUpdateDescriptorSets() to perform write update on descriptor set " << set_