build: Enable declaration hiding warning on Windows
Fixes #1388
Turn on the Windows compiler option (4456) to report
hidden declarations.
Fix all places where this was occurring.
Change-Id: I3346d87da8b70d6299c206fcac68520a091ed1a6
diff --git a/layers/threading.h b/layers/threading.h
index 481acd4..67bb0d6 100644
--- a/layers/threading.h
+++ b/layers/threading.h
@@ -101,10 +101,10 @@
counter_condition.wait(lock);
}
// There is now no current use of the object. Record writer thread.
- struct object_use_data *use_data = &uses[object];
- use_data->thread = tid;
- use_data->reader_count = 0;
- use_data->writer_count = 1;
+ struct object_use_data *new_use_data = &uses[object];
+ new_use_data->thread = tid;
+ new_use_data->reader_count = 0;
+ new_use_data->writer_count = 1;
} else {
// Continue with an unsafe use of the object.
use_data->thread = tid;
@@ -128,10 +128,10 @@
counter_condition.wait(lock);
}
// There is now no current use of the object. Record writer thread.
- struct object_use_data *use_data = &uses[object];
- use_data->thread = tid;
- use_data->reader_count = 0;
- use_data->writer_count = 1;
+ struct object_use_data *new_use_data = &uses[object];
+ new_use_data->thread = tid;
+ new_use_data->reader_count = 0;
+ new_use_data->writer_count = 1;
} else {
// Continue with an unsafe use of the object.
use_data->thread = tid;