commit 47dd59d953d59d3a7a29f302430a3d755c039324
author Karl Schultz <karl@lunarg.com> Fri Jan 20 13:19:20 2017 -0700
committer Karl Schultz <karl@lunarg.com> Fri Jan 27 15:18:16 2017 -0800
tree 0a97b354705ce0a27ece4dc273bd5c2a59f3aeec
parent bfab4a6a3a252628185b5f2be82caf1e06ae0976

build: Enable declaration hiding warning on Windows

Fixes #1388
Turn on the Windows compiler option (4456) to report
hidden declarations.
Fix all places where this was occurring.

Change-Id: I3346d87da8b70d6299c206fcac68520a091ed1a6

tests/layer_validation_tests.cpp

diff --git a/tests/layer_validation_tests.cpp b/tests/layer_validation_tests.cpp
index ae879eb..d349b94 100644
--- a/tests/layer_validation_tests.cpp
+++ b/tests/layer_validation_tests.cpp
@@ -2641,7 +2641,6 @@
     // buffer to image
     {
         vk_testing::Buffer src_buffer;
-        VkMemoryPropertyFlags reqs = 0;
         src_buffer.init_as_src(*m_device, 128 * 128 * 4, reqs);
         image_create_info.samples = VK_SAMPLE_COUNT_8_BIT;
         image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT;
@@ -20503,7 +20502,7 @@
         buffer_create_info.pQueueFamilyIndices = &queue_family_index;
 
         VkBuffer buffer;
-        VkResult err = vkCreateBuffer(m_device->device(), &buffer_create_info, NULL, &buffer);
+        err = vkCreateBuffer(m_device->device(), &buffer_create_info, NULL, &buffer);
         ASSERT_VK_SUCCESS(err);
 
         VkMemoryRequirements memory_reqs;