tests: GH934 Testing SetScissor bounds
Change-Id: I03271c59de46684ac415d48ea9c6ab25dd7a332d
diff --git a/tests/layer_validation_tests.cpp b/tests/layer_validation_tests.cpp
index cf58288..ae357f1 100644
--- a/tests/layer_validation_tests.cpp
+++ b/tests/layer_validation_tests.cpp
@@ -34,9 +34,10 @@
#include "icd-spv.h"
#include "test_common.h"
#include "vk_layer_config.h"
-#include "vkrenderframework.h"
-#include <unordered_set>
#include "vk_validation_error_messages.h"
+#include "vkrenderframework.h"
+#include <limits.h>
+#include <unordered_set>
#define GLM_FORCE_RADIANS
#include "glm/glm.hpp"
@@ -15745,6 +15746,68 @@
m_errorMonitor->VerifyFound();
}
+TEST_F(VkLayerTest, ViewportBoundsChecking) {
+ TEST_DESCRIPTION("Verify errors are detected on misuse of SetViewport and SetScissor.");
+
+ ASSERT_NO_FATAL_FAILURE(InitState());
+ ASSERT_NO_FATAL_FAILURE(InitRenderTarget());
+
+ char const *vsSource = "#version 450\n"
+ "void main() { gl_Position = vec4(1); }\n";
+ char const *fsSource = "#version 450\n"
+ "layout(location=0) out vec4 color;\n"
+ "void main() { color = vec4(1); }\n";
+
+ VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX_BIT, this);
+ VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT_BIT, this);
+
+ VkPipelineObj pipe(m_device);
+ pipe.AddShader(&vs);
+ pipe.AddShader(&fs);
+ pipe.AddColorAttachment();
+
+ VkDescriptorSetObj descriptorSet(m_device);
+ descriptorSet.CreateVKDescriptorSet(m_commandBuffer);
+ VkResult err = pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass());
+ ASSERT_VK_SUCCESS(err);
+
+ BeginCommandBuffer();
+ m_commandBuffer->BindPipeline(pipe);
+
+ VkViewport viewport = {0, 0, 16, 16, 0, 1};
+ vkCmdSetViewport(m_commandBuffer->handle(), 0, 1, &viewport);
+
+ {
+ m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, VALIDATION_ERROR_01489);
+ VkRect2D scissor = {{-1, 0}, {16, 16}};
+ vkCmdSetScissor(m_commandBuffer->handle(), 0, 1, &scissor);
+ m_errorMonitor->VerifyFound();
+ }
+
+ {
+ m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, VALIDATION_ERROR_01489);
+ VkRect2D scissor = {{0, -2}, {16, 16}};
+ vkCmdSetScissor(m_commandBuffer->handle(), 0, 1, &scissor);
+ m_errorMonitor->VerifyFound();
+ }
+
+ {
+ m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, VALIDATION_ERROR_01490);
+ VkRect2D scissor = {{100, 100}, {INT_MAX, 16}};
+ vkCmdSetScissor(m_commandBuffer->handle(), 0, 1, &scissor);
+ m_errorMonitor->VerifyFound();
+ }
+
+ {
+ m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, VALIDATION_ERROR_01491);
+ VkRect2D scissor = {{100, 100}, {16, INT_MAX}};
+ vkCmdSetScissor(m_commandBuffer->handle(), 0, 1, &scissor);
+ m_errorMonitor->VerifyFound();
+ }
+
+ EndCommandBuffer();
+}
+
// This is a positive test. No failures are expected.
TEST_F(VkPositiveLayerTest, EmptyDescriptorUpdateTest) {
TEST_DESCRIPTION("Update last descriptor in a set that includes an empty binding");