tests: Add test for new renderpass clearValue check
Add test to hit the case where number of CLEAR loadOps in used
by renderPass attachments is greater than clearValueCount given
at renderPass begin time.
Also update documentation.
diff --git a/tests/layer_validation_tests.cpp b/tests/layer_validation_tests.cpp
index 8a65a1e..d69f6ca 100644
--- a/tests/layer_validation_tests.cpp
+++ b/tests/layer_validation_tests.cpp
@@ -6601,6 +6601,65 @@
m_errorMonitor->VerifyFound();
}
+TEST_F(VkLayerTest, RenderPassClearOpMismatch) {
+ TEST_DESCRIPTION("Begin a renderPass where clearValueCount is less than"
+ "the number of renderPass attachments that use loadOp"
+ "VK_ATTACHMENT_LOAD_OP_CLEAR.");
+
+ ASSERT_NO_FATAL_FAILURE(InitState());
+ ASSERT_NO_FATAL_FAILURE(InitRenderTarget());
+
+ // Create a renderPass with a single attachment that uses loadOp CLEAR
+ VkAttachmentReference attach = {};
+ attach.layout = VK_IMAGE_LAYOUT_GENERAL;
+ VkSubpassDescription subpass = {};
+ subpass.inputAttachmentCount = 1;
+ subpass.pInputAttachments = &attach;
+ VkRenderPassCreateInfo rpci = {};
+ rpci.subpassCount = 1;
+ rpci.pSubpasses = &subpass;
+ rpci.attachmentCount = 1;
+ VkAttachmentDescription attach_desc = {};
+ attach_desc.format = VK_FORMAT_UNDEFINED;
+ // Set loadOp to CLEAR
+ attach_desc.loadOp = VK_ATTACHMENT_LOAD_OP_CLEAR;
+ rpci.pAttachments = &attach_desc;
+ rpci.sType = VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO;
+ VkRenderPass rp;
+ vkCreateRenderPass(m_device->device(), &rpci, NULL, &rp);
+
+ VkCommandBufferInheritanceInfo hinfo = {};
+ hinfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO;
+ hinfo.renderPass = VK_NULL_HANDLE;
+ hinfo.subpass = 0;
+ hinfo.framebuffer = VK_NULL_HANDLE;
+ hinfo.occlusionQueryEnable = VK_FALSE;
+ hinfo.queryFlags = 0;
+ hinfo.pipelineStatistics = 0;
+ VkCommandBufferBeginInfo info = {};
+ info.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
+ info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
+ info.pInheritanceInfo = &hinfo;
+
+ vkBeginCommandBuffer(m_commandBuffer->handle(), &info);
+ VkRenderPassBeginInfo rp_begin = {};
+ rp_begin.sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO;
+ rp_begin.pNext = NULL;
+ rp_begin.renderPass = renderPass();
+ rp_begin.framebuffer = framebuffer();
+ rp_begin.clearValueCount = 0; // Should be 1
+
+ m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT,
+ " has a clearValueCount of 0 but the "
+ "actual number of attachments in "
+ "renderPass ");
+
+ vkCmdBeginRenderPass(m_commandBuffer->GetBufferHandle(), &rp_begin,
+ VK_SUBPASS_CONTENTS_INLINE);
+
+ m_errorMonitor->VerifyFound();
+}
+
TEST_F(VkLayerTest, EndCommandBufferWithinRenderPass) {
TEST_DESCRIPTION("End a command buffer with an active render pass");