commit 67b42b7bde3163f662452cd8ed20e0b69e1afa4f
author Mark Lobodzinski <mark@lunarg.com> Mon Sep 07 13:59:43 2015 -0600
committer Mark Lobodzinski <mark@lunarg.com> Thu Sep 10 11:20:57 2015 -0600
tree dd7ceddfc3faf6683c2fb9aec614b629fe4151a5
parent f004499e0c232374e63c6ebf3af467d8b3c32a8f

vulkan.h: Change return types of some functions to void

Functions that should be thought of as "impossible to fail in the face
of valid parameters" have had their return types changed to void.
This includes all of the vkDestroy functions, vkFreeMemory, and vkUnmapMemory.
vkUpdateDescriptorSets is also included, because of the frequency the function
is expected to be called.

tests/init.cpp

diff --git a/tests/init.cpp b/tests/init.cpp
index b6f9294..a191555 100644
--- a/tests/init.cpp
+++ b/tests/init.cpp
@@ -165,11 +165,9 @@
     memset(pData, 0x55, alloc_info.allocationSize);
     EXPECT_EQ(0x55, pData[0]) << "Memory read not same as write";
 
-    err = vkUnmapMemory(device(), gpu_mem);
-    ASSERT_VK_SUCCESS(err);
+    vkUnmapMemory(device(), gpu_mem);
 
-    err = vkFreeMemory(device(), gpu_mem);
-    ASSERT_VK_SUCCESS(err);
+    vkFreeMemory(device(), gpu_mem);
 }
 
 TEST_F(VkTest, Event) {
@@ -204,8 +202,7 @@
     // TODO: Test actual synchronization with command buffer event.
 
     // All done with event memory, clean up
-    err = vkDestroyEvent(device(), event);
-    ASSERT_VK_SUCCESS(err);
+    vkDestroyEvent(device(), event);
 }
 
 #define MAX_QUERY_SLOTS 10
@@ -270,8 +267,7 @@
 
     }
 
-    err = vkDestroyQueryPool(device(), query_pool);
-    ASSERT_VK_SUCCESS(err);
+    vkDestroyQueryPool(device(), query_pool);
 }
 
 void getQueue(vk_testing::Device *device, uint32_t queue_node_index, const char *qname)
@@ -480,11 +476,11 @@
     // TODO: Test image memory.
 
     // All done with image memory, clean up
-    ASSERT_VK_SUCCESS(vkDestroyImageView(device(), view));
-    ASSERT_VK_SUCCESS(vkDestroyImage(device(), image));
+    vkDestroyImageView(device(), view);
+    vkDestroyImage(device(), image);
 
     if (mem_req.size) {
-        ASSERT_VK_SUCCESS(vkFreeMemory(device(), image_mem));
+        vkFreeMemory(device(), image_mem);
     }
 }
 
@@ -520,8 +516,8 @@
     err = vkCreateCommandBuffer(device(), &info, &cmdBuffer);
     ASSERT_VK_SUCCESS(err) << "vkCreateCommandBuffer failed";
 
-    ASSERT_VK_SUCCESS(vkDestroyCommandBuffer(device(), cmdBuffer));
-    ASSERT_VK_SUCCESS(vkDestroyCommandPool(device(), cmdPool));
+    vkDestroyCommandBuffer(device(), cmdBuffer);
+    vkDestroyCommandPool(device(), cmdPool);
 }
 
 TEST_F(VkTest, TestCommandBuffer) {
@@ -568,8 +564,7 @@
     err = vkCreateShader(device(), &createInfo, &shader);
     ASSERT_VK_SUCCESS(err);
 
-    err = vkDestroyShaderModule(device(), module);
-    ASSERT_VK_SUCCESS(err);
+    vkDestroyShaderModule(device(), module);
 
     *pshader = shader;
 }