Fix use of 'is' operator for comparison
The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython.
CPython 3.8 has added a SyntaxWarning for this.
diff --git a/scripts/helper_file_generator.py b/scripts/helper_file_generator.py
index c0c9cbe..c110579 100644
--- a/scripts/helper_file_generator.py
+++ b/scripts/helper_file_generator.py
@@ -230,7 +230,7 @@
def paramIsPointer(self, param):
ispointer = False
for elem in param:
- if ((elem.tag is not 'type') and (elem.tail is not None)) and '*' in elem.tail:
+ if elem.tag == 'type' and elem.tail is not None and '*' in elem.tail:
ispointer = True
return ispointer
#
diff --git a/scripts/layer_chassis_dispatch_generator.py b/scripts/layer_chassis_dispatch_generator.py
index 4f4368e..5d3b80c 100644
--- a/scripts/layer_chassis_dispatch_generator.py
+++ b/scripts/layer_chassis_dispatch_generator.py
@@ -1175,7 +1175,7 @@
def paramIsPointer(self, param):
ispointer = False
for elem in param:
- if ((elem.tag is not 'type') and (elem.tail is not None)) and '*' in elem.tail:
+ if elem.tag == 'type' and elem.tail is not None and '*' in elem.tail:
ispointer = True
return ispointer
#
diff --git a/scripts/layer_chassis_generator.py b/scripts/layer_chassis_generator.py
index f581b98..91b559b 100644
--- a/scripts/layer_chassis_generator.py
+++ b/scripts/layer_chassis_generator.py
@@ -1478,7 +1478,7 @@
def paramIsPointer(self, param):
ispointer = False
for elem in param:
- if ((elem.tag is not 'type') and (elem.tail is not None)) and '*' in elem.tail:
+ if elem.tag == 'type' and elem.tail is not None and '*' in elem.tail:
ispointer = True
return ispointer
diff --git a/scripts/object_tracker_generator.py b/scripts/object_tracker_generator.py
index 79d106c..335c4ba 100644
--- a/scripts/object_tracker_generator.py
+++ b/scripts/object_tracker_generator.py
@@ -491,7 +491,7 @@
def paramIsPointer(self, param):
ispointer = False
for elem in param:
- if ((elem.tag is not 'type') and (elem.tail is not None)) and '*' in elem.tail:
+ if elem.tag == 'type' and elem.tail is not None and '*' in elem.tail:
ispointer = True
return ispointer
#
diff --git a/scripts/parameter_validation_generator.py b/scripts/parameter_validation_generator.py
index eb6f97d..83b00cf 100644
--- a/scripts/parameter_validation_generator.py
+++ b/scripts/parameter_validation_generator.py
@@ -361,10 +361,10 @@
struct_validation_source = self.ScrubStructCode(expr)
pnext_case += '%s' % struct_validation_source
pnext_case += ' } break;\n'
- if protect is not '':
+ if protect:
pnext_case += '#endif // %s\n' % protect
# Skip functions containing no validation
- if struct_validation_source != '':
+ if struct_validation_source:
pnext_handler += pnext_case;
pnext_handler += ' default:\n'
pnext_handler += ' skip = false;\n'
diff --git a/scripts/thread_safety_generator.py b/scripts/thread_safety_generator.py
index 9c0c7df..91afab2 100644
--- a/scripts/thread_safety_generator.py
+++ b/scripts/thread_safety_generator.py
@@ -677,7 +677,7 @@
def paramIsPointer(self, param):
ispointer = False
for elem in param:
- if ((elem.tag is not 'type') and (elem.tail is not None)) and '*' in elem.tail:
+ if elem.tag == 'type' and elem.tail is not None and '*' in elem.tail:
ispointer = True
return ispointer