layers:Move gfx pipe check to create time
Fixes #1424
The check to verify that the attachmentCount for blend state of a
Graphics Pipeline matches the attachmentCount for the given subpass of
the creation renderPass was occurring at draw time but can and should
be done at Gfx Pipeline creation time.
This change moves the check to creation time and updates the database
and test appropriately.
diff --git a/tests/layer_validation_tests.cpp b/tests/layer_validation_tests.cpp
index dc86d89..73ea19d 100644
--- a/tests/layer_validation_tests.cpp
+++ b/tests/layer_validation_tests.cpp
@@ -10342,8 +10342,7 @@
// blend attachments even though we have a color attachment.
VkResult err;
- m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT,
- "Render pass subpass 0 mismatch with blending state defined and blend state attachment");
+ m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, VALIDATION_ERROR_02109);
ASSERT_NO_FATAL_FAILURE(InitState());
ASSERT_NO_FATAL_FAILURE(InitRenderTarget());
@@ -10414,23 +10413,6 @@
pipe.AddShader(&fs);
pipe.SetMSAA(&pipe_ms_state_ci);
pipe.CreateVKPipeline(pipeline_layout, renderPass());
-
- m_commandBuffer->BeginCommandBuffer();
- m_commandBuffer->BeginRenderPass(m_renderPassBeginInfo);
- vkCmdBindPipeline(m_commandBuffer->GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.handle());
-
- VkViewport viewport = {0, 0, 16, 16, 0, 1};
- VkRect2D scissor = {{0, 0}, {16, 16}};
- vkCmdSetViewport(m_commandBuffer->handle(), 0, 1, &viewport);
- vkCmdSetScissor(m_commandBuffer->handle(), 0, 1, &scissor);
-
- // Render triangle (the error should trigger on the attempt to draw).
- Draw(3, 1, 0, 0);
-
- // Finalize recording of the command buffer
- m_commandBuffer->EndRenderPass();
- m_commandBuffer->EndCommandBuffer();
-
m_errorMonitor->VerifyFound();
vkDestroyPipelineLayout(m_device->device(), pipeline_layout, NULL);