commit a4935978e328cd51c7be88c6e14e8a44f4970a76
author Ricardo Garcia <rgarcia@igalia.com> Thu Feb 21 17:43:18 2019 +0100
committer John Zulauf <32470354+jzulauf-lunarg@users.noreply.github.com> Thu Apr 04 16:25:52 2019 -0600
tree ef6a4b160930bf45fb2617681fdba9d41a32c2f3
parent 4ccebef5fcfb6c634b5487e68fcb026b69d56f60

layers: Check acceleration structure compactedSize

This implements VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421.

layers/parameter_validation_utils.cpp

diff --git a/layers/parameter_validation_utils.cpp b/layers/parameter_validation_utils.cpp
index 1abd750..803f408 100644
--- a/layers/parameter_validation_utils.cpp
+++ b/layers/parameter_validation_utils.cpp
@@ -2942,3 +2942,22 @@
     }
     return skip;
 }
+
+bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
+    VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
+    VkAccelerationStructureNV *pAccelerationStructure) {
+    bool skip = false;
+
+    if (pCreateInfo) {
+        if ((pCreateInfo->compactedSize != 0) &&
+            ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
+            skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
+                            "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
+                            "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
+                            ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
+                            pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
+        }
+    }
+
+    return skip;
+}

layers/stateless_validation.h

diff --git a/layers/stateless_validation.h b/layers/stateless_validation.h
index cb4daa8..b5f2fda 100644
--- a/layers/stateless_validation.h
+++ b/layers/stateless_validation.h
@@ -1047,5 +1047,10 @@
                                                                   uint32_t *pPropertyCount, VkExtensionProperties *pProperties);
     bool manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
                                               const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory);
+
+    bool manual_PreCallValidateCreateAccelerationStructureNV(VkDevice device,
+                                                             const VkAccelerationStructureCreateInfoNV *pCreateInfo,
+                                                             const VkAllocationCallbacks *pAllocator,
+                                                             VkAccelerationStructureNV *pAccelerationStructure);
 #include "parameter_validation.h"
 };  // Class StatelessValidation

scripts/parameter_validation_generator.py

diff --git a/scripts/parameter_validation_generator.py b/scripts/parameter_validation_generator.py
index e8f6dcc..173d8be 100644
--- a/scripts/parameter_validation_generator.py
+++ b/scripts/parameter_validation_generator.py
@@ -174,6 +174,7 @@
             'vkCmdDrawMeshTasksIndirectNV',
             'vkCmdDrawMeshTasksIndirectCountNV',
             'vkAllocateMemory',
+            'vkCreateAccelerationStructureNV',
             ]
 
         # Commands to ignore