commit ac544f3737b45a5b35251100a3396aa8be397d8d
author Courtney Goeltzenleuchter <courtney@LunarG.com> Mon Sep 14 18:01:17 2015 -0600
committer Courtney Goeltzenleuchter <courtney@LunarG.com> Thu Sep 17 15:32:11 2015 -0600
tree be741b65a14d3f9590e7580dcd479744eab81234
parent 74c4ce9c4fa101c0989a29cf918e799fa67adcec

bug-14538: Remove validation error codes

https://cvs.khronos.org/bugzilla/show_bug.cgi?id=14538

icd/intel/queue.c

diff --git a/icd/intel/queue.c b/icd/intel/queue.c
index 03ca087..231ac59 100644
--- a/icd/intel/queue.c
+++ b/icd/intel/queue.c
@@ -57,7 +57,7 @@
     else
         err = intel_winsys_submit_bo(winsys, queue->ring, bo, used, 0);
 
-    return (err) ? VK_ERROR_UNKNOWN : VK_SUCCESS;
+    return (err) ? VK_ERROR_DEVICE_LOST : VK_SUCCESS;
 }
 
 static struct intel_bo *queue_create_bo(struct intel_queue *queue,
@@ -112,7 +112,7 @@
     default:
         /* TODOVV: Make sure coved in validation test */
 //        return VK_ERROR_INVALID_VALUE;
-        return VK_ERROR_UNKNOWN;
+        assert(0 && "Invalid pipeline select");
         break;
     }
 
@@ -190,11 +190,11 @@
 static VkResult queue_submit_cmd_prepare(struct intel_queue *queue,
                                            struct intel_cmd *cmd)
 {
+    /* TODOVV */
     if (unlikely(cmd->result != VK_SUCCESS || !cmd->primary)) {
         intel_dev_log(cmd->dev, VK_DBG_REPORT_ERROR_BIT,
                       &cmd->obj.base, 0, 0,
                       "invalid command buffer submitted");
-        return (cmd->primary) ? cmd->result : VK_ERROR_UNKNOWN;
     }
 
     return queue_select_pipeline(queue, cmd->pipeline_select);
@@ -256,8 +256,8 @@
 }
 
 VkResult intel_queue_create(struct intel_dev *dev,
-                              enum intel_gpu_engine_type engine,
-                              struct intel_queue **queue_ret)
+                            enum intel_gpu_engine_type engine,
+                            struct intel_queue **queue_ret)
 {
     struct intel_queue *queue;
     enum intel_ring_type ring;
@@ -270,7 +270,10 @@
         break;
     default:
         /* TODOVV: Verify test in validation layer */
-        return VK_ERROR_UNKNOWN;
+        intel_dev_log(dev, VK_DBG_REPORT_ERROR_BIT,
+                      &dev->base, 0, 0,
+                      "invalid engine type");
+        return VK_ERROR_VALIDATION_FAILED;
         break;
     }