commit afda27aacd466ded4520672d2a03695b4304cb68
author Tony Barbour <tony@LunarG.com> Fri Oct 09 11:50:32 2015 -0600
committer Tony Barbour <tony@LunarG.com> Fri Oct 09 11:57:00 2015 -0600
tree 172539f1ec538cdbb9aea978aa14d02bfb5cf9cf
parent d188757e3644ce0b7fda6228a2d4fccde4c67701

layers: Remove dependency between calls to vkCreateImage and vkGetPhysicalDeviceProperties

layers/device_limits.cpp

diff --git a/layers/device_limits.cpp b/layers/device_limits.cpp
index b8a2bc9..34acb20 100644
--- a/layers/device_limits.cpp
+++ b/layers/device_limits.cpp
@@ -64,7 +64,7 @@
     unique_ptr<PHYSICAL_DEVICE_STATE> physicalDeviceState;
     VkPhysicalDeviceFeatures actualPhysicalDeviceFeatures;
     VkPhysicalDeviceFeatures requestedPhysicalDeviceFeatures;
-    unique_ptr<VkPhysicalDeviceProperties> physicalDeviceProperties;
+    VkPhysicalDeviceProperties physicalDeviceProperties;
     // Track physical device per logical device
     VkPhysicalDevice physicalDevice;
     // Vector indices correspond to queueFamilyIndex
@@ -77,7 +77,7 @@
         device_extensions(),
         instanceState(nullptr),
         physicalDeviceState(nullptr),
-        physicalDeviceProperties(nullptr),
+        physicalDeviceProperties(),
         actualPhysicalDeviceFeatures(),
         requestedPhysicalDeviceFeatures(),
         physicalDevice()
@@ -233,6 +233,7 @@
                 phy_dev_data->physicalDeviceState = unique_ptr<PHYSICAL_DEVICE_STATE>(new PHYSICAL_DEVICE_STATE());
                 // Init actual features for each physical device
                 my_data->instance_dispatch_table->GetPhysicalDeviceFeatures(pPhysicalDevices[i], &(phy_dev_data->actualPhysicalDeviceFeatures));
+                my_data->instance_dispatch_table->GetPhysicalDeviceProperties(pPhysicalDevices[i], &(phy_dev_data->physicalDeviceProperties));
             }
         }
         return result;
@@ -268,11 +269,7 @@
 {
     layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map);
     VkResult result = phy_dev_data->instance_dispatch_table->GetPhysicalDeviceProperties(physicalDevice, pProperties);
-    if (VK_SUCCESS == result) {
-        // Save Properties
-        phy_dev_data->physicalDeviceProperties =
-            unique_ptr<VkPhysicalDeviceProperties>(new VkPhysicalDeviceProperties(*pProperties));
-    }
+
     return result;
 }
 
@@ -515,13 +512,8 @@
     phy_dev_data->instance_dispatch_table->GetPhysicalDeviceImageFormatProperties(
                        physicalDevice, pCreateInfo->format, pCreateInfo->imageType, pCreateInfo->tiling,
                        pCreateInfo->usage, pCreateInfo->flags, &ImageFormatProperties);
-    if (!phy_dev_data->physicalDeviceProperties) {
-        skipCall |= log_msg(phy_dev_data->report_data, VK_DBG_REPORT_WARN_BIT, VK_OBJECT_TYPE_IMAGE, (uint64_t)pImage, 0,
-                        DEVLIMITS_MUST_QUERY_PROPERTIES, "DL",
-                        "CreateImage called before querying device properties ");
-    }
 
-    VkDeviceSize imageGranularity = phy_dev_data->physicalDeviceProperties->limits.bufferImageGranularity;
+    VkDeviceSize imageGranularity = phy_dev_data->physicalDeviceProperties.limits.bufferImageGranularity;
     imageGranularity = imageGranularity == 1 ? 0 : imageGranularity;
 
     if ((pCreateInfo->extent.depth  > ImageFormatProperties.maxExtent.depth)  ||