commit b876212b97c642ae44c006549901e9416b562fee
author Chia-I Wu <olv@lunarg.com> Mon Dec 01 22:51:03 2014 +0800
committer Chia-I Wu <olv@lunarg.com> Wed Dec 03 10:29:11 2014 +0800
tree 3df8d9bbade8ef73e11a82133a1e83ba55b1ad92
parent 688c74b4c3d8ba5c568df5001e4986b333c2d103

intel: detect xglEndCommandBuffer without xglBeginCommandBuffer

Simple check to catch user errors that result in segfaults.

icd/intel/cmd.c

diff --git a/icd/intel/cmd.c b/icd/intel/cmd.c
index cd7b0de..106eb94 100644
--- a/icd/intel/cmd.c
+++ b/icd/intel/cmd.c
@@ -346,6 +346,10 @@
     struct intel_winsys *winsys = cmd->dev->winsys;
     XGL_UINT i;
 
+    /* no matching intel_cmd_begin() */
+    if (!cmd->writers[INTEL_CMD_WRITER_BATCH].ptr)
+        return XGL_ERROR_INCOMPLETE_COMMAND_BUFFER;
+
     cmd_batch_end(cmd);
 
     /* TODO we need a more "explicit" winsys */