commit c0ff3e06bfb278890b3e887f60b7ff56c77172c4
author Tobin Ehlis <tobin@lunarg.com> Mon Jul 13 13:42:25 2015 -0600
committer Courtney Goeltzenleuchter <courtney@LunarG.com> Fri Jul 17 10:05:22 2015 -0600
tree d6bc82a5d7168db021ee0f9c55870152de7b06a2
parent 5a65cca2547cf1c85ceeae1b9fa998ccd94d53ae

layers: MemTracker fix to skip COLOR usage bit check for now

Now that Attachments are generalized and not color or DS specific, need to make sure we only check usage bits appropriate for a given image.

layers/mem_tracker.cpp

diff --git a/layers/mem_tracker.cpp b/layers/mem_tracker.cpp
index 31f5075..4f0da34 100644
--- a/layers/mem_tracker.cpp
+++ b/layers/mem_tracker.cpp
@@ -2132,7 +2132,7 @@
 }
 
 VK_LAYER_EXPORT VkResult VKAPI vkCreateAttachmentView(
-    VkDevice                               device,
+    VkDevice                          device,
     const VkAttachmentViewCreateInfo *pCreateInfo,
     VkAttachmentView                 *pView)
 {
@@ -2145,8 +2145,10 @@
         MT_OBJ_BINDING_INFO* pInfo = get_object_binding_info(pCreateInfo->image.handle, VK_OBJECT_TYPE_IMAGE);
         if (pInfo) {
             if (VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO == pInfo->create_info.image.sType) {
-                validate_usage_flags(device, pInfo->create_info.image.usage, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, true,
-                                     pCreateInfo->image.handle, VK_OBJECT_TYPE_IMAGE, "image", "vkCreateAttachmentView()", "VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT");
+                // TODO : Now that this is generalized for all Attachments, need to only check COLOR or DS USAGE bits
+                //  if/when we know that Image being attached to is Color or DS. Can probably do this for DS based on format
+//                validate_usage_flags(device, pInfo->create_info.image.usage, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, true,
+//                                     pCreateInfo->image.handle, VK_OBJECT_TYPE_IMAGE, "image", "vkCreateAttachmentView()", "VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT");
             } else if (VK_STRUCTURE_TYPE_SWAP_CHAIN_CREATE_INFO_WSI == pInfo->create_info.swapchain.sType) {
                 validate_usage_flags(device, pInfo->create_info.swapchain.imageUsageFlags, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, true,
                                      pCreateInfo->image.handle, VK_OBJECT_TYPE_IMAGE, "image", "vkCreateAttachmentView()", "VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT");