layers: Fix invalid push constant checks (GH953)
Rework of invalid push constant checks, motivated mostly
by some spec updates and prior bad assumptions.
- Add check/test for a shader stage flag being set more
than once in CreatePipelineLayout.
- Remove checks and tests having to do with warning about
overlapping ranges in CreatePipelineLayout. Ranges can
certainly overlap when used in different stages. And
the prohibition of more than one range with the same
stage flag removes the possibility of overlap in the same
stage. These checks were warnings and so probably not
noticed.
Fixes #953
Finishes VU 00871
Change-Id: Icc9d3d84fa3132f266075f2f1d45c243e9e1a65f
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp
index 785b4cd..b06dd99 100644
--- a/layers/core_validation.cpp
+++ b/layers/core_validation.cpp
@@ -6526,7 +6526,7 @@
const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) {
bool skip_call = false;
layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
- // TODO : Add checks for VALIDATION_ERRORS 865-871
+ // TODO : Add checks for VALIDATION_ERRORS 865-870
// Push Constant Range checks
uint32_t i, j;
for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
@@ -6540,20 +6540,14 @@
}
if (skip_call) return VK_ERROR_VALIDATION_FAILED_EXT;
- // Each range has been validated. Now check for overlap between ranges (if they are good).
- // There's no explicit Valid Usage language against this, so issue a warning instead of an error.
+ // As of 1.0.28, there is a VU that states that a stage flag cannot appear more than once in the list of push constant ranges.
for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) {
- const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset;
- const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size;
- const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset;
- const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size;
- if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) {
- skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0,
- __LINE__, DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS",
- "vkCreatePipelineLayout() call has push constants with "
- "overlapping ranges: %u:[%u, %u), %u:[%u, %u)",
- i, minA, maxA, j, minB, maxB);
+ if (0 != (pCreateInfo->pPushConstantRanges[i].stageFlags & pCreateInfo->pPushConstantRanges[j].stageFlags)) {
+ skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0,
+ __LINE__, VALIDATION_ERROR_00871, "DS",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges %d and %d. %s", i, j,
+ validation_error_map[VALIDATION_ERROR_00871]);
}
}
}
@@ -8541,69 +8535,25 @@
validation_error_map[VALIDATION_ERROR_00996]);
}
- // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout.
- auto pipeline_layout = getPipelineLayout(dev_data, layout);
- // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is
- // contained in the pipeline ranges.
- // Build a {start, end} span list for ranges with matching stage flags.
- const auto &ranges = pipeline_layout->push_constant_ranges;
- struct span {
- uint32_t start;
- uint32_t end;
- };
- std::vector<span> spans;
- spans.reserve(ranges.size());
- for (const auto &iter : ranges) {
- if (iter.stageFlags == stageFlags) {
- spans.push_back({iter.offset, iter.offset + iter.size});
- }
- }
- if (spans.size() == 0) {
- // There were no ranges that matched the stageFlags.
- skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__,
- VALIDATION_ERROR_00988, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32
- " do not match "
- "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ". %s",
- (uint32_t)stageFlags, (uint64_t)layout, validation_error_map[VALIDATION_ERROR_00988]);
- } else {
- // Sort span list by start value.
- struct comparer {
- bool operator()(struct span i, struct span j) { return i.start < j.start; }
- } my_comparer;
- std::sort(spans.begin(), spans.end(), my_comparer);
-
- // Examine two spans at a time.
- std::vector<span>::iterator current = spans.begin();
- std::vector<span>::iterator next = current + 1;
- while (next != spans.end()) {
- if (current->end < next->start) {
- // There is a gap; cannot coalesce. Move to the next two spans.
- ++current;
- ++next;
- } else {
- // Coalesce the two spans. The start of the next span
- // is within the current span, so pick the larger of
- // the end values to extend the current span.
- // Then delete the next span and set next to the span after it.
- current->end = max(current->end, next->end);
- next = spans.erase(next);
- }
- }
-
- // Now we can check if the incoming range is within any of the spans.
- bool contained_in_a_range = false;
- for (uint32_t i = 0; i < spans.size(); ++i) {
- if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) {
- contained_in_a_range = true;
+ // Check if specified push constant range falls within a pipeline-defined range which has matching stageFlags.
+ // The spec doesn't seem to disallow having multiple push constant ranges with the
+ // same offset and size, but different stageFlags. So we can't just check the
+ // stageFlags in the first range with matching offset and size.
+ if (!skip) {
+ const auto &ranges = getPipelineLayout(dev_data, layout)->push_constant_ranges;
+ bool found_matching_range = false;
+ for (const auto &range : ranges) {
+ if ((stageFlags == range.stageFlags) && (offset >= range.offset) && (offset + size <= range.offset + range.size)) {
+ found_matching_range = true;
break;
}
}
- if (!contained_in_a_range) {
- skip |= log_msg(
- dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__,
- VALIDATION_ERROR_00988, "DS", "vkCmdPushConstants() Push constant range [%d, %d) with stageFlags = 0x%" PRIx32
- " not within flag-matching ranges in pipeline layout 0x%" PRIx64 ". %s",
- offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout, validation_error_map[VALIDATION_ERROR_00988]);
+ if (!found_matching_range) {
+ skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__,
+ VALIDATION_ERROR_00988, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32
+ " do not match the stageFlags in any of the ranges with"
+ " offset = %d and size = %d in pipeline layout 0x%" PRIx64 ". %s",
+ (uint32_t)stageFlags, offset, size, (uint64_t)layout, validation_error_map[VALIDATION_ERROR_00988]);
}
}
lock.unlock();
diff --git a/layers/vk_validation_error_database.txt b/layers/vk_validation_error_database.txt
index 2cb4d76..1276f74 100644
--- a/layers/vk_validation_error_database.txt
+++ b/layers/vk_validation_error_database.txt
@@ -859,7 +859,7 @@
VALIDATION_ERROR_00868~^~N~^~None~^~vkCreatePipelineLayout~^~For more information refer to Vulkan Spec Section '13.2.2. Pipeline Layouts' which states 'The total number of descriptors of the type VK_DESCRIPTOR_TYPE_STORAGE_BUFFER and VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC accessible to any given shader stage across all elements of pSetLayouts must be less than or equal to VkPhysicalDeviceLimits::maxPerStageDescriptorStorageBuffers' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkPipelineLayoutCreateInfo)~^~
VALIDATION_ERROR_00869~^~N~^~None~^~vkCreatePipelineLayout~^~For more information refer to Vulkan Spec Section '13.2.2. Pipeline Layouts' which states 'The total number of descriptors of the type VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, and VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER accessible to any given shader stage across all elements of pSetLayouts must be less than or equal to VkPhysicalDeviceLimits::maxPerStageDescriptorSampledImages' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkPipelineLayoutCreateInfo)~^~
VALIDATION_ERROR_00870~^~N~^~None~^~vkCreatePipelineLayout~^~For more information refer to Vulkan Spec Section '13.2.2. Pipeline Layouts' which states 'The total number of descriptors of the type VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, and VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER accessible to any given shader stage across all elements of pSetLayouts must be less than or equal to VkPhysicalDeviceLimits::maxPerStageDescriptorStorageImages' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkPipelineLayoutCreateInfo)~^~
-VALIDATION_ERROR_00871~^~N~^~None~^~vkCreatePipelineLayout~^~For more information refer to Vulkan Spec Section '13.2.2. Pipeline Layouts' which states 'Any two elements of pPushConstantRanges must not include the same stage in stageFlags' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkPipelineLayoutCreateInfo)~^~
+VALIDATION_ERROR_00871~^~Y~^~InvalidPushConstants~^~vkCreatePipelineLayout~^~For more information refer to Vulkan Spec Section '13.2.2. Pipeline Layouts' which states 'Any two elements of pPushConstantRanges must not include the same stage in stageFlags' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkPipelineLayoutCreateInfo)~^~
VALIDATION_ERROR_00872~^~N~^~Unknown~^~vkCreatePipelineLayout~^~For more information refer to Vulkan Spec Section '13.2.2. Pipeline Layouts' which states 'sType must be VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkPipelineLayoutCreateInfo)~^~implicit, TBD in parameter validation layer.
VALIDATION_ERROR_00873~^~N~^~Unknown~^~vkCreatePipelineLayout~^~For more information refer to Vulkan Spec Section '13.2.2. Pipeline Layouts' which states 'pNext must be NULL' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkPipelineLayoutCreateInfo)~^~implicit, TBD in parameter validation layer.
VALIDATION_ERROR_00874~^~N~^~Unknown~^~vkCreatePipelineLayout~^~For more information refer to Vulkan Spec Section '13.2.2. Pipeline Layouts' which states 'flags must be 0' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkPipelineLayoutCreateInfo)~^~implicit, TBD in parameter validation layer.
@@ -976,7 +976,7 @@
VALIDATION_ERROR_00985~^~N~^~Unknown~^~vkCmdBindDescriptorSets~^~For more information refer to Vulkan Spec Section '13.2.5. Descriptor Set Binding' which states 'The VkCommandPool that commandBuffer was allocated from must support graphics, or compute operations' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkCmdBindDescriptorSets)~^~implicit
VALIDATION_ERROR_00986~^~N~^~Unknown~^~vkCmdBindDescriptorSets~^~For more information refer to Vulkan Spec Section '13.2.5. Descriptor Set Binding' which states 'descriptorSetCount must be greater than 0' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkCmdBindDescriptorSets)~^~implicit
VALIDATION_ERROR_00987~^~Y~^~Unknown~^~vkCmdBindDescriptorSets~^~For more information refer to Vulkan Spec Section '13.2.5. Descriptor Set Binding' which states 'Each of commandBuffer, layout, and the elements of pDescriptorSets must have been created, allocated, or retrieved from the same VkDevice' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkCmdBindDescriptorSets)~^~implicit
-VALIDATION_ERROR_00988~^~Y~^~Unknown~^~vkCmdPushConstants~^~For more information refer to Vulkan Spec Section '13.2.6. Push Constant Updates' which states 'stageFlags must match exactly the shader stages used in layout for the range specified by offset and size' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkCmdPushConstants)~^~
+VALIDATION_ERROR_00988~^~Y~^~InvalidPushConstants~^~vkCmdPushConstants~^~For more information refer to Vulkan Spec Section '13.2.6. Push Constant Updates' which states 'stageFlags must match exactly the shader stages used in layout for the range specified by offset and size' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkCmdPushConstants)~^~
VALIDATION_ERROR_00989~^~Y~^~Unknown~^~vkCmdPushConstants~^~For more information refer to Vulkan Spec Section '13.2.6. Push Constant Updates' which states 'offset must be a multiple of 4' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkCmdPushConstants)~^~
VALIDATION_ERROR_00990~^~Y~^~Unknown~^~vkCmdPushConstants~^~For more information refer to Vulkan Spec Section '13.2.6. Push Constant Updates' which states 'size must be a multiple of 4' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkCmdPushConstants)~^~
VALIDATION_ERROR_00991~^~Y~^~Unknown~^~vkCmdPushConstants~^~For more information refer to Vulkan Spec Section '13.2.6. Push Constant Updates' which states 'offset must be less than VkPhysicalDeviceLimits::maxPushConstantsSize' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkCmdPushConstants)~^~
diff --git a/tests/layer_validation_tests.cpp b/tests/layer_validation_tests.cpp
index 12c7f7a..2e1ca06 100644
--- a/tests/layer_validation_tests.cpp
+++ b/tests/layer_validation_tests.cpp
@@ -6910,69 +6910,60 @@
vkDestroyPipelineLayout(m_device->device(), pipeline_layout, NULL);
}
- // Check for overlapping ranges
+ // Check for duplicate stage flags in a list of push constant ranges.
+ // A shader can only have one push constant block and that block is mapped
+ // to the push constant range that has that shader's stage flag set.
+ // The shader's stage flag can only appear once in all the ranges, so the
+ // implementation can find the one and only range to map it to.
const uint32_t ranges_per_test = 5;
- struct OverlappingRangeTestCase {
+ struct DuplicateStageFlagsTestCase {
VkPushConstantRange const ranges[ranges_per_test];
std::vector<char const *> const msg;
};
-
- const std::array<OverlappingRangeTestCase, 5> overlapping_range_tests = {
- {{{{VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 0, 4}},
- {"vkCreatePipelineLayout() call has push constants with overlapping ranges: 0:[0, 4), 1:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 0:[0, 4), 2:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 0:[0, 4), 3:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 0:[0, 4), 4:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 1:[0, 4), 2:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 1:[0, 4), 3:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 1:[0, 4), 4:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 2:[0, 4), 3:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 2:[0, 4), 4:[0, 4)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 3:[0, 4), 4:[0, 4)"}},
- {
- {{VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 4, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 8, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 12, 8},
- {VK_SHADER_STAGE_VERTEX_BIT, 16, 4}},
- {"vkCreatePipelineLayout() call has push constants with overlapping ranges: 3:[12, 20), 4:[16, 20)"},
- },
- {
- {{VK_SHADER_STAGE_VERTEX_BIT, 16, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 12, 8},
- {VK_SHADER_STAGE_VERTEX_BIT, 8, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 4, 4},
+ // Overlapping ranges are OK, but a stage flag can appear only once.
+ const std::array<DuplicateStageFlagsTestCase, 3> duplicate_stageFlags_tests = {
+ {
+ {{{VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
+ {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
+ {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
+ {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
{VK_SHADER_STAGE_VERTEX_BIT, 0, 4}},
- {"vkCreatePipelineLayout() call has push constants with overlapping ranges: 0:[16, 20), 1:[12, 20)"},
- },
- {
- {{VK_SHADER_STAGE_VERTEX_BIT, 16, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 8, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 4, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 12, 8},
- {VK_SHADER_STAGE_VERTEX_BIT, 0, 4}},
- {"vkCreatePipelineLayout() call has push constants with overlapping ranges: 0:[16, 20), 3:[12, 20)"},
- },
- {
- {{VK_SHADER_STAGE_VERTEX_BIT, 16, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 32, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 4, 96},
- {VK_SHADER_STAGE_VERTEX_BIT, 40, 8},
- {VK_SHADER_STAGE_VERTEX_BIT, 52, 4}},
- {"vkCreatePipelineLayout() call has push constants with overlapping ranges: 0:[16, 20), 2:[4, 100)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 1:[32, 36), 2:[4, 100)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 2:[4, 100), 3:[40, 48)",
- "vkCreatePipelineLayout() call has push constants with overlapping ranges: 2:[4, 100), 4:[52, 56)"},
- }}};
+ {
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 0 and 1.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 0 and 2.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 0 and 3.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 0 and 4.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 1 and 2.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 1 and 3.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 1 and 4.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 2 and 3.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 2 and 4.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 3 and 4.",
+ }},
+ {{{VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
+ {VK_SHADER_STAGE_GEOMETRY_BIT, 0, 4},
+ {VK_SHADER_STAGE_FRAGMENT_BIT, 0, 4},
+ {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
+ {VK_SHADER_STAGE_GEOMETRY_BIT, 0, 4}},
+ {
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 0 and 3.",
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 1 and 4.",
+ }},
+ {{{VK_SHADER_STAGE_FRAGMENT_BIT, 0, 4},
+ {VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT, 0, 4},
+ {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
+ {VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
+ {VK_SHADER_STAGE_GEOMETRY_BIT, 0, 4}},
+ {
+ "vkCreatePipelineLayout() Duplicate stage flags found in ranges 2 and 3.",
+ }},
+ },
+ };
- for (const auto &iter : overlapping_range_tests) {
+ for (const auto &iter : duplicate_stageFlags_tests) {
pipeline_layout_ci.pPushConstantRanges = iter.ranges;
pipeline_layout_ci.pushConstantRangeCount = ranges_per_test;
- m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_WARNING_BIT_EXT, iter.msg.begin(), iter.msg.end());
+ m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, iter.msg.begin(), iter.msg.end());
err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, NULL, &pipeline_layout);
m_errorMonitor->VerifyFound();
if (VK_SUCCESS == err) {
@@ -6983,98 +6974,51 @@
//
// CmdPushConstants tests
//
- const uint8_t dummy_values[100] = {};
- // Check for invalid offset and size and if range is within layout range(s)
- const std::array<PipelineLayoutTestCase, 11> cmd_range_tests = {{
- {{VK_SHADER_STAGE_VERTEX_BIT, 0, 0}, "vkCmdPushConstants: parameter size must be greater than 0"},
- {{VK_SHADER_STAGE_VERTEX_BIT, 0, 1},
- "vkCmdPushConstants() call has push constants index 0 with size 1. "
- "Size must be a multiple of 4."},
- {{VK_SHADER_STAGE_VERTEX_BIT, 4, 1},
- "vkCmdPushConstants() call has push constants index 0 with size 1. "
- "Size must be a multiple of 4."},
- {{VK_SHADER_STAGE_VERTEX_BIT, 1, 4},
- "vkCmdPushConstants() call has push constants with offset 1. "
- "Offset must be a multiple of 4."},
- {{VK_SHADER_STAGE_VERTEX_BIT, 1, 4},
- "vkCmdPushConstants() call has push constants with offset 1. "
- "Offset must be a multiple of 4."},
- {{VK_SHADER_STAGE_VERTEX_BIT, 0, 20},
- "vkCmdPushConstants() Push constant range [0, 20) with stageFlags = "
- "0x1 not within flag-matching ranges in pipeline layout"},
- {{VK_SHADER_STAGE_VERTEX_BIT, 60, 8},
- "vkCmdPushConstants() Push constant range [60, 68) with stageFlags = "
- "0x1 not within flag-matching ranges in pipeline layout"},
- {{VK_SHADER_STAGE_VERTEX_BIT, 76, 8},
- "vkCmdPushConstants() Push constant range [76, 84) with stageFlags = "
- "0x1 not within flag-matching ranges in pipeline layout"},
- {{VK_SHADER_STAGE_VERTEX_BIT, 0, 80},
- "vkCmdPushConstants() Push constant range [0, 80) with stageFlags = "
- "0x1 not within flag-matching ranges in pipeline layout"},
- {{VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT, 0, 4},
- "vkCmdPushConstants() stageFlags = 0x2 do not match the stageFlags in "
- "any of the ranges in pipeline layout"},
- {{VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT, 0, 16},
- "vkCmdPushConstants() stageFlags = 0x3 do not match the stageFlags in "
- "any of the ranges in pipeline layout"},
- }};
-
- m_commandBuffer->BeginCommandBuffer();
- m_commandBuffer->BeginRenderPass(m_renderPassBeginInfo);
-
- // Setup ranges: [0,16) [64,80)
+ // Setup a pipeline layout with ranges: [0,16) [64,80)
const VkPushConstantRange pc_range2[] = {
- {VK_SHADER_STAGE_VERTEX_BIT, 64, 16}, {VK_SHADER_STAGE_VERTEX_BIT, 0, 16},
+ {VK_SHADER_STAGE_VERTEX_BIT, 64, 16}, {VK_SHADER_STAGE_FRAGMENT_BIT, 0, 16},
};
pipeline_layout_ci.pushConstantRangeCount = sizeof(pc_range2) / sizeof(VkPushConstantRange);
pipeline_layout_ci.pPushConstantRanges = pc_range2;
err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, NULL, &pipeline_layout);
ASSERT_VK_SUCCESS(err);
- for (const auto &iter : cmd_range_tests) {
- m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, iter.msg);
- vkCmdPushConstants(m_commandBuffer->GetBufferHandle(), pipeline_layout, iter.range.stageFlags, iter.range.offset,
- iter.range.size, dummy_values);
- m_errorMonitor->VerifyFound();
- }
+
+ const uint8_t dummy_values[100] = {};
+
+ m_commandBuffer->BeginCommandBuffer();
+ m_commandBuffer->BeginRenderPass(m_renderPassBeginInfo);
// Check for invalid stage flag
+ // Note that VU 00996 isn't reached due to parameter validation
m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, "vkCmdPushConstants: value of stageFlags must not be 0");
vkCmdPushConstants(m_commandBuffer->GetBufferHandle(), pipeline_layout, 0, 0, 16, dummy_values);
m_errorMonitor->VerifyFound();
- vkDestroyPipelineLayout(m_device->device(), pipeline_layout, NULL);
- // overlapping range tests with cmd
- const std::array<PipelineLayoutTestCase, 3> cmd_overlap_tests = {{
- {{VK_SHADER_STAGE_VERTEX_BIT, 0, 20},
- "vkCmdPushConstants() Push constant range [0, 20) with stageFlags = "
- "0x1 not within flag-matching ranges in pipeline layout"},
- {{VK_SHADER_STAGE_VERTEX_BIT, 16, 4},
- "vkCmdPushConstants() Push constant range [16, 20) with stageFlags = "
- "0x1 not within flag-matching ranges in pipeline layout"},
- {{VK_SHADER_STAGE_VERTEX_BIT, 40, 16},
- "vkCmdPushConstants() Push constant range [40, 56) with stageFlags = "
- "0x1 not within flag-matching ranges in pipeline layout"},
+ m_errorMonitor->ExpectSuccess();
+ vkCmdPushConstants(m_commandBuffer->GetBufferHandle(), pipeline_layout, VK_SHADER_STAGE_FRAGMENT_BIT, 0, 16, dummy_values);
+ m_errorMonitor->VerifyNotFound();
+ m_errorMonitor->ExpectSuccess();
+ vkCmdPushConstants(m_commandBuffer->GetBufferHandle(), pipeline_layout, VK_SHADER_STAGE_VERTEX_BIT, 64, 16, dummy_values);
+ m_errorMonitor->VerifyNotFound();
+ const std::array<VkPushConstantRange, 6> cmd_range_tests = {{
+ {VK_SHADER_STAGE_FRAGMENT_BIT, 64, 16},
+ {VK_SHADER_STAGE_VERTEX_BIT, 0, 16},
+ {VK_SHADER_STAGE_GEOMETRY_BIT, 0, 16},
+ {VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_FRAGMENT_BIT, 0, 16},
+ {VK_SHADER_STAGE_VERTEX_BIT, 24, 16},
+ {VK_SHADER_STAGE_VERTEX_BIT, 8, 4},
}};
- // Setup ranges: [0,16), [20,36), [36,44), [44,52), [80,92)
- const VkPushConstantRange pc_range3[] = {
- {VK_SHADER_STAGE_VERTEX_BIT, 20, 16}, {VK_SHADER_STAGE_VERTEX_BIT, 0, 16}, {VK_SHADER_STAGE_VERTEX_BIT, 44, 8},
- {VK_SHADER_STAGE_VERTEX_BIT, 80, 12}, {VK_SHADER_STAGE_VERTEX_BIT, 36, 8},
- };
- pipeline_layout_ci.pushConstantRangeCount = sizeof(pc_range3) / sizeof(VkPushConstantRange);
- pipeline_layout_ci.pPushConstantRanges = pc_range3;
- err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, NULL, &pipeline_layout);
- ASSERT_VK_SUCCESS(err);
- for (const auto &iter : cmd_overlap_tests) {
- m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, iter.msg);
- vkCmdPushConstants(m_commandBuffer->GetBufferHandle(), pipeline_layout, iter.range.stageFlags, iter.range.offset,
- iter.range.size, dummy_values);
+ for (const auto &iter : cmd_range_tests) {
+ m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, VALIDATION_ERROR_00988);
+ vkCmdPushConstants(m_commandBuffer->GetBufferHandle(), pipeline_layout, iter.stageFlags, iter.offset, iter.size,
+ dummy_values);
m_errorMonitor->VerifyFound();
}
- vkDestroyPipelineLayout(m_device->device(), pipeline_layout, NULL);
m_commandBuffer->EndRenderPass();
m_commandBuffer->EndCommandBuffer();
+ vkDestroyPipelineLayout(m_device->device(), pipeline_layout, NULL);
}
TEST_F(VkLayerTest, DescriptorSetCompatibility) {
@@ -22226,93 +22170,6 @@
vkDestroyPipelineLayout(test_device.device(), pipeline_layout, NULL);
}
-TEST_F(VkPositiveLayerTest, ValidPushConstants) {
- VkResult err;
- ASSERT_NO_FATAL_FAILURE(InitState());
- ASSERT_NO_FATAL_FAILURE(InitViewport());
- ASSERT_NO_FATAL_FAILURE(InitRenderTarget());
-
- VkPipelineLayout pipeline_layout;
- VkPushConstantRange pc_range = {};
- VkPipelineLayoutCreateInfo pipeline_layout_ci = {};
- pipeline_layout_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO;
- pipeline_layout_ci.pushConstantRangeCount = 1;
- pipeline_layout_ci.pPushConstantRanges = &pc_range;
-
- //
- // Check for invalid push constant ranges in pipeline layouts.
- //
- struct PipelineLayoutTestCase {
- VkPushConstantRange const range;
- char const *msg;
- };
-
- // Check for overlapping ranges
- const uint32_t ranges_per_test = 5;
- struct OverlappingRangeTestCase {
- VkPushConstantRange const ranges[ranges_per_test];
- char const *msg;
- };
-
- // Run some positive tests to make sure overlap checking in the layer is OK
- const std::array<OverlappingRangeTestCase, 2> overlapping_range_tests_pos = {{{{{VK_SHADER_STAGE_VERTEX_BIT, 0, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 4, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 8, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 12, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 16, 4}},
- ""},
- {{{VK_SHADER_STAGE_VERTEX_BIT, 92, 24},
- {VK_SHADER_STAGE_VERTEX_BIT, 80, 4},
- {VK_SHADER_STAGE_VERTEX_BIT, 64, 8},
- {VK_SHADER_STAGE_VERTEX_BIT, 4, 16},
- {VK_SHADER_STAGE_VERTEX_BIT, 0, 4}},
- ""}}};
- for (const auto &iter : overlapping_range_tests_pos) {
- pipeline_layout_ci.pPushConstantRanges = iter.ranges;
- m_errorMonitor->ExpectSuccess();
- err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, NULL, &pipeline_layout);
- m_errorMonitor->VerifyNotFound();
- if (VK_SUCCESS == err) {
- vkDestroyPipelineLayout(m_device->device(), pipeline_layout, NULL);
- }
- }
-
- //
- // CmdPushConstants tests
- //
- const uint8_t dummy_values[100] = {};
-
- m_commandBuffer->BeginCommandBuffer();
-
- // positive overlapping range tests with cmd
- const std::array<PipelineLayoutTestCase, 4> cmd_overlap_tests_pos = {{
- {{VK_SHADER_STAGE_VERTEX_BIT, 0, 16}, ""},
- {{VK_SHADER_STAGE_VERTEX_BIT, 0, 4}, ""},
- {{VK_SHADER_STAGE_VERTEX_BIT, 20, 12}, ""},
- {{VK_SHADER_STAGE_VERTEX_BIT, 56, 36}, ""},
- }};
-
- // Setup ranges: [0,16) [20,36) [36,44) [44,52) [56,80) [80,92)
- const VkPushConstantRange pc_range4[] = {
- {VK_SHADER_STAGE_VERTEX_BIT, 20, 16}, {VK_SHADER_STAGE_VERTEX_BIT, 0, 16}, {VK_SHADER_STAGE_VERTEX_BIT, 44, 8},
- {VK_SHADER_STAGE_VERTEX_BIT, 80, 12}, {VK_SHADER_STAGE_VERTEX_BIT, 36, 8}, {VK_SHADER_STAGE_VERTEX_BIT, 56, 24},
- };
-
- pipeline_layout_ci.pushConstantRangeCount = sizeof(pc_range4) / sizeof(VkPushConstantRange);
- pipeline_layout_ci.pPushConstantRanges = pc_range4;
- err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, NULL, &pipeline_layout);
- ASSERT_VK_SUCCESS(err);
- for (const auto &iter : cmd_overlap_tests_pos) {
- m_errorMonitor->ExpectSuccess();
- vkCmdPushConstants(m_commandBuffer->GetBufferHandle(), pipeline_layout, iter.range.stageFlags, iter.range.offset,
- iter.range.size, dummy_values);
- m_errorMonitor->VerifyNotFound();
- }
- vkDestroyPipelineLayout(m_device->device(), pipeline_layout, NULL);
-
- m_commandBuffer->EndCommandBuffer();
-}
-
#if 0 // A few devices have issues with this test so disabling for now
TEST_F(VkPositiveLayerTest, LongFenceChain)
{