commit e0d1f4fe83eedc043e6bd41f37e233f32afdcd6f
author Mark Lobodzinski <mark@lunarg.com> Wed Jan 18 15:44:53 2017 -0700
committer Mark Lobodzinski <mark@lunarg.com> Thu Jan 19 13:46:48 2017 -0700
tree 0ae380967c174fb35c6c1d4b891160f8c8338929
parent 3513bec91d5b06f8c11baa6ee19593264482b371

tests: Add checks for ClearAttachment validation

Renamed existing test, added new test cases and updated the
validation error database with the test names.

Change-Id: Ie0600f2ad8b1fa0851479b91a555622bbe1075b9

tests/layer_validation_tests.cpp

diff --git a/tests/layer_validation_tests.cpp b/tests/layer_validation_tests.cpp
index f5ac8db..280dc80 100644
--- a/tests/layer_validation_tests.cpp
+++ b/tests/layer_validation_tests.cpp
@@ -10223,13 +10223,10 @@
     m_errorMonitor->VerifyFound();
 }
 
-TEST_F(VkLayerTest, ClearCmdNoDraw) {
-    // Create CommandBuffer where we add ClearCmd for FB Color attachment prior
-    // to issuing a Draw
-    VkResult err;
+TEST_F(VkLayerTest, CmdClearAttachmentTests) {
 
-    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT,
-                                         "vkCmdClearAttachments() issued on command buffer object ");
+    TEST_DESCRIPTION("Various tests for validating usage of vkCmdClearAttachments");
+    VkResult err;
 
     ASSERT_NO_FATAL_FAILURE(InitState());
     ASSERT_NO_FATAL_FAILURE(InitRenderTarget());
@@ -10319,8 +10316,23 @@
     color_attachment.colorAttachment = 0;
     VkClearRect clear_rect = {{{0, 0}, {(uint32_t)m_width, (uint32_t)m_height}}};
 
+    // Call for full-sized FB Color attachment prior to issuing a Draw
+    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT,
+        "vkCmdClearAttachments() issued on command buffer object ");
     vkCmdClearAttachments(m_commandBuffer->GetBufferHandle(), 1, &color_attachment, 1, &clear_rect);
+    m_errorMonitor->VerifyFound();
 
+
+    clear_rect.rect.extent.width = renderPassBeginInfo().renderArea.extent.width + 4;
+    clear_rect.rect.extent.height = clear_rect.rect.extent.height / 2;
+    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, VALIDATION_ERROR_01115);
+    vkCmdClearAttachments(m_commandBuffer->GetBufferHandle(), 1, &color_attachment, 1, &clear_rect);
+    m_errorMonitor->VerifyFound();
+
+    clear_rect.rect.extent.width = (uint32_t)m_width / 2;
+    clear_rect.layerCount = 2;
+    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, VALIDATION_ERROR_01116);
+    vkCmdClearAttachments(m_commandBuffer->GetBufferHandle(), 1, &color_attachment, 1, &clear_rect);
     m_errorMonitor->VerifyFound();
 
     vkDestroyPipelineLayout(m_device->device(), pipeline_layout, NULL);