commit e2ef9e6ba6afa713d7651f3a702aadc6a97ab3f1
author Karl Schultz <karl@lunarg.com> Fri Jan 13 14:01:35 2017 -0700
committer Karl Schultz <karl.w.schultz@gmail.com> Sat Jan 14 10:22:38 2017 -0700
tree d96fc3dfc80c62dfc1156a5a05d1ed55a40be0a8
parent 2c84c0cf10ef2c7508778d1b3befba6c01804400

loader: Fix static analysis warnings

Handle possible null pointer dereferences.
Misc other warnings, nothing too serious.
Not addressing alloca concerns yet.

Change-Id: I712a6b4996a4d900604867e373521ff4d1c53df5

loader/extensions.c

diff --git a/loader/extensions.c b/loader/extensions.c
index a57ab72..e135644 100644
--- a/loader/extensions.c
+++ b/loader/extensions.c
@@ -305,9 +305,10 @@
         loader_log(icd_term->this_instance, VK_DEBUG_REPORT_ERROR_BIT_EXT, 0,
                    "ICD associated with VkPhysicalDevice does not support "
                    "vkGetPhysicalDeviceGeneratedCommandsPropertiesNVX");
+    } else {
+        icd_term->GetPhysicalDeviceGeneratedCommandsPropertiesNVX(
+            phys_dev_term->phys_dev, pFeatures, pLimits);
     }
-    icd_term->GetPhysicalDeviceGeneratedCommandsPropertiesNVX(
-        phys_dev_term->phys_dev, pFeatures, pLimits);
 }
 
 // GPA helpers for non-KHR extensions